You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Jason Lowe (JIRA)" <ji...@apache.org> on 2012/09/27 01:07:07 UTC

[jira] [Created] (MAPREDUCE-4689) JobClient.getMapTaskReports on failed job results in NPE

Jason Lowe created MAPREDUCE-4689:
-------------------------------------

             Summary: JobClient.getMapTaskReports on failed job results in NPE
                 Key: MAPREDUCE-4689
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4689
             Project: Hadoop Map/Reduce
          Issue Type: Bug
          Components: client
    Affects Versions: 0.23.3
            Reporter: Jason Lowe


When calling JobClient.getMapTaskReports for a job that has failed results in an NPE.  For example:

{noformat}
Exception in thread "main" java.lang.NullPointerException
	at org.apache.hadoop.mapreduce.counters.AbstractCounters.<init>(AbstractCounters.java:107)
	at org.apache.hadoop.mapred.Counters.<init>(Counters.java:71)
	at org.apache.hadoop.mapred.Counters.downgrade(Counters.java:80)
	at org.apache.hadoop.mapred.TaskReport.downgrade(TaskReport.java:81)
	at org.apache.hadoop.mapred.TaskReport.downgradeArray(TaskReport.java:88)
	at org.apache.hadoop.mapred.JobClient.getTaskReports(JobClient.java:691)
	at org.apache.hadoop.mapred.JobClient.getMapTaskReports(JobClient.java:681)
...
{noformat}


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-4689) JobClient.getMapTaskReports on failed job results in NPE

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466212#comment-13466212 ] 

Hudson commented on MAPREDUCE-4689:
-----------------------------------

Integrated in Hadoop-Hdfs-trunk #1180 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1180/])
    MAPREDUCE-4689. JobClient.getMapTaskReports on failed job results in NPE (jlowe via bobby) (Revision 1391679)

     Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1391679
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTask.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/TestJobHistoryParsing.java

                
> JobClient.getMapTaskReports on failed job results in NPE
> --------------------------------------------------------
>
>                 Key: MAPREDUCE-4689
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4689
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.23.3
>            Reporter: Jason Lowe
>            Assignee: Jason Lowe
>             Fix For: 3.0.0, 0.23.4, 2.0.3-alpha
>
>         Attachments: MAPREDUCE-4689.patch
>
>
> When calling JobClient.getMapTaskReports for a job that has failed results in an NPE.  For example:
> {noformat}
> Exception in thread "main" java.lang.NullPointerException
> 	at org.apache.hadoop.mapreduce.counters.AbstractCounters.<init>(AbstractCounters.java:107)
> 	at org.apache.hadoop.mapred.Counters.<init>(Counters.java:71)
> 	at org.apache.hadoop.mapred.Counters.downgrade(Counters.java:80)
> 	at org.apache.hadoop.mapred.TaskReport.downgrade(TaskReport.java:81)
> 	at org.apache.hadoop.mapred.TaskReport.downgradeArray(TaskReport.java:88)
> 	at org.apache.hadoop.mapred.JobClient.getTaskReports(JobClient.java:691)
> 	at org.apache.hadoop.mapred.JobClient.getMapTaskReports(JobClient.java:681)
> ...
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (MAPREDUCE-4689) JobClient.getMapTaskReports on failed job results in NPE

Posted by "Jason Lowe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Lowe updated MAPREDUCE-4689:
----------------------------------

    Attachment: MAPREDUCE-4689.patch

Patch to CompletedTask so it returns empty counters instead of null counters in the task report.

In addition to unit test, I also manually tested it with a fail job and verified that JobClient.getMapTaskReports did not throw an NPE when it redirected to the historyserver for the failed job.
                
> JobClient.getMapTaskReports on failed job results in NPE
> --------------------------------------------------------
>
>                 Key: MAPREDUCE-4689
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4689
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.23.3
>            Reporter: Jason Lowe
>         Attachments: MAPREDUCE-4689.patch
>
>
> When calling JobClient.getMapTaskReports for a job that has failed results in an NPE.  For example:
> {noformat}
> Exception in thread "main" java.lang.NullPointerException
> 	at org.apache.hadoop.mapreduce.counters.AbstractCounters.<init>(AbstractCounters.java:107)
> 	at org.apache.hadoop.mapred.Counters.<init>(Counters.java:71)
> 	at org.apache.hadoop.mapred.Counters.downgrade(Counters.java:80)
> 	at org.apache.hadoop.mapred.TaskReport.downgrade(TaskReport.java:81)
> 	at org.apache.hadoop.mapred.TaskReport.downgradeArray(TaskReport.java:88)
> 	at org.apache.hadoop.mapred.JobClient.getTaskReports(JobClient.java:691)
> 	at org.apache.hadoop.mapred.JobClient.getMapTaskReports(JobClient.java:681)
> ...
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-4689) JobClient.getMapTaskReports on failed job results in NPE

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466203#comment-13466203 ] 

Hudson commented on MAPREDUCE-4689:
-----------------------------------

Integrated in Hadoop-Hdfs-0.23-Build #389 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/389/])
    svn merge -c 1391679 FIXES: MAPREDUCE-4689. JobClient.getMapTaskReports on failed job results in NPE (jlowe via bobby) (Revision 1391681)

     Result = UNSTABLE
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1391681
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTask.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/TestJobHistoryParsing.java

                
> JobClient.getMapTaskReports on failed job results in NPE
> --------------------------------------------------------
>
>                 Key: MAPREDUCE-4689
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4689
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.23.3
>            Reporter: Jason Lowe
>            Assignee: Jason Lowe
>             Fix For: 3.0.0, 0.23.4, 2.0.3-alpha
>
>         Attachments: MAPREDUCE-4689.patch
>
>
> When calling JobClient.getMapTaskReports for a job that has failed results in an NPE.  For example:
> {noformat}
> Exception in thread "main" java.lang.NullPointerException
> 	at org.apache.hadoop.mapreduce.counters.AbstractCounters.<init>(AbstractCounters.java:107)
> 	at org.apache.hadoop.mapred.Counters.<init>(Counters.java:71)
> 	at org.apache.hadoop.mapred.Counters.downgrade(Counters.java:80)
> 	at org.apache.hadoop.mapred.TaskReport.downgrade(TaskReport.java:81)
> 	at org.apache.hadoop.mapred.TaskReport.downgradeArray(TaskReport.java:88)
> 	at org.apache.hadoop.mapred.JobClient.getTaskReports(JobClient.java:691)
> 	at org.apache.hadoop.mapred.JobClient.getMapTaskReports(JobClient.java:681)
> ...
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (MAPREDUCE-4689) JobClient.getMapTaskReports on failed job results in NPE

Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Joseph Evans updated MAPREDUCE-4689:
-------------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.3-alpha
                   0.23.4
                   3.0.0
           Status: Resolved  (was: Patch Available)

Thanks Jason,

I put this into branch-2, branch-0.23, and trunk
                
> JobClient.getMapTaskReports on failed job results in NPE
> --------------------------------------------------------
>
>                 Key: MAPREDUCE-4689
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4689
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.23.3
>            Reporter: Jason Lowe
>            Assignee: Jason Lowe
>             Fix For: 3.0.0, 0.23.4, 2.0.3-alpha
>
>         Attachments: MAPREDUCE-4689.patch
>
>
> When calling JobClient.getMapTaskReports for a job that has failed results in an NPE.  For example:
> {noformat}
> Exception in thread "main" java.lang.NullPointerException
> 	at org.apache.hadoop.mapreduce.counters.AbstractCounters.<init>(AbstractCounters.java:107)
> 	at org.apache.hadoop.mapred.Counters.<init>(Counters.java:71)
> 	at org.apache.hadoop.mapred.Counters.downgrade(Counters.java:80)
> 	at org.apache.hadoop.mapred.TaskReport.downgrade(TaskReport.java:81)
> 	at org.apache.hadoop.mapred.TaskReport.downgradeArray(TaskReport.java:88)
> 	at org.apache.hadoop.mapred.JobClient.getTaskReports(JobClient.java:691)
> 	at org.apache.hadoop.mapred.JobClient.getMapTaskReports(JobClient.java:681)
> ...
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-4689) JobClient.getMapTaskReports on failed job results in NPE

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465958#comment-13465958 ] 

Hudson commented on MAPREDUCE-4689:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #2808 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2808/])
    MAPREDUCE-4689. JobClient.getMapTaskReports on failed job results in NPE (jlowe via bobby) (Revision 1391679)

     Result = FAILURE
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1391679
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTask.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/TestJobHistoryParsing.java

                
> JobClient.getMapTaskReports on failed job results in NPE
> --------------------------------------------------------
>
>                 Key: MAPREDUCE-4689
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4689
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.23.3
>            Reporter: Jason Lowe
>            Assignee: Jason Lowe
>         Attachments: MAPREDUCE-4689.patch
>
>
> When calling JobClient.getMapTaskReports for a job that has failed results in an NPE.  For example:
> {noformat}
> Exception in thread "main" java.lang.NullPointerException
> 	at org.apache.hadoop.mapreduce.counters.AbstractCounters.<init>(AbstractCounters.java:107)
> 	at org.apache.hadoop.mapred.Counters.<init>(Counters.java:71)
> 	at org.apache.hadoop.mapred.Counters.downgrade(Counters.java:80)
> 	at org.apache.hadoop.mapred.TaskReport.downgrade(TaskReport.java:81)
> 	at org.apache.hadoop.mapred.TaskReport.downgradeArray(TaskReport.java:88)
> 	at org.apache.hadoop.mapred.JobClient.getTaskReports(JobClient.java:691)
> 	at org.apache.hadoop.mapred.JobClient.getMapTaskReports(JobClient.java:681)
> ...
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-4689) JobClient.getMapTaskReports on failed job results in NPE

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465963#comment-13465963 ] 

Hudson commented on MAPREDUCE-4689:
-----------------------------------

Integrated in Hadoop-Common-trunk-Commit #2786 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2786/])
    MAPREDUCE-4689. JobClient.getMapTaskReports on failed job results in NPE (jlowe via bobby) (Revision 1391679)

     Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1391679
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTask.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/TestJobHistoryParsing.java

                
> JobClient.getMapTaskReports on failed job results in NPE
> --------------------------------------------------------
>
>                 Key: MAPREDUCE-4689
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4689
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.23.3
>            Reporter: Jason Lowe
>            Assignee: Jason Lowe
>         Attachments: MAPREDUCE-4689.patch
>
>
> When calling JobClient.getMapTaskReports for a job that has failed results in an NPE.  For example:
> {noformat}
> Exception in thread "main" java.lang.NullPointerException
> 	at org.apache.hadoop.mapreduce.counters.AbstractCounters.<init>(AbstractCounters.java:107)
> 	at org.apache.hadoop.mapred.Counters.<init>(Counters.java:71)
> 	at org.apache.hadoop.mapred.Counters.downgrade(Counters.java:80)
> 	at org.apache.hadoop.mapred.TaskReport.downgrade(TaskReport.java:81)
> 	at org.apache.hadoop.mapred.TaskReport.downgradeArray(TaskReport.java:88)
> 	at org.apache.hadoop.mapred.JobClient.getTaskReports(JobClient.java:691)
> 	at org.apache.hadoop.mapred.JobClient.getMapTaskReports(JobClient.java:681)
> ...
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-4689) JobClient.getMapTaskReports on failed job results in NPE

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465923#comment-13465923 ] 

Hadoop QA commented on MAPREDUCE-4689:
--------------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12547047/MAPREDUCE-4689.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2891//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2891//console

This message is automatically generated.
                
> JobClient.getMapTaskReports on failed job results in NPE
> --------------------------------------------------------
>
>                 Key: MAPREDUCE-4689
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4689
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.23.3
>            Reporter: Jason Lowe
>            Assignee: Jason Lowe
>         Attachments: MAPREDUCE-4689.patch
>
>
> When calling JobClient.getMapTaskReports for a job that has failed results in an NPE.  For example:
> {noformat}
> Exception in thread "main" java.lang.NullPointerException
> 	at org.apache.hadoop.mapreduce.counters.AbstractCounters.<init>(AbstractCounters.java:107)
> 	at org.apache.hadoop.mapred.Counters.<init>(Counters.java:71)
> 	at org.apache.hadoop.mapred.Counters.downgrade(Counters.java:80)
> 	at org.apache.hadoop.mapred.TaskReport.downgrade(TaskReport.java:81)
> 	at org.apache.hadoop.mapred.TaskReport.downgradeArray(TaskReport.java:88)
> 	at org.apache.hadoop.mapred.JobClient.getTaskReports(JobClient.java:691)
> 	at org.apache.hadoop.mapred.JobClient.getMapTaskReports(JobClient.java:681)
> ...
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-4689) JobClient.getMapTaskReports on failed job results in NPE

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465956#comment-13465956 ] 

Hudson commented on MAPREDUCE-4689:
-----------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #2849 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2849/])
    MAPREDUCE-4689. JobClient.getMapTaskReports on failed job results in NPE (jlowe via bobby) (Revision 1391679)

     Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1391679
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTask.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/TestJobHistoryParsing.java

                
> JobClient.getMapTaskReports on failed job results in NPE
> --------------------------------------------------------
>
>                 Key: MAPREDUCE-4689
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4689
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.23.3
>            Reporter: Jason Lowe
>            Assignee: Jason Lowe
>         Attachments: MAPREDUCE-4689.patch
>
>
> When calling JobClient.getMapTaskReports for a job that has failed results in an NPE.  For example:
> {noformat}
> Exception in thread "main" java.lang.NullPointerException
> 	at org.apache.hadoop.mapreduce.counters.AbstractCounters.<init>(AbstractCounters.java:107)
> 	at org.apache.hadoop.mapred.Counters.<init>(Counters.java:71)
> 	at org.apache.hadoop.mapred.Counters.downgrade(Counters.java:80)
> 	at org.apache.hadoop.mapred.TaskReport.downgrade(TaskReport.java:81)
> 	at org.apache.hadoop.mapred.TaskReport.downgradeArray(TaskReport.java:88)
> 	at org.apache.hadoop.mapred.JobClient.getTaskReports(JobClient.java:691)
> 	at org.apache.hadoop.mapred.JobClient.getMapTaskReports(JobClient.java:681)
> ...
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-4689) JobClient.getMapTaskReports on failed job results in NPE

Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465935#comment-13465935 ] 

Robert Joseph Evans commented on MAPREDUCE-4689:
------------------------------------------------

The patch looks OK to me +1.  But this seems more like a band-aide than a full solution.  Shouldn't we be returning counters for the failed tasks too, just like the AM does?
                
> JobClient.getMapTaskReports on failed job results in NPE
> --------------------------------------------------------
>
>                 Key: MAPREDUCE-4689
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4689
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.23.3
>            Reporter: Jason Lowe
>            Assignee: Jason Lowe
>         Attachments: MAPREDUCE-4689.patch
>
>
> When calling JobClient.getMapTaskReports for a job that has failed results in an NPE.  For example:
> {noformat}
> Exception in thread "main" java.lang.NullPointerException
> 	at org.apache.hadoop.mapreduce.counters.AbstractCounters.<init>(AbstractCounters.java:107)
> 	at org.apache.hadoop.mapred.Counters.<init>(Counters.java:71)
> 	at org.apache.hadoop.mapred.Counters.downgrade(Counters.java:80)
> 	at org.apache.hadoop.mapred.TaskReport.downgrade(TaskReport.java:81)
> 	at org.apache.hadoop.mapred.TaskReport.downgradeArray(TaskReport.java:88)
> 	at org.apache.hadoop.mapred.JobClient.getTaskReports(JobClient.java:691)
> 	at org.apache.hadoop.mapred.JobClient.getMapTaskReports(JobClient.java:681)
> ...
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (MAPREDUCE-4689) JobClient.getMapTaskReports on failed job results in NPE

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated MAPREDUCE-4689:
-------------------------------------

    Fix Version/s:     (was: 2.0.3-alpha)
                   2.0.2-alpha
    
> JobClient.getMapTaskReports on failed job results in NPE
> --------------------------------------------------------
>
>                 Key: MAPREDUCE-4689
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4689
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.23.3
>            Reporter: Jason Lowe
>            Assignee: Jason Lowe
>             Fix For: 3.0.0, 2.0.2-alpha, 0.23.4
>
>         Attachments: MAPREDUCE-4689.patch
>
>
> When calling JobClient.getMapTaskReports for a job that has failed results in an NPE.  For example:
> {noformat}
> Exception in thread "main" java.lang.NullPointerException
> 	at org.apache.hadoop.mapreduce.counters.AbstractCounters.<init>(AbstractCounters.java:107)
> 	at org.apache.hadoop.mapred.Counters.<init>(Counters.java:71)
> 	at org.apache.hadoop.mapred.Counters.downgrade(Counters.java:80)
> 	at org.apache.hadoop.mapred.TaskReport.downgrade(TaskReport.java:81)
> 	at org.apache.hadoop.mapred.TaskReport.downgradeArray(TaskReport.java:88)
> 	at org.apache.hadoop.mapred.JobClient.getTaskReports(JobClient.java:691)
> 	at org.apache.hadoop.mapred.JobClient.getMapTaskReports(JobClient.java:681)
> ...
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (MAPREDUCE-4689) JobClient.getMapTaskReports on failed job results in NPE

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy closed MAPREDUCE-4689.
------------------------------------

    
> JobClient.getMapTaskReports on failed job results in NPE
> --------------------------------------------------------
>
>                 Key: MAPREDUCE-4689
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4689
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.23.3
>            Reporter: Jason Lowe
>            Assignee: Jason Lowe
>             Fix For: 3.0.0, 2.0.2-alpha, 0.23.4
>
>         Attachments: MAPREDUCE-4689.patch
>
>
> When calling JobClient.getMapTaskReports for a job that has failed results in an NPE.  For example:
> {noformat}
> Exception in thread "main" java.lang.NullPointerException
> 	at org.apache.hadoop.mapreduce.counters.AbstractCounters.<init>(AbstractCounters.java:107)
> 	at org.apache.hadoop.mapred.Counters.<init>(Counters.java:71)
> 	at org.apache.hadoop.mapred.Counters.downgrade(Counters.java:80)
> 	at org.apache.hadoop.mapred.TaskReport.downgrade(TaskReport.java:81)
> 	at org.apache.hadoop.mapred.TaskReport.downgradeArray(TaskReport.java:88)
> 	at org.apache.hadoop.mapred.JobClient.getTaskReports(JobClient.java:691)
> 	at org.apache.hadoop.mapred.JobClient.getMapTaskReports(JobClient.java:681)
> ...
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-4689) JobClient.getMapTaskReports on failed job results in NPE

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466229#comment-13466229 ] 

Hudson commented on MAPREDUCE-4689:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk #1211 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1211/])
    MAPREDUCE-4689. JobClient.getMapTaskReports on failed job results in NPE (jlowe via bobby) (Revision 1391679)

     Result = FAILURE
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1391679
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTask.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/TestJobHistoryParsing.java

                
> JobClient.getMapTaskReports on failed job results in NPE
> --------------------------------------------------------
>
>                 Key: MAPREDUCE-4689
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4689
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.23.3
>            Reporter: Jason Lowe
>            Assignee: Jason Lowe
>             Fix For: 3.0.0, 0.23.4, 2.0.3-alpha
>
>         Attachments: MAPREDUCE-4689.patch
>
>
> When calling JobClient.getMapTaskReports for a job that has failed results in an NPE.  For example:
> {noformat}
> Exception in thread "main" java.lang.NullPointerException
> 	at org.apache.hadoop.mapreduce.counters.AbstractCounters.<init>(AbstractCounters.java:107)
> 	at org.apache.hadoop.mapred.Counters.<init>(Counters.java:71)
> 	at org.apache.hadoop.mapred.Counters.downgrade(Counters.java:80)
> 	at org.apache.hadoop.mapred.TaskReport.downgrade(TaskReport.java:81)
> 	at org.apache.hadoop.mapred.TaskReport.downgradeArray(TaskReport.java:88)
> 	at org.apache.hadoop.mapred.JobClient.getTaskReports(JobClient.java:691)
> 	at org.apache.hadoop.mapred.JobClient.getMapTaskReports(JobClient.java:681)
> ...
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (MAPREDUCE-4689) JobClient.getMapTaskReports on failed job results in NPE

Posted by "Jason Lowe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Lowe updated MAPREDUCE-4689:
----------------------------------

            Assignee: Jason Lowe
    Target Version/s: 0.23.4, 2.0.3-alpha
              Status: Patch Available  (was: Open)
    
> JobClient.getMapTaskReports on failed job results in NPE
> --------------------------------------------------------
>
>                 Key: MAPREDUCE-4689
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4689
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.23.3
>            Reporter: Jason Lowe
>            Assignee: Jason Lowe
>         Attachments: MAPREDUCE-4689.patch
>
>
> When calling JobClient.getMapTaskReports for a job that has failed results in an NPE.  For example:
> {noformat}
> Exception in thread "main" java.lang.NullPointerException
> 	at org.apache.hadoop.mapreduce.counters.AbstractCounters.<init>(AbstractCounters.java:107)
> 	at org.apache.hadoop.mapred.Counters.<init>(Counters.java:71)
> 	at org.apache.hadoop.mapred.Counters.downgrade(Counters.java:80)
> 	at org.apache.hadoop.mapred.TaskReport.downgrade(TaskReport.java:81)
> 	at org.apache.hadoop.mapred.TaskReport.downgradeArray(TaskReport.java:88)
> 	at org.apache.hadoop.mapred.JobClient.getTaskReports(JobClient.java:691)
> 	at org.apache.hadoop.mapred.JobClient.getMapTaskReports(JobClient.java:681)
> ...
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-4689) JobClient.getMapTaskReports on failed job results in NPE

Posted by "Jason Lowe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464269#comment-13464269 ] 

Jason Lowe commented on MAPREDUCE-4689:
---------------------------------------

The call appears to be fine while the failing job is up and running, but once it moves to the historyserver then it results in the NPE.  Apparently the historyserver is returning null for the task Counters when the task has failed, and the client isn't prepared to handle that.
                
> JobClient.getMapTaskReports on failed job results in NPE
> --------------------------------------------------------
>
>                 Key: MAPREDUCE-4689
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4689
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.23.3
>            Reporter: Jason Lowe
>
> When calling JobClient.getMapTaskReports for a job that has failed results in an NPE.  For example:
> {noformat}
> Exception in thread "main" java.lang.NullPointerException
> 	at org.apache.hadoop.mapreduce.counters.AbstractCounters.<init>(AbstractCounters.java:107)
> 	at org.apache.hadoop.mapred.Counters.<init>(Counters.java:71)
> 	at org.apache.hadoop.mapred.Counters.downgrade(Counters.java:80)
> 	at org.apache.hadoop.mapred.TaskReport.downgrade(TaskReport.java:81)
> 	at org.apache.hadoop.mapred.TaskReport.downgradeArray(TaskReport.java:88)
> 	at org.apache.hadoop.mapred.JobClient.getTaskReports(JobClient.java:691)
> 	at org.apache.hadoop.mapred.JobClient.getMapTaskReports(JobClient.java:681)
> ...
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira