You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/09/06 08:02:19 UTC
[GitHub] [hudi] shenh062326 opened a new pull request #2071: [HUDI-1143] Change timestamp field in HoodieTestDataGenerator from double to long
shenh062326 opened a new pull request #2071:
URL: https://github.com/apache/hudi/pull/2071
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] n3nash commented on pull request #2071: [HUDI-1143] Change timestamp field in HoodieTestDataGenerator from double to long
Posted by GitBox <gi...@apache.org>.
n3nash commented on pull request #2071:
URL: https://github.com/apache/hudi/pull/2071#issuecomment-693154745
@shenh062326 thanks for explaining.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] shenh062326 commented on pull request #2071: [HUDI-1143] Change timestamp field in HoodieTestDataGenerator from double to long
Posted by GitBox <gi...@apache.org>.
shenh062326 commented on pull request #2071:
URL: https://github.com/apache/hudi/pull/2071#issuecomment-690928998
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] n3nash commented on pull request #2071: [HUDI-1143] Change timestamp field in HoodieTestDataGenerator from double to long
Posted by GitBox <gi...@apache.org>.
n3nash commented on pull request #2071:
URL: https://github.com/apache/hudi/pull/2071#issuecomment-691200964
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] shenh062326 commented on pull request #2071: [HUDI-1143] Change timestamp field in HoodieTestDataGenerator from double to long
Posted by GitBox <gi...@apache.org>.
shenh062326 commented on pull request #2071:
URL: https://github.com/apache/hudi/pull/2071#issuecomment-690928998
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] n3nash commented on pull request #2071: [HUDI-1143] Change timestamp field in HoodieTestDataGenerator from double to long
Posted by GitBox <gi...@apache.org>.
n3nash commented on pull request #2071:
URL: https://github.com/apache/hudi/pull/2071#issuecomment-691200964
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] n3nash merged pull request #2071: [HUDI-1143] Change timestamp field in HoodieTestDataGenerator from double to long
Posted by GitBox <gi...@apache.org>.
n3nash merged pull request #2071:
URL: https://github.com/apache/hudi/pull/2071
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] shenh062326 commented on pull request #2071: [HUDI-1143] Change timestamp field in HoodieTestDataGenerator from double to long
Posted by GitBox <gi...@apache.org>.
shenh062326 commented on pull request #2071:
URL: https://github.com/apache/hudi/pull/2071#issuecomment-691584459
> @shenh062326 The PR looks fine to me, high level, what is the reason for this change ? Is it just to correct timestamp types ?
The Description in https://issues.apache.org/jira/browse/HUDI-1143 explain the reason:
"In order to help `TestBootstrap` succeed, had to turn the field into a regular long. We need to fix this correctly "
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] shenh062326 commented on pull request #2071: [HUDI-1143] Change timestamp field in HoodieTestDataGenerator from double to long
Posted by GitBox <gi...@apache.org>.
shenh062326 commented on pull request #2071:
URL: https://github.com/apache/hudi/pull/2071#issuecomment-690928998
@n3nash can you take a look at this MR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] shenh062326 commented on pull request #2071: [HUDI-1143] Change timestamp field in HoodieTestDataGenerator from double to long
Posted by GitBox <gi...@apache.org>.
shenh062326 commented on pull request #2071:
URL: https://github.com/apache/hudi/pull/2071#issuecomment-690928998
@n3nash can you take a look at this MR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] n3nash commented on pull request #2071: [HUDI-1143] Change timestamp field in HoodieTestDataGenerator from double to long
Posted by GitBox <gi...@apache.org>.
n3nash commented on pull request #2071:
URL: https://github.com/apache/hudi/pull/2071#issuecomment-691200964
@shenh062326 The PR looks fine to me, high level, what is the reason for this change ? Is it just to correct timestamp types ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org