You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/09 00:15:20 UTC
[GitHub] [airflow] potiuk opened a new pull request, #28247: Convert test_task_command to Pytest and unquarantine tests in it
potiuk opened a new pull request, #28247:
URL: https://github.com/apache/airflow/pull/28247
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28247: Convert test_task_command to Pytest and unquarantine tests in it
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28247:
URL: https://github.com/apache/airflow/pull/28247#issuecomment-1344104484
> Right now it is hardly possible to say this test actually fail with timeout error (default timeout 60 sec). Might be just in case better increase timeout for this test to 2 minutes?
Good call!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on pull request #28247: Convert test_task_command to Pytest and unquarantine tests in it
Posted by GitBox <gi...@apache.org>.
Taragolis commented on PR #28247:
URL: https://github.com/apache/airflow/pull/28247#issuecomment-1344099169
@potiuk I've just check execution duration
MSSQL
```text
============================ slowest 100 durations =============================
33.84s call tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_list_tasks
```
MySQL
```text
============================ slowest 100 durations =============================
31.99s call tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_list_tasks
```
SQLite
```text
============================ slowest 100 durations =============================
31.21s call tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_list_tasks
```
Postgres
```text
============================ slowest 100 durations =============================
22.95s call tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_list_tasks
```
When this class based on `unittest.TestCase` all test timeouts not applied into it.
Right now it is hardly possible to say this test actually fail with timeout error (default timeout 60 sec). Might be just in case better increase timeout for this test to 2 minutes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28247: Convert test_task_command to Pytest and unquarantine tests in it
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28247:
URL: https://github.com/apache/airflow/pull/28247#issuecomment-1344223800
This one is very likely fixed. It's been consistently failing in all Quarantine tests, so I am pretty sure that fix will work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #28247: Convert test_task_command to Pytest and unquarantine tests in it
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #28247:
URL: https://github.com/apache/airflow/pull/28247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org