You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2022/03/16 11:46:33 UTC
[GitHub] [tomcat] sim-lus opened a new pull request #482: replace deprecated getSubjectDN()
sim-lus opened a new pull request #482:
URL: https://github.com/apache/tomcat/pull/482
According to java spec, getSubjectDN() should not be used:
"denigrated, replaced by getSubjectX500Principal(). This method returns the subject as an implementation specific Principal object, which should not be relied upon by portable code."
Not sure if my proposed change is correct, at least it is probably not compatible for all use cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf merged pull request #482: replace deprecated getSubjectDN()
Posted by GitBox <gi...@apache.org>.
markt-asf merged pull request #482:
URL: https://github.com/apache/tomcat/pull/482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #482: replace deprecated getSubjectDN()
Posted by GitBox <gi...@apache.org>.
markt-asf commented on pull request #482:
URL: https://github.com/apache/tomcat/pull/482#issuecomment-1082404289
Ah. Problem solved. Just need to specify RFC 1779 format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] ChristopherSchultz commented on pull request #482: replace deprecated getSubjectDN()
Posted by GitBox <gi...@apache.org>.
ChristopherSchultz commented on pull request #482:
URL: https://github.com/apache/tomcat/pull/482#issuecomment-1069321989
LGTM. getSubjectX500Principal was added in Java 1.4 so we should be good all the way back to 8.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #482: replace deprecated getSubjectDN()
Posted by GitBox <gi...@apache.org>.
markt-asf commented on pull request #482:
URL: https://github.com/apache/tomcat/pull/482#issuecomment-1082401729
There is an issue here. `getSubjectDN()` returns a DN that includes spaces between the attribute name/value pairs. `getSubjectX500Principal().getName()` does not include spaces. That is going to create backwards compatibility issues. This is going to need a re-think. I'll follow-up on the dev@ list
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org