You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by dpogue <gi...@git.apache.org> on 2016/10/28 20:12:18 UTC
[GitHub] cordova-android pull request #343: CB-12077: Fix paths for Android icons/spl...
GitHub user dpogue opened a pull request:
https://github.com/apache/cordova-android/pull/343
CB-12077: Fix paths for Android icons/splashscreens
### Platforms affected
Android
### What does this PR do?
Fix icons and splashscreens defined in config.xml copying into the project to override the default Cordova ones.
### What testing has been done on this change?
Tested locally with cordova-cli
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dpogue/cordova-android fix-icons
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/343.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #343
----
commit db198eba9ada727025e63c8709c78f17ee0cecea
Author: Darryl Pogue <da...@ayogo.com>
Date: 2016-10-28T20:05:01Z
CB-12077: Fix paths for Android icons/splashscreens
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #343: CB-12077: Fix paths for Android icons/splashscre...
Posted by rodrigograca31 <gi...@git.apache.org>.
Github user rodrigograca31 commented on the issue:
https://github.com/apache/cordova-android/pull/343
Notes:
This issue is solved in `cordova-android 6.1.0` but if you try `cordova platform update android` at this moment doesn't update to `6.1.0`.
Run
```bash
cordova platform update android@6.1.0 --save
cordova platform rm android
cordova platform add android
```
to solve this issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #343: CB-12077: Fix paths for Android icons/splashscre...
Posted by mattroth <gi...@git.apache.org>.
Github user mattroth commented on the issue:
https://github.com/apache/cordova-android/pull/343
Does anyone have a work around? How can I update cordova-android on my development machine with this above fix prior to the next release?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #343: CB-12077: Fix paths for Android icons/splashscre...
Posted by rodrigograca31 <gi...@git.apache.org>.
Github user rodrigograca31 commented on the issue:
https://github.com/apache/cordova-android/pull/343
Notes:
This issue is solved in `cordova-android 6.1.0` but if you try `cordova platform update android` at this moment doesn't update to `6.1.0`, if you are experiencing this problem edit your `config.xml` and change `6.0.0` to `6.1.0` (and test to make sure no other problems exist because of this change...)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #343: CB-12077: Fix paths for Android icons/splashscre...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-android/pull/343
you can use cordova-android from master with `cordova platform add android@https://github.com/apache/cordova-android` or the previous version with `cordova platform add android@5.2.2`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #343: CB-12077: Fix paths for Android icons/splashscre...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-android/pull/343
## [Current coverage](https://codecov.io/gh/apache/cordova-android/pull/343?src=pr) is 35.21% (diff: 0.00%)
> Merging [#343](https://codecov.io/gh/apache/cordova-android/pull/343?src=pr) into [master](https://codecov.io/gh/apache/cordova-android/branch/master?src=pr) will not change coverage
```diff
@@ master #343 diff @@
==========================================
Files 12 12
Lines 1028 1028
Methods 202 202
Messages 0 0
Branches 169 169
==========================================
Hits 362 362
Misses 666 666
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [1f06176...db198eb](https://codecov.io/gh/apache/cordova-android/compare/1f06176149a49dd5a28e491c948ea98200ed6c1f...db198eba9ada727025e63c8709c78f17ee0cecea?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request #343: CB-12077: Fix paths for Android icons/spl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/343
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org