You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/07 20:28:22 UTC

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #533: [issue 516]Add lock for compressionProviders to fix data race problem

cckellogg commented on a change in pull request #533:
URL: https://github.com/apache/pulsar-client-go/pull/533#discussion_r646916865



##########
File path: pulsar/consumer_partition.go
##########
@@ -1072,6 +1076,7 @@ func (pc *partitionConsumer) Decompress(msgMeta *pb.MessageMetadata, payload int
 
 		pc.compressionProviders[msgMeta.GetCompression()] = provider
 	}
+	pc.providersMutex.UnLock()

Review comment:
       There is spot above where the code could return without releasing the lock.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org