You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Dan Norris <pr...@gmail.com> on 2014/04/11 04:14:59 UTC

Review Request 20249: AURORA-244: Fix zookeeper logs being swallowed due to missing log4j.properties

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20249/
-----------------------------------------------------------

Review request for Aurora and Kevin Sweeney.


Bugs: AURORA-244
    https://issues.apache.org/jira/browse/AURORA-244


Repository: aurora


Description
-------

AURORA-244: Fix zookeeper logs being swallowed due to missing log4j.properties


Diffs
-----

  examples/vagrant/upstart/aurora-scheduler.conf ec9e1b8db6a3d08c0a95765f4d78ffc43d5816b3 

Diff: https://reviews.apache.org/r/20249/diff/


Testing
-------

In Vagrant: 

sudo stop aurora-scheduler; sudo rm /var/log/upstart/aurora-scheduler.log; sudo start aurora-scheduler. No more message about a missing log4j appender.


Thanks,

Dan Norris


Re: Review Request 20249: AURORA-244: Fix zookeeper logs being swallowed due to missing log4j.properties

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20249/#review40295
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Sweeney


On April 10, 2014, 7:18 p.m., Dan Norris wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20249/
> -----------------------------------------------------------
> 
> (Updated April 10, 2014, 7:18 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-244
>     https://issues.apache.org/jira/browse/AURORA-244
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-244: Fix zookeeper logs being swallowed due to missing log4j.properties
> 
> I ended up just using the default log4j properties file that comes with Zookeeper. We might just want to write our own and use that in the Vagrant image.
> 
> 
> Diffs
> -----
> 
>   examples/vagrant/upstart/aurora-scheduler.conf ec9e1b8db6a3d08c0a95765f4d78ffc43d5816b3 
> 
> Diff: https://reviews.apache.org/r/20249/diff/
> 
> 
> Testing
> -------
> 
> In Vagrant: 
> 
> sudo stop aurora-scheduler; sudo rm /var/log/upstart/aurora-scheduler.log; sudo start aurora-scheduler. No more message about a missing log4j appender.
> 
> 
> Thanks,
> 
> Dan Norris
> 
>


Re: Review Request 20249: AURORA-244: Fix zookeeper logs being swallowed due to missing log4j.properties

Posted by Dan Norris <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20249/
-----------------------------------------------------------

(Updated April 11, 2014, 2:18 a.m.)


Review request for Aurora and Kevin Sweeney.


Bugs: AURORA-244
    https://issues.apache.org/jira/browse/AURORA-244


Repository: aurora


Description (updated)
-------

AURORA-244: Fix zookeeper logs being swallowed due to missing log4j.properties

I ended up just using the default log4j properties file that comes with Zookeeper. We might just want to write our own and use that in the Vagrant image.


Diffs
-----

  examples/vagrant/upstart/aurora-scheduler.conf ec9e1b8db6a3d08c0a95765f4d78ffc43d5816b3 

Diff: https://reviews.apache.org/r/20249/diff/


Testing
-------

In Vagrant: 

sudo stop aurora-scheduler; sudo rm /var/log/upstart/aurora-scheduler.log; sudo start aurora-scheduler. No more message about a missing log4j appender.


Thanks,

Dan Norris