You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Sijie Guo <gu...@gmail.com> on 2018/08/27 08:37:56 UTC
[VOTE] Apache BookKeeper Release 4.7.2, release candidate #0
Hi everyone,
Please review and vote on the release candidate #0 for the version 4.7.2,
as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)
The complete staging area is available for your review, which includes:
* Release notes [1]
* The official Apache source and binary distributions to be deployed to
dist.apache.org [2]
* All artifacts to be deployed to the Maven Central Repository [3]
* Source code tag "v4.7.2-rc0" [4] with git
sha ea072c8f8b9d20651b513036c09f264ca5c7ec6e
BookKeeper's KEYS file contains PGP keys we used to sign this release:
https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
Please download these packages and review this release candidate:
- Review release notes
- Download the source package (verify shasum, and asc) and follow the
instructions to build and run the bookkeeper service.
- Download the binary package (verify shasum, and asc) and follow the
instructions to run the bookkeeper service.
- Review maven repo, release tag, licenses, and any other things you think
it is important to a release.
The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.
Thanks,
Sijie Guo
[1] https://github.com/apache/bookkeeper/pull/1628
[2] https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.7.2-rc0/
[3]
https://repository.apache.org/content/repositories/orgapachebookkeeper-1031/
[4] https://github.com/apache/bookkeeper/tree/v4.7.2-rc0
[RESULT] [VOTE] Apache BookKeeper Release 4.7.2, release candidate #0
Posted by Sijie Guo <gu...@gmail.com>.
The release is approved with 4 +1 binding votes:
- Enrico Olivelli
- Ivan Kelly
- Matteo Merli
- Sijie Guo
- Sijie
On Mon, Aug 27, 2018 at 1:37 AM Sijie Guo <gu...@gmail.com> wrote:
> Hi everyone,
>
> Please review and vote on the release candidate #0 for the version 4.7.2,
> as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> The complete staging area is available for your review, which includes:
> * Release notes [1]
> * The official Apache source and binary distributions to be deployed to
> dist.apache.org [2]
> * All artifacts to be deployed to the Maven Central Repository [3]
> * Source code tag "v4.7.2-rc0" [4] with git
> sha ea072c8f8b9d20651b513036c09f264ca5c7ec6e
>
> BookKeeper's KEYS file contains PGP keys we used to sign this release:
> https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
>
> Please download these packages and review this release candidate:
>
> - Review release notes
> - Download the source package (verify shasum, and asc) and follow the
> instructions to build and run the bookkeeper service.
> - Download the binary package (verify shasum, and asc) and follow the
> instructions to run the bookkeeper service.
> - Review maven repo, release tag, licenses, and any other things you think
> it is important to a release.
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Sijie Guo
>
> [1] https://github.com/apache/bookkeeper/pull/1628
> [2]
> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.7.2-rc0/
> [3]
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1031/
> [4] https://github.com/apache/bookkeeper/tree/v4.7.2-rc0
>
Re: [VOTE] Apache BookKeeper Release 4.7.2, release candidate #0
Posted by Ivan Kelly <iv...@apache.org>.
+1 (binding)
* Sigs good, checksums good
* Rat is good
* Licenses pass the automated check
* Tests pass
* Integration smoke test passes
-Ivan
On Tue, Aug 28, 2018 at 8:57 PM, Matteo Merli <ma...@gmail.com> wrote:
> +1 (binding)
>
> * Checked signatures, LICENSES
> * Checked Maven repository
> * Started localbookie
>
>
> On Tue, Aug 28, 2018 at 11:54 AM Sijie Guo <gu...@gmail.com> wrote:
>
>> According to http://www.apache.org/dev/release-distribution#sigs-and-sums,
>> we need sha512 not sha1.
>>
>> Since it only changes the signatures files, I didn't cancel the vote.
>> Please review the sha512 files instead.
>>
>> - Sijie
>>
>> On Tue, Aug 28, 2018 at 8:03 AM Enrico Olivelli <eo...@gmail.com>
>> wrote:
>>
>> > +1 (binding)
>> > verified signatures/sha, RAT, spotbugs
>> > built and run tests from src candidate package (on Linux Fedora 27,
>> Oracle
>> > JDK8)
>> > tested with some client application
>> >
>> > I have these flaky tests (not blocker for release):
>> > the first BookieInitializationTest) is very usual on Fedora machines, I
>> > have already tracked the issue
>> > the second failure (TestHttpService) happens only if running the whole
>> > TestHttpService file, not the single test
>> > this is the issue https://github.com/apache/bookkeeper/issues/1630
>> >
>> > [ERROR] Failures:
>> > [ERROR]
>> >
>> >
>> org.apache.bookkeeper.bookie.BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile(org.apache.bookkeeper.bookie.BookieInitializationTest)
>> > [ERROR] Run 1:
>> >
>> BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile:754
>> > Bookie should be up and running
>> > [ERROR] Run 2:
>> >
>> BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile:754
>> > Bookie should be up and running
>> > [ERROR] Run 3:
>> >
>> BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile:754
>> > Bookie should be up and running
>> > [INFO]
>> > [ERROR]
>> >
>> >
>> org.apache.bookkeeper.server.http.TestHttpService.testWhoIsAuditorService(org.apache.bookkeeper.server.http.TestHttpService)
>> > [ERROR] Run 1: TestHttpService.testWhoIsAuditorService:638
>> expected:<200>
>> > but was:<404>
>> > [ERROR] Run 2: TestHttpService.testWhoIsAuditorService:638
>> expected:<200>
>> > but was:<404>
>> > [ERROR] Run 3: TestHttpService.testWhoIsAuditorService:638
>> expected:<200>
>> > but was:<404>
>> >
>> > Enrico
>> >
>> >
>> > Il giorno lun 27 ago 2018 alle ore 20:01 Sijie Guo <gu...@gmail.com>
>> ha
>> > scritto:
>> >
>> > > Enrico,
>> > >
>> > > I fixed the sha files.
>> > >
>> > > - Sijie
>> > >
>> > > On Mon, Aug 27, 2018 at 10:57 AM Sijie Guo <gu...@gmail.com> wrote:
>> > >
>> > > > Ah I see. I think the script wasn't fixed in branch-4.7. Let me
>> update
>> > > > those sha files.
>> > > >
>> > > > - Sijie
>> > > >
>> > > > On Mon, Aug 27, 2018 at 6:51 AM Enrico Olivelli <eolivelli@gmail.com
>> >
>> > > > wrote:
>> > > >
>> > > >> Sijie,
>> > > >> thank you for running the release
>> > > >>
>> > > >> the .sha files contains absolute paths
>> > > >> af1c5f1451fc02fb60bfe8eac91c0f5bd54895ad
>> > > >>
>> > > >>
>> > >
>> >
>> /Users/sijie/Workspaces/bookkeeper/target/dist_dev/bookkeeper/bookkeeper-4.7.2-rc0/bookkeeper-4.7.2-src.tar.gz
>> > > >> 30c6a6b75c3715572f2d37ff69d0b08b1dfcf6ac
>> > > >>
>> > > >>
>> > >
>> >
>> /Users/sijie/Workspaces/bookkeeper/target/dist_dev/bookkeeper/bookkeeper-4.7.2-rc0/bookkeeper-all-4.7.2-bin.tar.gz
>> > > >> 08d6cd1920e4d3f140911c4e71235bf27729abd5
>> > > >>
>> > > >>
>> > >
>> >
>> /Users/sijie/Workspaces/bookkeeper/target/dist_dev/bookkeeper/bookkeeper-4.7.2-rc0/bookkeeper-server-4.7.2-bin.tar.gz
>> > > >>
>> > > >> can you please fix them ?
>> > > >> then I will be able to send a (positive) vote
>> > > >>
>> > > >> Enrico
>> > > >>
>> > > >> Il giorno lun 27 ago 2018 alle ore 10:38 Sijie Guo <
>> > guosijie@gmail.com>
>> > > >> ha
>> > > >> scritto:
>> > > >>
>> > > >> > Hi everyone,
>> > > >> >
>> > > >> > Please review and vote on the release candidate #0 for the version
>> > > >> 4.7.2,
>> > > >> > as follows:
>> > > >> > [ ] +1, Approve the release
>> > > >> > [ ] -1, Do not approve the release (please provide specific
>> > comments)
>> > > >> >
>> > > >> > The complete staging area is available for your review, which
>> > > includes:
>> > > >> > * Release notes [1]
>> > > >> > * The official Apache source and binary distributions to be
>> deployed
>> > > to
>> > > >> > dist.apache.org [2]
>> > > >> > * All artifacts to be deployed to the Maven Central Repository [3]
>> > > >> > * Source code tag "v4.7.2-rc0" [4] with git
>> > > >> > sha ea072c8f8b9d20651b513036c09f264ca5c7ec6e
>> > > >> >
>> > > >> > BookKeeper's KEYS file contains PGP keys we used to sign this
>> > release:
>> > > >> > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
>> > > >> >
>> > > >> > Please download these packages and review this release candidate:
>> > > >> >
>> > > >> > - Review release notes
>> > > >> > - Download the source package (verify shasum, and asc) and follow
>> > the
>> > > >> > instructions to build and run the bookkeeper service.
>> > > >> > - Download the binary package (verify shasum, and asc) and follow
>> > the
>> > > >> > instructions to run the bookkeeper service.
>> > > >> > - Review maven repo, release tag, licenses, and any other things
>> you
>> > > >> think
>> > > >> > it is important to a release.
>> > > >> >
>> > > >> > The vote will be open for at least 72 hours. It is adopted by
>> > majority
>> > > >> > approval, with at least 3 PMC affirmative votes.
>> > > >> >
>> > > >> > Thanks,
>> > > >> > Sijie Guo
>> > > >> >
>> > > >> > [1] https://github.com/apache/bookkeeper/pull/1628
>> > > >> > [2]
>> > > >> >
>> > >
>> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.7.2-rc0/
>> > > >> > [3]
>> > > >> >
>> > > >> >
>> > > >>
>> > >
>> >
>> https://repository.apache.org/content/repositories/orgapachebookkeeper-1031/
>> > > >> > [4] https://github.com/apache/bookkeeper/tree/v4.7.2-rc0
>> > > >> >
>> > > >>
>> > > >
>> > >
>> >
>>
> --
> Matteo Merli
> <mm...@apache.org>
Re: [VOTE] Apache BookKeeper Release 4.7.2, release candidate #0
Posted by Matteo Merli <ma...@gmail.com>.
+1 (binding)
* Checked signatures, LICENSES
* Checked Maven repository
* Started localbookie
On Tue, Aug 28, 2018 at 11:54 AM Sijie Guo <gu...@gmail.com> wrote:
> According to http://www.apache.org/dev/release-distribution#sigs-and-sums,
> we need sha512 not sha1.
>
> Since it only changes the signatures files, I didn't cancel the vote.
> Please review the sha512 files instead.
>
> - Sijie
>
> On Tue, Aug 28, 2018 at 8:03 AM Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > +1 (binding)
> > verified signatures/sha, RAT, spotbugs
> > built and run tests from src candidate package (on Linux Fedora 27,
> Oracle
> > JDK8)
> > tested with some client application
> >
> > I have these flaky tests (not blocker for release):
> > the first BookieInitializationTest) is very usual on Fedora machines, I
> > have already tracked the issue
> > the second failure (TestHttpService) happens only if running the whole
> > TestHttpService file, not the single test
> > this is the issue https://github.com/apache/bookkeeper/issues/1630
> >
> > [ERROR] Failures:
> > [ERROR]
> >
> >
> org.apache.bookkeeper.bookie.BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile(org.apache.bookkeeper.bookie.BookieInitializationTest)
> > [ERROR] Run 1:
> >
> BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile:754
> > Bookie should be up and running
> > [ERROR] Run 2:
> >
> BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile:754
> > Bookie should be up and running
> > [ERROR] Run 3:
> >
> BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile:754
> > Bookie should be up and running
> > [INFO]
> > [ERROR]
> >
> >
> org.apache.bookkeeper.server.http.TestHttpService.testWhoIsAuditorService(org.apache.bookkeeper.server.http.TestHttpService)
> > [ERROR] Run 1: TestHttpService.testWhoIsAuditorService:638
> expected:<200>
> > but was:<404>
> > [ERROR] Run 2: TestHttpService.testWhoIsAuditorService:638
> expected:<200>
> > but was:<404>
> > [ERROR] Run 3: TestHttpService.testWhoIsAuditorService:638
> expected:<200>
> > but was:<404>
> >
> > Enrico
> >
> >
> > Il giorno lun 27 ago 2018 alle ore 20:01 Sijie Guo <gu...@gmail.com>
> ha
> > scritto:
> >
> > > Enrico,
> > >
> > > I fixed the sha files.
> > >
> > > - Sijie
> > >
> > > On Mon, Aug 27, 2018 at 10:57 AM Sijie Guo <gu...@gmail.com> wrote:
> > >
> > > > Ah I see. I think the script wasn't fixed in branch-4.7. Let me
> update
> > > > those sha files.
> > > >
> > > > - Sijie
> > > >
> > > > On Mon, Aug 27, 2018 at 6:51 AM Enrico Olivelli <eolivelli@gmail.com
> >
> > > > wrote:
> > > >
> > > >> Sijie,
> > > >> thank you for running the release
> > > >>
> > > >> the .sha files contains absolute paths
> > > >> af1c5f1451fc02fb60bfe8eac91c0f5bd54895ad
> > > >>
> > > >>
> > >
> >
> /Users/sijie/Workspaces/bookkeeper/target/dist_dev/bookkeeper/bookkeeper-4.7.2-rc0/bookkeeper-4.7.2-src.tar.gz
> > > >> 30c6a6b75c3715572f2d37ff69d0b08b1dfcf6ac
> > > >>
> > > >>
> > >
> >
> /Users/sijie/Workspaces/bookkeeper/target/dist_dev/bookkeeper/bookkeeper-4.7.2-rc0/bookkeeper-all-4.7.2-bin.tar.gz
> > > >> 08d6cd1920e4d3f140911c4e71235bf27729abd5
> > > >>
> > > >>
> > >
> >
> /Users/sijie/Workspaces/bookkeeper/target/dist_dev/bookkeeper/bookkeeper-4.7.2-rc0/bookkeeper-server-4.7.2-bin.tar.gz
> > > >>
> > > >> can you please fix them ?
> > > >> then I will be able to send a (positive) vote
> > > >>
> > > >> Enrico
> > > >>
> > > >> Il giorno lun 27 ago 2018 alle ore 10:38 Sijie Guo <
> > guosijie@gmail.com>
> > > >> ha
> > > >> scritto:
> > > >>
> > > >> > Hi everyone,
> > > >> >
> > > >> > Please review and vote on the release candidate #0 for the version
> > > >> 4.7.2,
> > > >> > as follows:
> > > >> > [ ] +1, Approve the release
> > > >> > [ ] -1, Do not approve the release (please provide specific
> > comments)
> > > >> >
> > > >> > The complete staging area is available for your review, which
> > > includes:
> > > >> > * Release notes [1]
> > > >> > * The official Apache source and binary distributions to be
> deployed
> > > to
> > > >> > dist.apache.org [2]
> > > >> > * All artifacts to be deployed to the Maven Central Repository [3]
> > > >> > * Source code tag "v4.7.2-rc0" [4] with git
> > > >> > sha ea072c8f8b9d20651b513036c09f264ca5c7ec6e
> > > >> >
> > > >> > BookKeeper's KEYS file contains PGP keys we used to sign this
> > release:
> > > >> > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> > > >> >
> > > >> > Please download these packages and review this release candidate:
> > > >> >
> > > >> > - Review release notes
> > > >> > - Download the source package (verify shasum, and asc) and follow
> > the
> > > >> > instructions to build and run the bookkeeper service.
> > > >> > - Download the binary package (verify shasum, and asc) and follow
> > the
> > > >> > instructions to run the bookkeeper service.
> > > >> > - Review maven repo, release tag, licenses, and any other things
> you
> > > >> think
> > > >> > it is important to a release.
> > > >> >
> > > >> > The vote will be open for at least 72 hours. It is adopted by
> > majority
> > > >> > approval, with at least 3 PMC affirmative votes.
> > > >> >
> > > >> > Thanks,
> > > >> > Sijie Guo
> > > >> >
> > > >> > [1] https://github.com/apache/bookkeeper/pull/1628
> > > >> > [2]
> > > >> >
> > >
> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.7.2-rc0/
> > > >> > [3]
> > > >> >
> > > >> >
> > > >>
> > >
> >
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1031/
> > > >> > [4] https://github.com/apache/bookkeeper/tree/v4.7.2-rc0
> > > >> >
> > > >>
> > > >
> > >
> >
>
--
Matteo Merli
<mm...@apache.org>
Re: [VOTE] Apache BookKeeper Release 4.7.2, release candidate #0
Posted by Sijie Guo <gu...@gmail.com>.
According to http://www.apache.org/dev/release-distribution#sigs-and-sums,
we need sha512 not sha1.
Since it only changes the signatures files, I didn't cancel the vote.
Please review the sha512 files instead.
- Sijie
On Tue, Aug 28, 2018 at 8:03 AM Enrico Olivelli <eo...@gmail.com> wrote:
> +1 (binding)
> verified signatures/sha, RAT, spotbugs
> built and run tests from src candidate package (on Linux Fedora 27, Oracle
> JDK8)
> tested with some client application
>
> I have these flaky tests (not blocker for release):
> the first BookieInitializationTest) is very usual on Fedora machines, I
> have already tracked the issue
> the second failure (TestHttpService) happens only if running the whole
> TestHttpService file, not the single test
> this is the issue https://github.com/apache/bookkeeper/issues/1630
>
> [ERROR] Failures:
> [ERROR]
>
> org.apache.bookkeeper.bookie.BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile(org.apache.bookkeeper.bookie.BookieInitializationTest)
> [ERROR] Run 1:
> BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile:754
> Bookie should be up and running
> [ERROR] Run 2:
> BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile:754
> Bookie should be up and running
> [ERROR] Run 3:
> BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile:754
> Bookie should be up and running
> [INFO]
> [ERROR]
>
> org.apache.bookkeeper.server.http.TestHttpService.testWhoIsAuditorService(org.apache.bookkeeper.server.http.TestHttpService)
> [ERROR] Run 1: TestHttpService.testWhoIsAuditorService:638 expected:<200>
> but was:<404>
> [ERROR] Run 2: TestHttpService.testWhoIsAuditorService:638 expected:<200>
> but was:<404>
> [ERROR] Run 3: TestHttpService.testWhoIsAuditorService:638 expected:<200>
> but was:<404>
>
> Enrico
>
>
> Il giorno lun 27 ago 2018 alle ore 20:01 Sijie Guo <gu...@gmail.com> ha
> scritto:
>
> > Enrico,
> >
> > I fixed the sha files.
> >
> > - Sijie
> >
> > On Mon, Aug 27, 2018 at 10:57 AM Sijie Guo <gu...@gmail.com> wrote:
> >
> > > Ah I see. I think the script wasn't fixed in branch-4.7. Let me update
> > > those sha files.
> > >
> > > - Sijie
> > >
> > > On Mon, Aug 27, 2018 at 6:51 AM Enrico Olivelli <eo...@gmail.com>
> > > wrote:
> > >
> > >> Sijie,
> > >> thank you for running the release
> > >>
> > >> the .sha files contains absolute paths
> > >> af1c5f1451fc02fb60bfe8eac91c0f5bd54895ad
> > >>
> > >>
> >
> /Users/sijie/Workspaces/bookkeeper/target/dist_dev/bookkeeper/bookkeeper-4.7.2-rc0/bookkeeper-4.7.2-src.tar.gz
> > >> 30c6a6b75c3715572f2d37ff69d0b08b1dfcf6ac
> > >>
> > >>
> >
> /Users/sijie/Workspaces/bookkeeper/target/dist_dev/bookkeeper/bookkeeper-4.7.2-rc0/bookkeeper-all-4.7.2-bin.tar.gz
> > >> 08d6cd1920e4d3f140911c4e71235bf27729abd5
> > >>
> > >>
> >
> /Users/sijie/Workspaces/bookkeeper/target/dist_dev/bookkeeper/bookkeeper-4.7.2-rc0/bookkeeper-server-4.7.2-bin.tar.gz
> > >>
> > >> can you please fix them ?
> > >> then I will be able to send a (positive) vote
> > >>
> > >> Enrico
> > >>
> > >> Il giorno lun 27 ago 2018 alle ore 10:38 Sijie Guo <
> guosijie@gmail.com>
> > >> ha
> > >> scritto:
> > >>
> > >> > Hi everyone,
> > >> >
> > >> > Please review and vote on the release candidate #0 for the version
> > >> 4.7.2,
> > >> > as follows:
> > >> > [ ] +1, Approve the release
> > >> > [ ] -1, Do not approve the release (please provide specific
> comments)
> > >> >
> > >> > The complete staging area is available for your review, which
> > includes:
> > >> > * Release notes [1]
> > >> > * The official Apache source and binary distributions to be deployed
> > to
> > >> > dist.apache.org [2]
> > >> > * All artifacts to be deployed to the Maven Central Repository [3]
> > >> > * Source code tag "v4.7.2-rc0" [4] with git
> > >> > sha ea072c8f8b9d20651b513036c09f264ca5c7ec6e
> > >> >
> > >> > BookKeeper's KEYS file contains PGP keys we used to sign this
> release:
> > >> > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> > >> >
> > >> > Please download these packages and review this release candidate:
> > >> >
> > >> > - Review release notes
> > >> > - Download the source package (verify shasum, and asc) and follow
> the
> > >> > instructions to build and run the bookkeeper service.
> > >> > - Download the binary package (verify shasum, and asc) and follow
> the
> > >> > instructions to run the bookkeeper service.
> > >> > - Review maven repo, release tag, licenses, and any other things you
> > >> think
> > >> > it is important to a release.
> > >> >
> > >> > The vote will be open for at least 72 hours. It is adopted by
> majority
> > >> > approval, with at least 3 PMC affirmative votes.
> > >> >
> > >> > Thanks,
> > >> > Sijie Guo
> > >> >
> > >> > [1] https://github.com/apache/bookkeeper/pull/1628
> > >> > [2]
> > >> >
> > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.7.2-rc0/
> > >> > [3]
> > >> >
> > >> >
> > >>
> >
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1031/
> > >> > [4] https://github.com/apache/bookkeeper/tree/v4.7.2-rc0
> > >> >
> > >>
> > >
> >
>
Re: [VOTE] Apache BookKeeper Release 4.7.2, release candidate #0
Posted by Enrico Olivelli <eo...@gmail.com>.
+1 (binding)
verified signatures/sha, RAT, spotbugs
built and run tests from src candidate package (on Linux Fedora 27, Oracle
JDK8)
tested with some client application
I have these flaky tests (not blocker for release):
the first BookieInitializationTest) is very usual on Fedora machines, I
have already tracked the issue
the second failure (TestHttpService) happens only if running the whole
TestHttpService file, not the single test
this is the issue https://github.com/apache/bookkeeper/issues/1630
[ERROR] Failures:
[ERROR]
org.apache.bookkeeper.bookie.BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile(org.apache.bookkeeper.bookie.BookieInitializationTest)
[ERROR] Run 1:
BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile:754
Bookie should be up and running
[ERROR] Run 2:
BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile:754
Bookie should be up and running
[ERROR] Run 3:
BookieInitializationTest.testWithDiskFullAndAbilityToCreateNewIndexFile:754
Bookie should be up and running
[INFO]
[ERROR]
org.apache.bookkeeper.server.http.TestHttpService.testWhoIsAuditorService(org.apache.bookkeeper.server.http.TestHttpService)
[ERROR] Run 1: TestHttpService.testWhoIsAuditorService:638 expected:<200>
but was:<404>
[ERROR] Run 2: TestHttpService.testWhoIsAuditorService:638 expected:<200>
but was:<404>
[ERROR] Run 3: TestHttpService.testWhoIsAuditorService:638 expected:<200>
but was:<404>
Enrico
Il giorno lun 27 ago 2018 alle ore 20:01 Sijie Guo <gu...@gmail.com> ha
scritto:
> Enrico,
>
> I fixed the sha files.
>
> - Sijie
>
> On Mon, Aug 27, 2018 at 10:57 AM Sijie Guo <gu...@gmail.com> wrote:
>
> > Ah I see. I think the script wasn't fixed in branch-4.7. Let me update
> > those sha files.
> >
> > - Sijie
> >
> > On Mon, Aug 27, 2018 at 6:51 AM Enrico Olivelli <eo...@gmail.com>
> > wrote:
> >
> >> Sijie,
> >> thank you for running the release
> >>
> >> the .sha files contains absolute paths
> >> af1c5f1451fc02fb60bfe8eac91c0f5bd54895ad
> >>
> >>
> /Users/sijie/Workspaces/bookkeeper/target/dist_dev/bookkeeper/bookkeeper-4.7.2-rc0/bookkeeper-4.7.2-src.tar.gz
> >> 30c6a6b75c3715572f2d37ff69d0b08b1dfcf6ac
> >>
> >>
> /Users/sijie/Workspaces/bookkeeper/target/dist_dev/bookkeeper/bookkeeper-4.7.2-rc0/bookkeeper-all-4.7.2-bin.tar.gz
> >> 08d6cd1920e4d3f140911c4e71235bf27729abd5
> >>
> >>
> /Users/sijie/Workspaces/bookkeeper/target/dist_dev/bookkeeper/bookkeeper-4.7.2-rc0/bookkeeper-server-4.7.2-bin.tar.gz
> >>
> >> can you please fix them ?
> >> then I will be able to send a (positive) vote
> >>
> >> Enrico
> >>
> >> Il giorno lun 27 ago 2018 alle ore 10:38 Sijie Guo <gu...@gmail.com>
> >> ha
> >> scritto:
> >>
> >> > Hi everyone,
> >> >
> >> > Please review and vote on the release candidate #0 for the version
> >> 4.7.2,
> >> > as follows:
> >> > [ ] +1, Approve the release
> >> > [ ] -1, Do not approve the release (please provide specific comments)
> >> >
> >> > The complete staging area is available for your review, which
> includes:
> >> > * Release notes [1]
> >> > * The official Apache source and binary distributions to be deployed
> to
> >> > dist.apache.org [2]
> >> > * All artifacts to be deployed to the Maven Central Repository [3]
> >> > * Source code tag "v4.7.2-rc0" [4] with git
> >> > sha ea072c8f8b9d20651b513036c09f264ca5c7ec6e
> >> >
> >> > BookKeeper's KEYS file contains PGP keys we used to sign this release:
> >> > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> >> >
> >> > Please download these packages and review this release candidate:
> >> >
> >> > - Review release notes
> >> > - Download the source package (verify shasum, and asc) and follow the
> >> > instructions to build and run the bookkeeper service.
> >> > - Download the binary package (verify shasum, and asc) and follow the
> >> > instructions to run the bookkeeper service.
> >> > - Review maven repo, release tag, licenses, and any other things you
> >> think
> >> > it is important to a release.
> >> >
> >> > The vote will be open for at least 72 hours. It is adopted by majority
> >> > approval, with at least 3 PMC affirmative votes.
> >> >
> >> > Thanks,
> >> > Sijie Guo
> >> >
> >> > [1] https://github.com/apache/bookkeeper/pull/1628
> >> > [2]
> >> >
> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.7.2-rc0/
> >> > [3]
> >> >
> >> >
> >>
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1031/
> >> > [4] https://github.com/apache/bookkeeper/tree/v4.7.2-rc0
> >> >
> >>
> >
>
Re: [VOTE] Apache BookKeeper Release 4.7.2, release candidate #0
Posted by Sijie Guo <gu...@gmail.com>.
Enrico,
I fixed the sha files.
- Sijie
On Mon, Aug 27, 2018 at 10:57 AM Sijie Guo <gu...@gmail.com> wrote:
> Ah I see. I think the script wasn't fixed in branch-4.7. Let me update
> those sha files.
>
> - Sijie
>
> On Mon, Aug 27, 2018 at 6:51 AM Enrico Olivelli <eo...@gmail.com>
> wrote:
>
>> Sijie,
>> thank you for running the release
>>
>> the .sha files contains absolute paths
>> af1c5f1451fc02fb60bfe8eac91c0f5bd54895ad
>>
>> /Users/sijie/Workspaces/bookkeeper/target/dist_dev/bookkeeper/bookkeeper-4.7.2-rc0/bookkeeper-4.7.2-src.tar.gz
>> 30c6a6b75c3715572f2d37ff69d0b08b1dfcf6ac
>>
>> /Users/sijie/Workspaces/bookkeeper/target/dist_dev/bookkeeper/bookkeeper-4.7.2-rc0/bookkeeper-all-4.7.2-bin.tar.gz
>> 08d6cd1920e4d3f140911c4e71235bf27729abd5
>>
>> /Users/sijie/Workspaces/bookkeeper/target/dist_dev/bookkeeper/bookkeeper-4.7.2-rc0/bookkeeper-server-4.7.2-bin.tar.gz
>>
>> can you please fix them ?
>> then I will be able to send a (positive) vote
>>
>> Enrico
>>
>> Il giorno lun 27 ago 2018 alle ore 10:38 Sijie Guo <gu...@gmail.com>
>> ha
>> scritto:
>>
>> > Hi everyone,
>> >
>> > Please review and vote on the release candidate #0 for the version
>> 4.7.2,
>> > as follows:
>> > [ ] +1, Approve the release
>> > [ ] -1, Do not approve the release (please provide specific comments)
>> >
>> > The complete staging area is available for your review, which includes:
>> > * Release notes [1]
>> > * The official Apache source and binary distributions to be deployed to
>> > dist.apache.org [2]
>> > * All artifacts to be deployed to the Maven Central Repository [3]
>> > * Source code tag "v4.7.2-rc0" [4] with git
>> > sha ea072c8f8b9d20651b513036c09f264ca5c7ec6e
>> >
>> > BookKeeper's KEYS file contains PGP keys we used to sign this release:
>> > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
>> >
>> > Please download these packages and review this release candidate:
>> >
>> > - Review release notes
>> > - Download the source package (verify shasum, and asc) and follow the
>> > instructions to build and run the bookkeeper service.
>> > - Download the binary package (verify shasum, and asc) and follow the
>> > instructions to run the bookkeeper service.
>> > - Review maven repo, release tag, licenses, and any other things you
>> think
>> > it is important to a release.
>> >
>> > The vote will be open for at least 72 hours. It is adopted by majority
>> > approval, with at least 3 PMC affirmative votes.
>> >
>> > Thanks,
>> > Sijie Guo
>> >
>> > [1] https://github.com/apache/bookkeeper/pull/1628
>> > [2]
>> > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.7.2-rc0/
>> > [3]
>> >
>> >
>> https://repository.apache.org/content/repositories/orgapachebookkeeper-1031/
>> > [4] https://github.com/apache/bookkeeper/tree/v4.7.2-rc0
>> >
>>
>
Re: [VOTE] Apache BookKeeper Release 4.7.2, release candidate #0
Posted by Sijie Guo <gu...@gmail.com>.
Ah I see. I think the script wasn't fixed in branch-4.7. Let me update
those sha files.
- Sijie
On Mon, Aug 27, 2018 at 6:51 AM Enrico Olivelli <eo...@gmail.com> wrote:
> Sijie,
> thank you for running the release
>
> the .sha files contains absolute paths
> af1c5f1451fc02fb60bfe8eac91c0f5bd54895ad
>
> /Users/sijie/Workspaces/bookkeeper/target/dist_dev/bookkeeper/bookkeeper-4.7.2-rc0/bookkeeper-4.7.2-src.tar.gz
> 30c6a6b75c3715572f2d37ff69d0b08b1dfcf6ac
>
> /Users/sijie/Workspaces/bookkeeper/target/dist_dev/bookkeeper/bookkeeper-4.7.2-rc0/bookkeeper-all-4.7.2-bin.tar.gz
> 08d6cd1920e4d3f140911c4e71235bf27729abd5
>
> /Users/sijie/Workspaces/bookkeeper/target/dist_dev/bookkeeper/bookkeeper-4.7.2-rc0/bookkeeper-server-4.7.2-bin.tar.gz
>
> can you please fix them ?
> then I will be able to send a (positive) vote
>
> Enrico
>
> Il giorno lun 27 ago 2018 alle ore 10:38 Sijie Guo <gu...@gmail.com> ha
> scritto:
>
> > Hi everyone,
> >
> > Please review and vote on the release candidate #0 for the version 4.7.2,
> > as follows:
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > The complete staging area is available for your review, which includes:
> > * Release notes [1]
> > * The official Apache source and binary distributions to be deployed to
> > dist.apache.org [2]
> > * All artifacts to be deployed to the Maven Central Repository [3]
> > * Source code tag "v4.7.2-rc0" [4] with git
> > sha ea072c8f8b9d20651b513036c09f264ca5c7ec6e
> >
> > BookKeeper's KEYS file contains PGP keys we used to sign this release:
> > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> >
> > Please download these packages and review this release candidate:
> >
> > - Review release notes
> > - Download the source package (verify shasum, and asc) and follow the
> > instructions to build and run the bookkeeper service.
> > - Download the binary package (verify shasum, and asc) and follow the
> > instructions to run the bookkeeper service.
> > - Review maven repo, release tag, licenses, and any other things you
> think
> > it is important to a release.
> >
> > The vote will be open for at least 72 hours. It is adopted by majority
> > approval, with at least 3 PMC affirmative votes.
> >
> > Thanks,
> > Sijie Guo
> >
> > [1] https://github.com/apache/bookkeeper/pull/1628
> > [2]
> > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.7.2-rc0/
> > [3]
> >
> >
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1031/
> > [4] https://github.com/apache/bookkeeper/tree/v4.7.2-rc0
> >
>
Re: [VOTE] Apache BookKeeper Release 4.7.2, release candidate #0
Posted by Enrico Olivelli <eo...@gmail.com>.
Sijie,
thank you for running the release
the .sha files contains absolute paths
af1c5f1451fc02fb60bfe8eac91c0f5bd54895ad
/Users/sijie/Workspaces/bookkeeper/target/dist_dev/bookkeeper/bookkeeper-4.7.2-rc0/bookkeeper-4.7.2-src.tar.gz
30c6a6b75c3715572f2d37ff69d0b08b1dfcf6ac
/Users/sijie/Workspaces/bookkeeper/target/dist_dev/bookkeeper/bookkeeper-4.7.2-rc0/bookkeeper-all-4.7.2-bin.tar.gz
08d6cd1920e4d3f140911c4e71235bf27729abd5
/Users/sijie/Workspaces/bookkeeper/target/dist_dev/bookkeeper/bookkeeper-4.7.2-rc0/bookkeeper-server-4.7.2-bin.tar.gz
can you please fix them ?
then I will be able to send a (positive) vote
Enrico
Il giorno lun 27 ago 2018 alle ore 10:38 Sijie Guo <gu...@gmail.com> ha
scritto:
> Hi everyone,
>
> Please review and vote on the release candidate #0 for the version 4.7.2,
> as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> The complete staging area is available for your review, which includes:
> * Release notes [1]
> * The official Apache source and binary distributions to be deployed to
> dist.apache.org [2]
> * All artifacts to be deployed to the Maven Central Repository [3]
> * Source code tag "v4.7.2-rc0" [4] with git
> sha ea072c8f8b9d20651b513036c09f264ca5c7ec6e
>
> BookKeeper's KEYS file contains PGP keys we used to sign this release:
> https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
>
> Please download these packages and review this release candidate:
>
> - Review release notes
> - Download the source package (verify shasum, and asc) and follow the
> instructions to build and run the bookkeeper service.
> - Download the binary package (verify shasum, and asc) and follow the
> instructions to run the bookkeeper service.
> - Review maven repo, release tag, licenses, and any other things you think
> it is important to a release.
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Sijie Guo
>
> [1] https://github.com/apache/bookkeeper/pull/1628
> [2]
> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.7.2-rc0/
> [3]
>
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1031/
> [4] https://github.com/apache/bookkeeper/tree/v4.7.2-rc0
>