You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by bt...@apache.org on 2025/02/06 20:36:54 UTC
(james-jspf) 04/06: The result from async should be temperror when a SocketException happens
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-jspf.git
commit ae7e71a8c3d8e1608ad54b613b30a8d31e3170f5
Author: Emerson Pinter <e...@pinter.dev>
AuthorDate: Wed Jan 22 13:39:25 2025 -0300
The result from async should be temperror when a SocketException happens
Situations like a port unreachable should be considered a temperror by
async executor, like the sync does.
---
resolver/src/main/java/org/apache/james/jspf/impl/SPF.java | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/resolver/src/main/java/org/apache/james/jspf/impl/SPF.java b/resolver/src/main/java/org/apache/james/jspf/impl/SPF.java
index 3cfc6f1..4c8f955 100644
--- a/resolver/src/main/java/org/apache/james/jspf/impl/SPF.java
+++ b/resolver/src/main/java/org/apache/james/jspf/impl/SPF.java
@@ -20,6 +20,7 @@
package org.apache.james.jspf.impl;
+import java.net.SocketException;
import java.util.Iterator;
import java.util.LinkedList;
@@ -287,6 +288,10 @@ public class SPF implements SPFChecker {
} else if(exception instanceof NoSuchDomainException) {
LOGGER.error(exception.getMessage(), exception);
result = SPFErrorConstants.NONE_CONV;
+ } else if (exception instanceof SocketException) {
+ //SocketException or PortUnreachableException can be caused by a temporary issue
+ LOGGER.error(exception.getMessage(), exception);
+ result = SPFErrorConstants.TEMP_ERROR_CONV;
} else {
// this should never happen at all. But anyway we will set the
// result to neutral. Safety first ..
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org