You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2019/12/05 12:48:59 UTC

Review Request 71880: Renamed stout's path-related absolute functions to is_absolute.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71880/
-----------------------------------------------------------

Review request for mesos and Benno Evers.


Bugs: MESOS-10062
    https://issues.apache.org/jira/browse/MESOS-10062


Repository: mesos


Description
-------

Renamed stout's path-related absolute functions to is_absolute.


Diffs
-----

  src/docker/docker.cpp d13869db7c9ead178cb52eec5d0700931f987161 
  src/hdfs/hdfs.cpp 3947b69c965cfb7289f563202288ea6e4979d942 
  src/resource_provider/storage/uri_disk_profile_adaptor.hpp 027ceaac7cc3db100186aebf2c3ebfd1e06137d9 
  src/slave/container_loggers/logrotate.hpp c6dbd61a5083dbb5c52bfb514ea7979a7a51158b 
  src/slave/containerizer/fetcher.cpp 3a5a74bf4e64eeaed161bb2e7875e185f2271aef 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp e4a19c471b3b5442e5fdc15b31b1799a6638a2d0 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp ab192305b53c829fbf6cbf6367ce1686507f9c3d 
  src/slave/containerizer/mesos/isolators/posix/disk.cpp 4d8047b1f5966428911d095c734a0155b1f5148a 
  src/slave/containerizer/mesos/isolators/volume/host_path.cpp a20f7ac527a0ae68a03ec7095c09def5b34f5109 
  src/slave/containerizer/mesos/isolators/volume/image.cpp b1112529ac1abe01368fda501a675e7b3e6388ef 
  src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp 45bd143bbc829c105dc1f1c8c88f0168aeaf53a0 
  src/slave/containerizer/mesos/isolators/volume/secret.cpp 91d701376069a65046e487a5070325e3bc61deb8 
  src/slave/containerizer/mesos/launch.cpp 1f8dc1ae2e3d750d56973f9efc1ccbd4b1e50eba 
  src/slave/paths.cpp 5afcc7e104aa4232554d54e2f290aede4ebba3c1 
  src/tests/storage_local_resource_provider_tests.cpp d4a73c34afb034ac35a3e305e603c61a03b99b5d 
  src/uri/fetchers/docker.cpp 1aa3def8362269e94c7f0bb05f9aa10049bf4af4 


Diff: https://reviews.apache.org/r/71880/diff/1/


Testing
-------

`make check`


Thanks,

Benjamin Bannier

Re: Review Request 71880: Renamed stout's path-related absolute functions to is_absolute.

Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71880/#review218974
-----------------------------------------------------------


Ship it!




Ship It!

- Benno Evers


On Dec. 5, 2019, 12:48 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71880/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2019, 12:48 p.m.)
> 
> 
> Review request for mesos and Benno Evers.
> 
> 
> Bugs: MESOS-10062
>     https://issues.apache.org/jira/browse/MESOS-10062
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renamed stout's path-related absolute functions to is_absolute.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp d13869db7c9ead178cb52eec5d0700931f987161 
>   src/hdfs/hdfs.cpp 3947b69c965cfb7289f563202288ea6e4979d942 
>   src/resource_provider/storage/uri_disk_profile_adaptor.hpp 027ceaac7cc3db100186aebf2c3ebfd1e06137d9 
>   src/slave/container_loggers/logrotate.hpp c6dbd61a5083dbb5c52bfb514ea7979a7a51158b 
>   src/slave/containerizer/fetcher.cpp 3a5a74bf4e64eeaed161bb2e7875e185f2271aef 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp e4a19c471b3b5442e5fdc15b31b1799a6638a2d0 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp ab192305b53c829fbf6cbf6367ce1686507f9c3d 
>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 4d8047b1f5966428911d095c734a0155b1f5148a 
>   src/slave/containerizer/mesos/isolators/volume/host_path.cpp a20f7ac527a0ae68a03ec7095c09def5b34f5109 
>   src/slave/containerizer/mesos/isolators/volume/image.cpp b1112529ac1abe01368fda501a675e7b3e6388ef 
>   src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp 45bd143bbc829c105dc1f1c8c88f0168aeaf53a0 
>   src/slave/containerizer/mesos/isolators/volume/secret.cpp 91d701376069a65046e487a5070325e3bc61deb8 
>   src/slave/containerizer/mesos/launch.cpp 1f8dc1ae2e3d750d56973f9efc1ccbd4b1e50eba 
>   src/slave/paths.cpp 5afcc7e104aa4232554d54e2f290aede4ebba3c1 
>   src/tests/storage_local_resource_provider_tests.cpp d4a73c34afb034ac35a3e305e603c61a03b99b5d 
>   src/uri/fetchers/docker.cpp 1aa3def8362269e94c7f0bb05f9aa10049bf4af4 
> 
> 
> Diff: https://reviews.apache.org/r/71880/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>