You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/02/25 18:07:34 UTC

[GitHub] [flink] qinghui-xu opened a new pull request #15024: [FLINK-17401] [mesos] Configure mesos labels for taskmanagers

qinghui-xu opened a new pull request #15024:
URL: https://github.com/apache/flink/pull/15024


   Provide an option to configure mesos labels for taskmanagers running on mesos.
   Mesos task labels can be used for different purposes such as monitoring, acl, etc.
   
   ## What is the purpose of the change
   
   To provide an option for configuring mesos labels for taskmanagers running on mesos. Mesos lables are often useful regarding to mesos resource management (monitoring, acl, etc).
   This PR is based on https://github.com/apache/flink/pull/11923, addressing the comments there.
   
   ## Brief change log
   
    - Add an new option "mesos.resourcemanager.tasks.labels"
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
    - Add an unit test for parsing the new option
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes)
     - If yes, how is the feature documented? (docs)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rmetzger merged pull request #15024: [FLINK-17401] [mesos] Configure mesos labels for taskmanagers

Posted by GitBox <gi...@apache.org>.
rmetzger merged pull request #15024:
URL: https://github.com/apache/flink/pull/15024


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rmetzger commented on pull request #15024: [FLINK-17401] [mesos] Configure mesos labels for taskmanagers

Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #15024:
URL: https://github.com/apache/flink/pull/15024#issuecomment-790839416


   Yes, the CI failure is unrelated
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #15024: [FLINK-17401] [mesos] Configure mesos labels for taskmanagers

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15024:
URL: https://github.com/apache/flink/pull/15024#issuecomment-786114025


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e27de112db1502495f8130a5b9cb2ad423952b6c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e27de112db1502495f8130a5b9cb2ad423952b6c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e27de112db1502495f8130a5b9cb2ad423952b6c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] qinghui-xu commented on pull request #15024: [FLINK-17401] [mesos] Configure mesos labels for taskmanagers

Posted by GitBox <gi...@apache.org>.
qinghui-xu commented on pull request #15024:
URL: https://github.com/apache/flink/pull/15024#issuecomment-787976811


   @rmetzger What do you think of this PR?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #15024: [FLINK-17401] [mesos] Configure mesos labels for taskmanagers

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15024:
URL: https://github.com/apache/flink/pull/15024#issuecomment-786098275


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit e27de112db1502495f8130a5b9cb2ad423952b6c (Thu Feb 25 18:09:47 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] qinghui-xu commented on pull request #15024: [FLINK-17401] [mesos] Configure mesos labels for taskmanagers

Posted by GitBox <gi...@apache.org>.
qinghui-xu commented on pull request #15024:
URL: https://github.com/apache/flink/pull/15024#issuecomment-786756179


   It looks like the CI failure is unrelated.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #15024: [FLINK-17401] [mesos] Configure mesos labels for taskmanagers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15024:
URL: https://github.com/apache/flink/pull/15024#issuecomment-786114025


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e27de112db1502495f8130a5b9cb2ad423952b6c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13796",
       "triggerID" : "e27de112db1502495f8130a5b9cb2ad423952b6c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e27de112db1502495f8130a5b9cb2ad423952b6c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13796) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #15024: [FLINK-17401] [mesos] Configure mesos labels for taskmanagers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15024:
URL: https://github.com/apache/flink/pull/15024#issuecomment-786114025


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e27de112db1502495f8130a5b9cb2ad423952b6c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13796",
       "triggerID" : "e27de112db1502495f8130a5b9cb2ad423952b6c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e27de112db1502495f8130a5b9cb2ad423952b6c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13796) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org