You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2013/08/30 09:48:14 UTC

[Bug 55508] New: TldLocationsCache not recognising custom TLDs in WEB-INF/lib

https://issues.apache.org/bugzilla/show_bug.cgi?id=55508

            Bug ID: 55508
           Summary: TldLocationsCache not recognising custom TLDs in
                    WEB-INF/lib
           Product: Tomcat 7
           Version: 7.0.42
          Hardware: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Jasper
          Assignee: dev@tomcat.apache.org
          Reporter: alan.mcl@gmail.com

I have moved my web app from Tomcat 6.0.35 to Tomcat 7.0.42 and the custom TLDs
are not being located.

50783 is similar, but my issue is with custom TLDs located in WEB-INF/lib.

TldLocationsCache does not locate them or add them to it's internal map of TLD
locations.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 55508] TldLocationsCache not recognising custom TLDs in WEB-INF/lib

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55508

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |INVALID

--- Comment #6 from Mark Thomas <ma...@apache.org> ---
I've restored the Tomcat 7 behavior in Tomcat 8.

My reading of the spec is TLDs should not be scanned if they are in
WEB-INF/[classes|lib] but I appreciate it could be read either way. If this
turns out to be an issue (unlikely given the amount of time 7.0.x has enforced
this) then we can always make it optional.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 55508] TldLocationsCache not recognising custom TLDs in WEB-INF/lib

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55508

--- Comment #3 from Alan McLachlan <al...@gmail.com> ---
Thanks for the speedy response Mark, and for the clarification.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 55508] TldLocationsCache not recognising custom TLDs in WEB-INF/lib

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55508

Violeta Georgieva <vi...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Jasper                      |Jasper
            Version|7.0.42                      |trunk
            Product|Tomcat 7                    |Tomcat 8
   Target Milestone|---                         |----

--- Comment #5 from Violeta Georgieva <vi...@apache.org> ---
Changing the product to Tomcat 8 as this discussion may affect Tomcat 8.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 55508] TldLocationsCache not recognising custom TLDs in WEB-INF/lib

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55508

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #2 from Mark Thomas <ma...@apache.org> ---
JSP Specification  (2.1 - Tomcat 6, 2.2 - Tomcat 7) section JSP.7.3.1 states:
<quote>
When deployed directly into a web application, the tag library descriptor
files must always be in the WEB-INF directory, or some subdirectory of it. TLD
files should not be placed in /WEB-INF/classes or /WEB-INF/lib ...
</quote>

Tomcat 7 is simply stricter about enforcing this requirement as a result of
some refactoring of TLD processing that took place between Tomcat 6 and Tomcat
7.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [Bug 55508] TldLocationsCache not recognising custom TLDs in WEB-INF/lib

Posted by Jeremy Boynes <jb...@apache.org>.
On Sep 17, 2013, at 11:10 PM, Violeta Georgieva <mi...@gmail.com> wrote:

> Hi Jeremy,
> 
> 2013/9/13 <bu...@apache.org>
>> 
>> https://issues.apache.org/bugzilla/show_bug.cgi?id=55508
>> 
>> Jeremy Boynes <jb...@apache.org> changed:
>> 
>>           What    |Removed                     |Added
>> 
> ----------------------------------------------------------------------------
>>             Status|RESOLVED                    |REOPENED
>>         Resolution|INVALID                     |---
>> 
>> --- Comment #4 from Jeremy Boynes <jb...@apache.org> ---
>> Reopening this for further discussion, and to see whether I need to change
>> TldScanner in trunk as I think I introduced a regression here.
>> 
>> I interpreted the spec as saying that all TLDs under /WEB-INF *must* be
>> included except for any under /WEB-INF/tags (except for any implicit.tld
> found
>> there). As a result, although applications *should* not place them in
>> /WEB-INF/lib or /WEB-INF/classes, that was a recommendation and if they
> were
>> there the container would need to include them.
>> 
>> The change to TldScanner in TC8 unintentionally resurrected the behaviour
> from
>> TC6 that was removed in TC7.
> 
> Do we have this change in TC7 or it is only in TC8?

It is only in TC8.
Cheers
Jeremy


Re: [Bug 55508] TldLocationsCache not recognising custom TLDs in WEB-INF/lib

Posted by Violeta Georgieva <mi...@gmail.com>.
Hi Jeremy,

2013/9/13 <bu...@apache.org>
>
> https://issues.apache.org/bugzilla/show_bug.cgi?id=55508
>
> Jeremy Boynes <jb...@apache.org> changed:
>
>            What    |Removed                     |Added
>
----------------------------------------------------------------------------
>              Status|RESOLVED                    |REOPENED
>          Resolution|INVALID                     |---
>
> --- Comment #4 from Jeremy Boynes <jb...@apache.org> ---
> Reopening this for further discussion, and to see whether I need to change
> TldScanner in trunk as I think I introduced a regression here.
>
> I interpreted the spec as saying that all TLDs under /WEB-INF *must* be
> included except for any under /WEB-INF/tags (except for any implicit.tld
found
> there). As a result, although applications *should* not place them in
> /WEB-INF/lib or /WEB-INF/classes, that was a recommendation and if they
were
> there the container would need to include them.
>
> The change to TldScanner in TC8 unintentionally resurrected the behaviour
from
> TC6 that was removed in TC7.

Do we have this change in TC7 or it is only in TC8?

Thanks
Violeta

[Bug 55508] TldLocationsCache not recognising custom TLDs in WEB-INF/lib

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55508

Jeremy Boynes <jb...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|INVALID                     |---

--- Comment #4 from Jeremy Boynes <jb...@apache.org> ---
Reopening this for further discussion, and to see whether I need to change
TldScanner in trunk as I think I introduced a regression here.

I interpreted the spec as saying that all TLDs under /WEB-INF *must* be
included except for any under /WEB-INF/tags (except for any implicit.tld found
there). As a result, although applications *should* not place them in
/WEB-INF/lib or /WEB-INF/classes, that was a recommendation and if they were
there the container would need to include them.

The change to TldScanner in TC8 unintentionally resurrected the behaviour from
TC6 that was removed in TC7.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 55508] TldLocationsCache not recognising custom TLDs in WEB-INF/lib

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55508

Alan McLachlan <al...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All

--- Comment #1 from Alan McLachlan <al...@gmail.com> ---
I posted more context on StackOverflow:
http://stackoverflow.com/questions/18383997/jsp-jsf-documents-not-rendering-correctly-after-upgrade-to-tomcat-7

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org