You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/08/28 20:12:36 UTC
[GitHub] [incubator-pinot] fx19880617 opened a new pull request #5940: Fixing the issue that transform UDFs are parsed as function name 'OTHER', not the real function names
fx19880617 opened a new pull request #5940:
URL: https://github.com/apache/incubator-pinot/pull/5940
## Description
This PR fixes the query like:
```
select Hour(event_time), group_city, sum(rsvp_count) from meetupRsvp group by Hour(event_time), group_city order by sum(rsvp_count) desc limit 10
```
which raises exceptions:
```
QueryExecutionError:
org.apache.pinot.core.query.exception.BadQueryRequestException: Unsupported function: other with 1 parameters
at org.apache.pinot.core.operator.transform.function.TransformFunctionFactory.get(TransformFunctionFactory.java:181)
...
```
The reason is that `HOUR` is a pinot UDF which CalciteSQL parser doesn't recognize and marked the SQL_KIND as `OTHER` with the real function name inside the function info.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on pull request #5940: Fixing the issue that transform UDFs are parsed as function name 'OTHER', not the real function names
Posted by GitBox <gi...@apache.org>.
fx19880617 commented on pull request #5940:
URL: https://github.com/apache/incubator-pinot/pull/5940#issuecomment-683145518
> LGTM. Wonder how Calcite differentiate `OTHER_FUNCTION` and `OTHER` :-P
OTHER_FUNCTION is the functions Calcite recognize but not special functions like `COUNT`,`AND`, `OR`
OTHER is for anything else.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 merged pull request #5940: Fixing the issue that transform UDFs are parsed as function name 'OTHER', not the real function names
Posted by GitBox <gi...@apache.org>.
fx19880617 merged pull request #5940:
URL: https://github.com/apache/incubator-pinot/pull/5940
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org