You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/01/09 18:53:58 UTC

[jira] [Commented] (TINKERPOP-1116) Some anonymous traversal steps can be hard typed.

    [ https://issues.apache.org/jira/browse/TINKERPOP-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15812526#comment-15812526 ] 

ASF GitHub Bot commented on TINKERPOP-1116:
-------------------------------------------

GitHub user okram opened a pull request:

    https://github.com/apache/tinkerpop/pull/528

    TINKERPOP-1116: Some anonymous traversal steps can be hard typed.

    https://issues.apache.org/jira/browse/TINKERPOP-1116
    
    Tweaked the typing of various `__` anonymous traversal steps as various do not need generic typing. This is in master/ as its breaking because user that do `<Vertex>out()` will simply need to do `out()` (and thus, remove the explicit typing).
    
    VOTE +1.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1116

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/528.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #528
    
----
commit 32fe2ea6c6205d867f67ed8527c51f55a08ff644
Author: Marko A. Rodriguez <ok...@gmail.com>
Date:   2017-01-09T18:50:25Z

    Various __ steps can be hard typed. For instance <A,Vertex>out() is actually <Vertex,Vertex>out(). Went through and tweaked typing accordingly. This is going to master as it might cause some users to have to remove <> explicit typing.

----


> Some anonymous traversal steps can be hard typed.
> -------------------------------------------------
>
>                 Key: TINKERPOP-1116
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1116
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.1.1-incubating
>            Reporter: Marko A. Rodriguez
>            Assignee: Marko A. Rodriguez
>              Labels: breaking
>
> We have lots of this:
> {code}
> public static <A> GraphTraversal<A, Edge> bothE(final String... edgeLabels) {
>         return __.<A>start().bothE(edgeLabels);
>     }
> {code}
> This should really be:
> {code}
> public static GraphTraversal<Vertex, Edge> bothE(final String... edgeLabels) {
>         return __.<Vertex>start().bothE(edgeLabels);
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)