You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "tobim (via GitHub)" <gi...@apache.org> on 2023/03/10 08:05:03 UTC

[GitHub] [thrift] tobim opened a new pull request, #2768: Add missing include for the security tests

tobim opened a new pull request, #2768:
URL: https://github.com/apache/thrift/pull/2768

   Fixes a build error on msvc that was introduced with #2760.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G merged pull request #2768: Add missing include for the security tests

Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G merged PR #2768:
URL: https://github.com/apache/thrift/pull/2768


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] tobim commented on pull request #2768: Add missing include for the security tests

Posted by "tobim (via GitHub)" <gi...@apache.org>.
tobim commented on PR #2768:
URL: https://github.com/apache/thrift/pull/2768#issuecomment-1463499905

   It looks like that didn't do the trick.
   ```
   C:\projects\thrift\lib\cpp\test\SecurityFromBufferTest.cpp(202): error C2065: 'OPENSSL_VERSION_MAJOR': undeclared identifier [C:\projects\build\MSVC2017\x64\lib\cpp\test\SecurityFromBufferTest.vcxproj]
     Building Custom Rule C:/projects/thrift/lib/cpp/test/CMakeLists.txt
     SecurityTest.cpp
   C:\projects\thrift\lib\cpp\test\SecurityTest.cpp(224): error C2065: 'OPENSSL_VERSION_MAJOR': undeclared identifier [C:\projects\build\MSVC2017\x64\lib\cpp\test\SecurityTest.vcxproj]
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org