[GitHub] [fineract] vidakovic commented on pull request #2024: FINERACT-1492: Hikari configuration based on application properties

[GitBox <gi...@apache.org>]

vidakovic commented on pull request #2024:
URL: https://github.com/apache/fineract/pull/2024#issuecomment-1030641670


   @ptuomola ... finally I found a quiet moment to wrap this up. While I was at it I introduced a mapping class for Fineract related properties (everything prefixed `fineract.*` in `application.properties`). The criteria I use to activate the backwards compatible configuration is a check on environment variable `fineract_tenants_driver` (if it's empty then the new configuration is assumed, if not empty then `org.apache.fineract.infrastructure.core.config.CompatibilityConfig` is activated. I've added some additional hints to the README and to docker-compose.yml. The Docker Compose file is configured to use the new stuff (with more options to tweak the Hikari pool configuration).
   
   I've tried both configs, work as advertised. Would be great if you could approve to get this stuff out of the way for the next release. Thanks again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org