You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Astro-Han (via GitHub)" <gi...@apache.org> on 2026/09/14 12:55:18 UTC

[PR] fix(ui): unify process activity and restore rotating working phrases [maka]

Astro-Han opened a new pull request, #5301:
URL: https://github.com/apache/maka/pull/5301

   ## Summary
   
   An active Bash tool could appear between a process header saying “Working…” and a footer saying “Waiting for model output…”. The current process summary now owns the working cue, with a footer fallback only before that segment has a process. Earlier segments separated by user instructions do not repeat the cue.
   
   Restore the rotating working phrases removed in #4270, including “正在琢磨…” and “正在鼓捣…”. They rotate every 20 seconds using the existing elapsed clock, with a stable accessible status name and static presentation under reduced motion. Closing the process transfers the spinner from the hidden tool to its summary. Provider retries, input requests, failures, and cancellation keep their explicit surfaces; retries and input requests suppress the playful cue.
   
   This extends the process disclosure introduced in #5259. It does not change timeline ordering, final-reply selection, paging, or scroll authority, and is independent of the transcript viewport mounting fix.
   
   ## Verification
   
   - UI suite: 459 tests passed. Additional checks cover phrase rotation, reduced-motion presentation, input/retry priority, and one activity owner across inserted instructions. Existing tests for settlement, manual expansion, final-answer identity, and failure disclosure remain in place.
   - Desktop Storybook typecheck and static build passed.
   - Focused static Storybook smoke: 8 scenes plus the running scene in dark mode passed. The running scene clicks closed/open and checks spinner ownership; completed scenes exercise disclosure, focus, and final-answer selection.
   - Changed-file lint and `git diff --check` passed.
   - Ablation: removing the footer ownership condition reproduced duplicate indicators and failed 3 regression tests; restoring it passed all 5 focused status tests. The rotation shares the elapsed timer rather than restoring separate rotation/fade timers.
   
   No performance claim is made; real Host paging and the separate viewport change are outside this status-presentation change.
   
   ## AI use
   
   - [ ] No generative tool made a substantive contribution
   - [x] Generative tooling made a substantive contribution
   
   Tool(s) and scope: Codex implemented the change and ran local tests and Storybook verification.
   
   ## Checklist
   
   - [x] Tests cover the change and fail without it
   - [x] Lint, format, typecheck and the affected suites pass locally
   
   Does this PR entail a change in behavior?
   
   - [x] Yes — described under Summary above
   - [ ] No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] fix(ui): unify live process activity and settled disclosures [maka]

Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #5301:
URL: https://github.com/apache/maka/pull/5301


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org