You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Dan Sully (JIRA)" <ji...@apache.org> on 2008/09/05 00:31:44 UTC
[jira] Created: (THRIFT-133) 'namespace ruby' should error out, or
be an alias to 'namespace rb'
'namespace ruby' should error out, or be an alias to 'namespace rb'
-------------------------------------------------------------------
Key: THRIFT-133
URL: https://issues.apache.org/jira/browse/THRIFT-133
Project: Thrift
Issue Type: Bug
Components: Compiler (Ruby)
Reporter: Dan Sully
Priority: Minor
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-133) 'namespace ruby' should error out,
or be an alias to 'namespace rb'
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863456#action_12863456 ]
David Reiss commented on THRIFT-133:
------------------------------------
{noformat}
t_generator_registry::gen_map_t my_copy = t_generator_registry::get_generator_map();
{noformat}
The keys are the generator names.
> 'namespace ruby' should error out, or be an alias to 'namespace rb'
> -------------------------------------------------------------------
>
> Key: THRIFT-133
> URL: https://issues.apache.org/jira/browse/THRIFT-133
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Reporter: Dan Sully
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.4
>
> Attachments: thrift-133.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-133) 'namespace ruby' should error out,
or be an alias to 'namespace rb'
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861107#action_12861107 ]
Bryan Duxbury commented on THRIFT-133:
--------------------------------------
Could you help me figure out how to get access to the generator names in t_program? I glanced at this briefly before recalling the utter pain that was making the compiler treat enum/constant values correctly a while back. Would really love a compiler written in Java in situations like this.
> 'namespace ruby' should error out, or be an alias to 'namespace rb'
> -------------------------------------------------------------------
>
> Key: THRIFT-133
> URL: https://issues.apache.org/jira/browse/THRIFT-133
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Reporter: Dan Sully
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.3
>
> Attachments: thrift-133.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-133) 'namespace ruby' should error out,
or be an alias to 'namespace rb'
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628507#action_12628507 ]
David Reiss commented on THRIFT-133:
------------------------------------
http://wiki.apache.org/thrift/NamingVote
Looks like I won :-) . If you post a patch that implements this behavior, I'll commit it since It'll be a while before I can rename everything.
> 'namespace ruby' should error out, or be an alias to 'namespace rb'
> -------------------------------------------------------------------
>
> Key: THRIFT-133
> URL: https://issues.apache.org/jira/browse/THRIFT-133
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Reporter: Dan Sully
> Priority: Minor
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-133) 'namespace ruby' should error out, or
be an alias to 'namespace rb'
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-133:
---------------------------------
Fix Version/s: 0.4
(was: 0.3)
> 'namespace ruby' should error out, or be an alias to 'namespace rb'
> -------------------------------------------------------------------
>
> Key: THRIFT-133
> URL: https://issues.apache.org/jira/browse/THRIFT-133
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Reporter: Dan Sully
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.4
>
> Attachments: thrift-133.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-133) 'namespace ruby' should error out,
or be an alias to 'namespace rb'
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895363#action_12895363 ]
Bryan Duxbury commented on THRIFT-133:
--------------------------------------
I just added it to Makefile.am. Try it out, Jordan?
> 'namespace ruby' should error out, or be an alias to 'namespace rb'
> -------------------------------------------------------------------
>
> Key: THRIFT-133
> URL: https://issues.apache.org/jira/browse/THRIFT-133
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Reporter: Dan Sully
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.4
>
> Attachments: thrift-133-v2.patch, thrift-133.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (THRIFT-133) 'namespace ruby' should error out, or
be an alias to 'namespace rb'
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury reassigned THRIFT-133:
------------------------------------
Assignee: Bryan Duxbury
> 'namespace ruby' should error out, or be an alias to 'namespace rb'
> -------------------------------------------------------------------
>
> Key: THRIFT-133
> URL: https://issues.apache.org/jira/browse/THRIFT-133
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Reporter: Dan Sully
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.3
>
> Attachments: thrift-133.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-133) 'namespace ruby' should error out,
or be an alias to 'namespace rb'
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895140#action_12895140 ]
Bryan Duxbury commented on THRIFT-133:
--------------------------------------
Jordan - not sure what's going on in your build, but t_generator_registry.h is clearly in HEAD.
> 'namespace ruby' should error out, or be an alias to 'namespace rb'
> -------------------------------------------------------------------
>
> Key: THRIFT-133
> URL: https://issues.apache.org/jira/browse/THRIFT-133
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Reporter: Dan Sully
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.4
>
> Attachments: thrift-133-v2.patch, thrift-133.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-133) 'namespace ruby' should error out, or
be an alias to 'namespace rb'
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-133:
---------------------------------
Attachment: thrift-133.patch
This patch makes the set of possible languages as first param to "namespace" constrained to the short names of the code generators. This means that if someone passes "ruby", you'll get a compiler error.
> 'namespace ruby' should error out, or be an alias to 'namespace rb'
> -------------------------------------------------------------------
>
> Key: THRIFT-133
> URL: https://issues.apache.org/jira/browse/THRIFT-133
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Reporter: Dan Sully
> Priority: Minor
> Fix For: 0.3
>
> Attachments: thrift-133.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-133) 'namespace ruby' should error out,
or be an alias to 'namespace rb'
Posted by "Jordan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895138#action_12895138 ]
Jordan commented on THRIFT-133:
-------------------------------
I just downloaded the latest thrift, and I can't even compile thrift with make because it can't find t_generator_registry.h
ERROR:
In file included from thrifty.yy:35:
./src/parse/t_program.h:41:43: error: generate/t_generator_registry.h: No such file or directory
> 'namespace ruby' should error out, or be an alias to 'namespace rb'
> -------------------------------------------------------------------
>
> Key: THRIFT-133
> URL: https://issues.apache.org/jira/browse/THRIFT-133
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Reporter: Dan Sully
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.4
>
> Attachments: thrift-133-v2.patch, thrift-133.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-133) 'namespace ruby' should error out, or
be an alias to 'namespace rb'
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-133:
---------------------------------
Attachment: thrift-133-v2.patch
OK, this performs David's suggested cleanup. Look ok? I'll commit tomorrow if there are no objections.
> 'namespace ruby' should error out, or be an alias to 'namespace rb'
> -------------------------------------------------------------------
>
> Key: THRIFT-133
> URL: https://issues.apache.org/jira/browse/THRIFT-133
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Reporter: Dan Sully
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.4
>
> Attachments: thrift-133-v2.patch, thrift-133.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-133) 'namespace ruby' should error out, or
be an alias to 'namespace rb'
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-133:
---------------------------------
Fix Version/s: 0.2
> 'namespace ruby' should error out, or be an alias to 'namespace rb'
> -------------------------------------------------------------------
>
> Key: THRIFT-133
> URL: https://issues.apache.org/jira/browse/THRIFT-133
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Reporter: Dan Sully
> Priority: Minor
> Fix For: 0.2
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-133) 'namespace ruby' should error out,
or be an alias to 'namespace rb'
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893762#action_12893762 ]
Bryan Duxbury commented on THRIFT-133:
--------------------------------------
Oops. Fixed in r980538.
> 'namespace ruby' should error out, or be an alias to 'namespace rb'
> -------------------------------------------------------------------
>
> Key: THRIFT-133
> URL: https://issues.apache.org/jira/browse/THRIFT-133
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Reporter: Dan Sully
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.4
>
> Attachments: thrift-133-v2.patch, thrift-133.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-133) 'namespace ruby' should error out,
or be an alias to 'namespace rb'
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861078#action_12861078 ]
David Reiss commented on THRIFT-133:
------------------------------------
1/ Drop the printf.
2/ We already have a map of all of the generator names.
3/ Smalltalk support two different types of namespace declarations. I think it is something like "smalltalk.prefix" and "smalltalk.package".
> 'namespace ruby' should error out, or be an alias to 'namespace rb'
> -------------------------------------------------------------------
>
> Key: THRIFT-133
> URL: https://issues.apache.org/jira/browse/THRIFT-133
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Reporter: Dan Sully
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.3
>
> Attachments: thrift-133.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-133) 'namespace ruby' should error out,
or be an alias to 'namespace rb'
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893734#action_12893734 ]
David Reiss commented on THRIFT-133:
------------------------------------
Breaks smalltalk.prefix and smalltalk.package.
> 'namespace ruby' should error out, or be an alias to 'namespace rb'
> -------------------------------------------------------------------
>
> Key: THRIFT-133
> URL: https://issues.apache.org/jira/browse/THRIFT-133
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Reporter: Dan Sully
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.4
>
> Attachments: thrift-133-v2.patch, thrift-133.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-133) 'namespace ruby' should error out, or
be an alias to 'namespace rb'
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-133.
--------------------------------
Resolution: Fixed
Committed.
> 'namespace ruby' should error out, or be an alias to 'namespace rb'
> -------------------------------------------------------------------
>
> Key: THRIFT-133
> URL: https://issues.apache.org/jira/browse/THRIFT-133
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Reporter: Dan Sully
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.4
>
> Attachments: thrift-133-v2.patch, thrift-133.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-133) 'namespace ruby' should error out,
or be an alias to 'namespace rb'
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895360#action_12895360 ]
David Reiss commented on THRIFT-133:
------------------------------------
Oops. It needs to be added to Makefile.am to be included in "make dist" tarballs.
> 'namespace ruby' should error out, or be an alias to 'namespace rb'
> -------------------------------------------------------------------
>
> Key: THRIFT-133
> URL: https://issues.apache.org/jira/browse/THRIFT-133
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Reporter: Dan Sully
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.4
>
> Attachments: thrift-133-v2.patch, thrift-133.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.