[GitHub] [pulsar-client-go] dinghram opened a new pull request, #992: [Issue 468] Add Support for NonDurable subscriptions

["dinghram (via GitHub)" <gi...@apache.org>]

dinghram opened a new pull request, #992:
URL: https://github.com/apache/pulsar-client-go/pull/992

   <!--
   ### Contribution Checklist
     
     - Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
       Skip *Issue XYZ* if there is no associated github issue for this pull request.
       Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   Fixes #468 
   
   ### Motivation
   This change allows the Go Pulsar Client to create consumers with non-durable subscriptions. We use Pulsar in an enterprise level application that processes large amounts of data throughput. We are adding a component that creates a consumer on that throughput, and it is very important that the throughput is not affected by this component. If the component creates a durable subscription, then goes down for whatever reason, the backlog caused by a durable subscription could bring our enterprise application down. Allowing a consumer to be non-durable alleviates this problem. 
   
   It has been suggested that we could use a Pulsar Reader instead of a Consumer, but then we cannot easily spread the load of messages across multiple pods, as each pod would not know which messages the other pod had processed. It has also been suggested that we could use "aggressive subscription/topic removal policies" to achieve this, but our enterprise level application has the policies already defined and changing them could have other, unintended side-effects.
   
   This change brings a feature to the Go Pulsar Client which is already supported by the Java client.
   
   ### Modifications
   
   This change exposes the SubscriptionMode outside the pulsar package, and adds SubscriptionMode as an option in ConsumerOptions. The default remains "Durable".
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] BewareMyPower merged pull request #992: [Issue 468] Add Support for NonDurable subscriptions

["BewareMyPower (via GitHub)" <gi...@apache.org>]

BewareMyPower merged PR #992:
URL: https://github.com/apache/pulsar-client-go/pull/992


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org