[jira] [Commented] (TS-4187) connections_currently_open stat not accurate with global server session pools

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15247911#comment-15247911 ] 

ASF GitHub Bot commented on TS-4187:
------------------------------------

GitHub user shinrich opened a pull request:

    https://github.com/apache/trafficserver/pull/583

    TS-4187: Keep the currently_open connections in sync with open sockets

    This is an improvement on the original fix for TS-4187.  The original fix would in some case over count the open sockets.  It seems sometimes, the connection would have already been closed or rather be scheduled to be closed multiple times.  We would increase the currently_open count for every scheduled close, but only decrease it for the actual free.
    
    I've changed things around to decrease in the do_io_close if it is called with a valid file descriptor.
    
    This seems to better keep the currently_open count in sync with the established socket count on the systems.  However, both grow until we run out of memory on our production boxes.  But that is being tracked by TS-4330

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shinrich/trafficserver ts-4348

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/583.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #583
    
----
commit 93069041e3d42255e016d818f5c849587a52b025
Author: Susan Hinrichs <sh...@draggingnagging.corp.ne1.yahoo.com>
Date:   2016-04-15T16:34:25Z

    TS-4187: Keep the currently_open connections in sync with the number of sockets open.

----


> connections_currently_open stat not accurate with global server session pools
> -----------------------------------------------------------------------------
>
>                 Key: TS-4187
>                 URL: https://issues.apache.org/jira/browse/TS-4187
>             Project: Traffic Server
>          Issue Type: Bug
>            Reporter: Susan Hinrichs
>            Assignee: Susan Hinrichs
>             Fix For: 6.2.0
>
>
> When global server session pools are used, sockets may be moved to new VCs associated with different threads.  The connections_currently_open stat was not being correctly incremented in that case meaning the connections_currently_open stat would go negative.
> This means that the connection throttling logic would likely not trigger. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)