[GitHub] [superset] codemaster08240328 commented on a change in pull request #19328: feat(sql lab): enable ACE editor search in SQL editors

[GitBox <gi...@apache.org>]

codemaster08240328 commented on a change in pull request #19328:
URL: https://github.com/apache/superset/pull/19328#discussion_r834500339



##########
File path: superset-frontend/src/SqlLab/components/AceEditorWrapper/index.tsx
##########
@@ -127,8 +127,6 @@ class AceEditorWrapper extends React.PureComponent<Props, State> {
   }
 
   onEditorLoad(editor: any) {
-    editor.commands.removeCommand('find');

Review comment:
       Did you get a chance to look at why they removed `find` command previously?
   
   We may face side effect by adding it again?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org