You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/08 22:47:10 UTC

[GitHub] [airflow] ephraimbuddy opened a new pull request #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long

ephraimbuddy opened a new pull request #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long
URL: https://github.com/apache/airflow/pull/7658
 
 
   Pool name can now give error in cli if the name is too large. The name has been increased to 256 characters 
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [ ] Description above provides context of the change
   - [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long

Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on a change in pull request #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long
URL: https://github.com/apache/airflow/pull/7658#discussion_r390145195
 
 

 ##########
 File path: airflow/migrations/versions/b25a55525161_increase_length_of_pool_name.py
 ##########
 @@ -0,0 +1,48 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""Increase length of pool name
+
+Revision ID: b25a55525161
+Revises: a4c2fd67d16b
+Create Date: 2020-03-09 08:48:14.534700
+
+"""
+
+import sqlalchemy as sa
+from alembic import op
+
+# revision identifiers, used by Alembic.
+revision = 'b25a55525161'
+down_revision = 'a4c2fd67d16b'
+branch_labels = None
+depends_on = None
+
+
+def upgrade():
+    """Increase column length of pool name from 50 to 250 characters"""
 
 Review comment:
   Oh..thanks for this. Will do it now

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] boring-cyborg[bot] commented on issue #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long
URL: https://github.com/apache/airflow/pull/7658#issuecomment-597074279
 
 
   Awesome work, congrats on your first merged pull request!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long
URL: https://github.com/apache/airflow/pull/7658#issuecomment-596370707
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=h1) Report
   > Merging [#7658](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/c93f82b10f6eea6e0f1e739085974a5f7a21961f?src=pr&el=desc) will **decrease** coverage by `0.34%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7658/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master   #7658      +/-   ##
   =========================================
   - Coverage   86.95%   86.6%   -0.35%     
   =========================================
     Files         900     900              
     Lines       43605   43608       +3     
   =========================================
   - Hits        37915   37766     -149     
   - Misses       5690    5842     +152
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/models/pool.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvcG9vbC5weQ==) | `97.36% <100%> (ø)` | :arrow_up: |
   | [airflow/api/common/experimental/pool.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC9wb29sLnB5) | `100% <100%> (ø)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `50% <0%> (-50%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0%> (-45.08%)` | :arrow_down: |
   | [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `52.94% <0%> (-32.36%)` | :arrow_down: |
   | [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.69% <0%> (-25.26%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=) | `78.87% <0%> (-15.5%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=footer). Last update [c93f82b...e3e797b](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long
URL: https://github.com/apache/airflow/pull/7658#discussion_r389618856
 
 

 ##########
 File path: airflow/api/common/experimental/pool.py
 ##########
 @@ -51,6 +51,11 @@ def create_pool(name, slots, description, session=None):
     except ValueError:
         raise AirflowBadRequest("Bad value for `slots`: %s" % slots)
 
+    # Get the length of the pool column
+    pool_name_length = Pool.pool.property.columns[0].type.length
+    if len(name) > pool_name_length:
+        raise AirflowBadRequest("Pool name shouldn't be more than %s characters" % pool_name_length)
 
 Review comment:
   ```suggestion
           raise AirflowBadRequest("Pool name can't be more than %d characters" % pool_name_length)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long
URL: https://github.com/apache/airflow/pull/7658#issuecomment-596370707
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=h1) Report
   > Merging [#7658](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/b39468d2878554ba60863656364b4a95eda30685?src=pr&el=desc) will **decrease** coverage by `28.66%`.
   > The diff coverage is `25%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7658/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #7658       +/-   ##
   ==========================================
   - Coverage   86.76%   58.1%   -28.67%     
   ==========================================
     Files         897     896        -1     
     Lines       42819   42796       -23     
   ==========================================
   - Hits        37153   24865    -12288     
   - Misses       5666   17931    +12265
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/api/common/experimental/pool.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC9wb29sLnB5) | `0% <0%> (-100%)` | :arrow_down: |
   | [airflow/models/pool.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvcG9vbC5weQ==) | `76.31% <100%> (-21.06%)` | :arrow_down: |
   | [...low/contrib/operators/wasb\_delete\_blob\_operator.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy93YXNiX2RlbGV0ZV9ibG9iX29wZXJhdG9yLnB5) | `0% <0%> (-100%)` | :arrow_down: |
   | [airflow/contrib/hooks/vertica\_hook.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3ZlcnRpY2FfaG9vay5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
   | [airflow/contrib/sensors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvX19pbml0X18ucHk=) | `0% <0%> (-100%)` | :arrow_down: |
   | [airflow/hooks/mssql\_hook.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9tc3NxbF9ob29rLnB5) | `0% <0%> (-100%)` | :arrow_down: |
   | [...viders/docker/example\_dags/example\_docker\_swarm.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZG9ja2VyL2V4YW1wbGVfZGFncy9leGFtcGxlX2RvY2tlcl9zd2FybS5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
   | [airflow/hooks/webhdfs\_hook.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy93ZWJoZGZzX2hvb2sucHk=) | `0% <0%> (-100%)` | :arrow_down: |
   | [airflow/contrib/sensors/emr\_base\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvZW1yX2Jhc2Vfc2Vuc29yLnB5) | `0% <0%> (-100%)` | :arrow_down: |
   | [...irflow/contrib/operators/slack\_webhook\_operator.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zbGFja193ZWJob29rX29wZXJhdG9yLnB5) | `0% <0%> (-100%)` | :arrow_down: |
   | ... and [504 more](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=footer). Last update [b39468d...e6b0230](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long

Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on a change in pull request #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long
URL: https://github.com/apache/airflow/pull/7658#discussion_r389669117
 
 

 ##########
 File path: airflow/api/common/experimental/pool.py
 ##########
 @@ -51,6 +51,11 @@ def create_pool(name, slots, description, session=None):
     except ValueError:
         raise AirflowBadRequest("Bad value for `slots`: %s" % slots)
 
+    # Get the length of the pool column
+    pool_name_length = Pool.pool.property.columns[0].type.length
+    if len(name) > pool_name_length:
+        raise AirflowBadRequest("Pool name shouldn't be more than %s characters" % pool_name_length)
 
 Review comment:
   Thanks for this review. I'll make the change now

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] boring-cyborg[bot] commented on issue #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long
URL: https://github.com/apache/airflow/pull/7658#issuecomment-596262002
 
 
   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
   Apache Airflow is a community-driven project and together we are making it better 🚀.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://apache-airflow-slack.herokuapp.com/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil merged pull request #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long

Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long
URL: https://github.com/apache/airflow/pull/7658
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] tooptoop4 commented on issue #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long

Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on issue #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long
URL: https://github.com/apache/airflow/pull/7658#issuecomment-596341294
 
 
   thanks. pls add alembic migration script, fix travis. have u tested adding 100 length in cli and ui and 300 length in cli and ui?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long
URL: https://github.com/apache/airflow/pull/7658#issuecomment-596370707
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=h1) Report
   > Merging [#7658](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/85465499074443fa98322051ca11f43c66242cc3?src=pr&el=desc) will **decrease** coverage by `28.73%`.
   > The diff coverage is `25%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7658/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #7658       +/-   ##
   ==========================================
   - Coverage   86.83%   58.1%   -28.74%     
   ==========================================
     Files         897     896        -1     
     Lines       42803   42796        -7     
   ==========================================
   - Hits        37170   24865    -12305     
   - Misses       5633   17931    +12298
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/api/common/experimental/pool.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC9wb29sLnB5) | `0% <0%> (-100%)` | :arrow_down: |
   | [airflow/models/pool.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvcG9vbC5weQ==) | `76.31% <100%> (-21.06%)` | :arrow_down: |
   | [...low/contrib/operators/wasb\_delete\_blob\_operator.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy93YXNiX2RlbGV0ZV9ibG9iX29wZXJhdG9yLnB5) | `0% <0%> (-100%)` | :arrow_down: |
   | [airflow/contrib/hooks/vertica\_hook.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3ZlcnRpY2FfaG9vay5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
   | [airflow/contrib/sensors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvX19pbml0X18ucHk=) | `0% <0%> (-100%)` | :arrow_down: |
   | [airflow/hooks/mssql\_hook.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9tc3NxbF9ob29rLnB5) | `0% <0%> (-100%)` | :arrow_down: |
   | [...viders/docker/example\_dags/example\_docker\_swarm.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZG9ja2VyL2V4YW1wbGVfZGFncy9leGFtcGxlX2RvY2tlcl9zd2FybS5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
   | [airflow/hooks/webhdfs\_hook.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy93ZWJoZGZzX2hvb2sucHk=) | `0% <0%> (-100%)` | :arrow_down: |
   | [airflow/contrib/sensors/emr\_base\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvZW1yX2Jhc2Vfc2Vuc29yLnB5) | `0% <0%> (-100%)` | :arrow_down: |
   | [...irflow/contrib/operators/slack\_webhook\_operator.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zbGFja193ZWJob29rX29wZXJhdG9yLnB5) | `0% <0%> (-100%)` | :arrow_down: |
   | ... and [504 more](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=footer). Last update [8546549...684e9a8](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long
URL: https://github.com/apache/airflow/pull/7658#issuecomment-596370707
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=h1) Report
   > Merging [#7658](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/b39468d2878554ba60863656364b4a95eda30685?src=pr&el=desc) will **decrease** coverage by `0.2%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7658/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7658      +/-   ##
   ==========================================
   - Coverage   86.76%   86.56%   -0.21%     
   ==========================================
     Files         897      897              
     Lines       42819    42822       +3     
   ==========================================
   - Hits        37153    37069      -84     
   - Misses       5666     5753      +87
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/models/pool.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvcG9vbC5weQ==) | `97.36% <100%> (ø)` | :arrow_up: |
   | [airflow/api/common/experimental/pool.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC9wb29sLnB5) | `100% <100%> (ø)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0%> (-45.08%)` | :arrow_down: |
   | [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.69% <0%> (-25.26%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.87% <0%> (-0.29%)` | :arrow_down: |
   | [airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=) | `94.36% <0%> (+15.49%)` | :arrow_up: |
   | [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `85.29% <0%> (+32.35%)` | :arrow_up: |
   | ... and [1 more](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=footer). Last update [b39468d...e6b0230](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] tooptoop4 commented on a change in pull request #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long

Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on a change in pull request #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long
URL: https://github.com/apache/airflow/pull/7658#discussion_r389944161
 
 

 ##########
 File path: airflow/migrations/versions/b25a55525161_increase_length_of_pool_name.py
 ##########
 @@ -0,0 +1,48 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""Increase length of pool name
+
+Revision ID: b25a55525161
+Revises: a4c2fd67d16b
+Create Date: 2020-03-09 08:48:14.534700
+
+"""
+
+import sqlalchemy as sa
+from alembic import op
+
+# revision identifiers, used by Alembic.
+revision = 'b25a55525161'
+down_revision = 'a4c2fd67d16b'
+branch_labels = None
+depends_on = None
+
+
+def upgrade():
+    """Increase column length of pool name from 50 to 250 characters"""
 
 Review comment:
   256 instead of 250

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ephraimbuddy commented on issue #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long

Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on issue #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long
URL: https://github.com/apache/airflow/pull/7658#issuecomment-596527197
 
 
   > thanks. pls add alembic migration script, fix travis. have u tested adding 100 length in cli and ui and 300 length in cli and ui?
   
   I have added it and also fixed travis. 
   I have also tested adding 100, 260, 300 length in cli and ui and It's all fine.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on issue #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long

Posted by GitBox <gi...@apache.org>.
ashb commented on issue #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long
URL: https://github.com/apache/airflow/pull/7658#issuecomment-596675086
 
 
   @ephraimbuddy Rebase on to latest master, it should fix your CI failures

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7658: [AIRFLOW-6443]Increase pool name length to 256, make cli give error if name is too long
URL: https://github.com/apache/airflow/pull/7658#issuecomment-596370707
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=h1) Report
   > Merging [#7658](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/c93f82b10f6eea6e0f1e739085974a5f7a21961f?src=pr&el=desc) will **decrease** coverage by `0.34%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7658/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master   #7658      +/-   ##
   =========================================
   - Coverage   86.95%   86.6%   -0.35%     
   =========================================
     Files         900     900              
     Lines       43605   43608       +3     
   =========================================
   - Hits        37915   37766     -149     
   - Misses       5690    5842     +152
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/models/pool.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvcG9vbC5weQ==) | `97.36% <100%> (ø)` | :arrow_up: |
   | [airflow/api/common/experimental/pool.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC9wb29sLnB5) | `100% <100%> (ø)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `50% <0%> (-50%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0%> (-45.08%)` | :arrow_down: |
   | [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `52.94% <0%> (-32.36%)` | :arrow_down: |
   | [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.69% <0%> (-25.26%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7658/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=) | `78.87% <0%> (-15.5%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=footer). Last update [c93f82b...e3e797b](https://codecov.io/gh/apache/airflow/pull/7658?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services