You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/11/14 15:56:58 UTC
[GitHub] [dubbo-go] georgehao opened a new pull request #876: Enhance: upgrade dubbogo URL
georgehao opened a new pull request #876:
URL: https://github.com/apache/dubbo-go/pull/876
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request.
-->
**What this PR does**:
Enhance dubbogo URL
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
I have two way to fix the URL.
1. move the `paramsLock sync.RWMutex` to `paramsLock *sync.RWMutex`
2. make `common.URL` noCopy, and update all the place where used the `URL`
I have read some discuss https://groups.google.com/g/golang-nuts/c/imxjBLNJ9OY . and read the source code of k8s. the `way 2` is more general, so I select `way 2`
my solution is similar to the PR #773, but #773 missing some files not modify.
I have add the feature of #823 do.
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #876: Enhance: upgrade dubbogo URL
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #876:
URL: https://github.com/apache/dubbo-go/pull/876#discussion_r528307012
##########
File path: go.mod
##########
@@ -51,6 +51,7 @@ require (
replace (
github.com/envoyproxy/go-control-plane => github.com/envoyproxy/go-control-plane v0.8.0
+ github.com/shirou/gopsutil => github.com/shirou/gopsutil v0.0.0-20181107111621-48177ef5f880
Review comment:
https://github.com/alibaba/sentinel-golang/issues/326
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] georgehao commented on a change in pull request #876: Enhance: upgrade dubbogo URL
Posted by GitBox <gi...@apache.org>.
georgehao commented on a change in pull request #876:
URL: https://github.com/apache/dubbo-go/pull/876#discussion_r527400178
##########
File path: go.mod
##########
@@ -51,6 +51,7 @@ require (
replace (
github.com/envoyproxy/go-control-plane => github.com/envoyproxy/go-control-plane v0.8.0
+ github.com/shirou/gopsutil => github.com/shirou/gopsutil v0.0.0-20181107111621-48177ef5f880
Review comment:
@zouyx 贤哥搞的, 贤哥看下吧
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #876: Enhance: upgrade dubbogo URL
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #876:
URL: https://github.com/apache/dubbo-go/pull/876#issuecomment-727598335
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=h1) Report
> Merging [#876](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=desc) (10f85c0) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/f22ffdde6e2465a18b9e0b9b00dfc9154f457375?el=desc) (f22ffdd) will **decrease** coverage by `0.09%`.
> The diff coverage is `62.37%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #876 +/- ##
===========================================
- Coverage 60.17% 60.07% -0.10%
===========================================
Files 260 260
Lines 12807 12783 -24
===========================================
- Hits 7706 7679 -27
- Misses 4144 4146 +2
- Partials 957 958 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `61.11% <ø> (ø)` | |
| [cluster/router/condition/listenable\_router.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY29uZGl0aW9uL2xpc3RlbmFibGVfcm91dGVyLmdv) | `54.71% <0.00%> (ø)` | |
| [cluster/router/healthcheck/health\_check\_route.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svaGVhbHRoX2NoZWNrX3JvdXRlLmdv) | `70.37% <0.00%> (ø)` | |
| [cluster/router/tag/tag\_router.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvdGFnL3RhZ19yb3V0ZXIuZ28=) | `72.59% <0.00%> (ø)` | |
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `13.33% <0.00%> (ø)` | |
| [config\_center/dynamic\_configuration.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9keW5hbWljX2NvbmZpZ3VyYXRpb24uZ28=) | `60.00% <ø> (ø)` | |
| [filter/filter\_impl/sentinel\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3NlbnRpbmVsX2ZpbHRlci5nbw==) | `62.22% <ø> (ø)` | |
| [...lter/filter\_impl/tps/tps\_limiter\_method\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRlcl9tZXRob2Rfc2VydmljZS5nbw==) | `78.57% <ø> (ø)` | |
| [filter/filter\_impl/tps/tps\_limiter\_mock.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRlcl9tb2NrLmdv) | `0.00% <ø> (ø)` | |
| [filter/handler/rejected\_execution\_handler\_mock.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2hhbmRsZXIvcmVqZWN0ZWRfZXhlY3V0aW9uX2hhbmRsZXJfbW9jay5nbw==) | `0.00% <ø> (ø)` | |
| ... and [82 more](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=footer). Last update [f22ffdd...600e030](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #876: Enhance: upgrade dubbogo URL
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #876:
URL: https://github.com/apache/dubbo-go/pull/876#issuecomment-727598335
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=h1) Report
> Merging [#876](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=desc) (10f85c0) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/f22ffdde6e2465a18b9e0b9b00dfc9154f457375?el=desc) (f22ffdd) will **decrease** coverage by `0.09%`.
> The diff coverage is `62.37%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #876 +/- ##
===========================================
- Coverage 60.17% 60.07% -0.10%
===========================================
Files 260 260
Lines 12807 12783 -24
===========================================
- Hits 7706 7679 -27
- Misses 4144 4146 +2
- Partials 957 958 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `61.11% <ø> (ø)` | |
| [cluster/router/condition/listenable\_router.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY29uZGl0aW9uL2xpc3RlbmFibGVfcm91dGVyLmdv) | `54.71% <0.00%> (ø)` | |
| [cluster/router/healthcheck/health\_check\_route.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svaGVhbHRoX2NoZWNrX3JvdXRlLmdv) | `70.37% <0.00%> (ø)` | |
| [cluster/router/tag/tag\_router.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvdGFnL3RhZ19yb3V0ZXIuZ28=) | `72.59% <0.00%> (ø)` | |
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `13.33% <0.00%> (ø)` | |
| [config\_center/dynamic\_configuration.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9keW5hbWljX2NvbmZpZ3VyYXRpb24uZ28=) | `60.00% <ø> (ø)` | |
| [filter/filter\_impl/sentinel\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3NlbnRpbmVsX2ZpbHRlci5nbw==) | `62.22% <ø> (ø)` | |
| [...lter/filter\_impl/tps/tps\_limiter\_method\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRlcl9tZXRob2Rfc2VydmljZS5nbw==) | `78.57% <ø> (ø)` | |
| [filter/filter\_impl/tps/tps\_limiter\_mock.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRlcl9tb2NrLmdv) | `0.00% <ø> (ø)` | |
| [filter/handler/rejected\_execution\_handler\_mock.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2hhbmRsZXIvcmVqZWN0ZWRfZXhlY3V0aW9uX2hhbmRsZXJfbW9jay5nbw==) | `0.00% <ø> (ø)` | |
| ... and [82 more](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=footer). Last update [f22ffdd...10f85c0](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #876: Enhance: upgrade dubbogo URL
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #876:
URL: https://github.com/apache/dubbo-go/pull/876#issuecomment-727598335
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=h1) Report
> Merging [#876](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=desc) (03f164a) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/f22ffdde6e2465a18b9e0b9b00dfc9154f457375?el=desc) (f22ffdd) will **decrease** coverage by `0.13%`.
> The diff coverage is `60.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #876 +/- ##
===========================================
- Coverage 60.17% 60.03% -0.14%
===========================================
Files 260 260
Lines 12807 12783 -24
===========================================
- Hits 7706 7674 -32
- Misses 4144 4152 +8
Partials 957 957
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `61.11% <ø> (ø)` | |
| [cluster/router/condition/listenable\_router.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY29uZGl0aW9uL2xpc3RlbmFibGVfcm91dGVyLmdv) | `54.71% <0.00%> (ø)` | |
| [cluster/router/healthcheck/health\_check\_route.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svaGVhbHRoX2NoZWNrX3JvdXRlLmdv) | `70.37% <0.00%> (ø)` | |
| [cluster/router/tag/tag\_router.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvdGFnL3RhZ19yb3V0ZXIuZ28=) | `72.59% <0.00%> (ø)` | |
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `13.33% <0.00%> (ø)` | |
| [config\_center/dynamic\_configuration.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9keW5hbWljX2NvbmZpZ3VyYXRpb24uZ28=) | `60.00% <ø> (ø)` | |
| [filter/filter\_impl/sentinel\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3NlbnRpbmVsX2ZpbHRlci5nbw==) | `62.22% <ø> (ø)` | |
| [...lter/filter\_impl/tps/tps\_limiter\_method\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRlcl9tZXRob2Rfc2VydmljZS5nbw==) | `78.57% <ø> (ø)` | |
| [filter/filter\_impl/tps/tps\_limiter\_mock.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRlcl9tb2NrLmdv) | `0.00% <ø> (ø)` | |
| [filter/handler/rejected\_execution\_handler\_mock.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2hhbmRsZXIvcmVqZWN0ZWRfZXhlY3V0aW9uX2hhbmRsZXJfbW9jay5nbw==) | `0.00% <ø> (ø)` | |
| ... and [84 more](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=footer). Last update [f22ffdd...10f85c0](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on pull request #876: Enhance: upgrade dubbogo URL
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #876:
URL: https://github.com/apache/dubbo-go/pull/876#issuecomment-727598335
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=h1) Report
> Merging [#876](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=desc) (10f85c0) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/f22ffdde6e2465a18b9e0b9b00dfc9154f457375?el=desc) (f22ffdd) will **decrease** coverage by `0.24%`.
> The diff coverage is `62.37%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #876 +/- ##
===========================================
- Coverage 60.17% 59.92% -0.25%
===========================================
Files 260 260
Lines 12807 12783 -24
===========================================
- Hits 7706 7660 -46
- Misses 4144 4161 +17
- Partials 957 962 +5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `61.11% <ø> (ø)` | |
| [cluster/router/condition/listenable\_router.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY29uZGl0aW9uL2xpc3RlbmFibGVfcm91dGVyLmdv) | `54.71% <0.00%> (ø)` | |
| [cluster/router/healthcheck/health\_check\_route.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svaGVhbHRoX2NoZWNrX3JvdXRlLmdv) | `70.37% <0.00%> (ø)` | |
| [cluster/router/tag/tag\_router.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvdGFnL3RhZ19yb3V0ZXIuZ28=) | `72.59% <0.00%> (ø)` | |
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `13.33% <0.00%> (ø)` | |
| [config\_center/dynamic\_configuration.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9keW5hbWljX2NvbmZpZ3VyYXRpb24uZ28=) | `60.00% <ø> (ø)` | |
| [filter/filter\_impl/sentinel\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3NlbnRpbmVsX2ZpbHRlci5nbw==) | `62.22% <ø> (ø)` | |
| [...lter/filter\_impl/tps/tps\_limiter\_method\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRlcl9tZXRob2Rfc2VydmljZS5nbw==) | `78.57% <ø> (ø)` | |
| [filter/filter\_impl/tps/tps\_limiter\_mock.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRlcl9tb2NrLmdv) | `0.00% <ø> (ø)` | |
| [filter/handler/rejected\_execution\_handler\_mock.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2hhbmRsZXIvcmVqZWN0ZWRfZXhlY3V0aW9uX2hhbmRsZXJfbW9jay5nbw==) | `0.00% <ø> (ø)` | |
| ... and [84 more](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=footer). Last update [f22ffdd...10f85c0](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] georgehao commented on a change in pull request #876: Enhance: upgrade dubbogo URL
Posted by GitBox <gi...@apache.org>.
georgehao commented on a change in pull request #876:
URL: https://github.com/apache/dubbo-go/pull/876#discussion_r527400508
##########
File path: common/proxy/proxy_factory/default.go
##########
@@ -90,7 +90,7 @@ func (pi *ProxyInvoker) Invoke(ctx context.Context, invocation protocol.Invocati
url := pi.GetUrl()
//get providerUrl. The origin url may be is registry URL.
- url = *getProviderURL(&url)
+ url = getProviderURL(url)
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #876: Enhance: upgrade dubbogo URL
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #876:
URL: https://github.com/apache/dubbo-go/pull/876#issuecomment-727598335
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=h1) Report
> Merging [#876](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=desc) (600e030) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/f22ffdde6e2465a18b9e0b9b00dfc9154f457375?el=desc) (f22ffdd) will **decrease** coverage by `0.13%`.
> The diff coverage is `62.37%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #876 +/- ##
===========================================
- Coverage 60.17% 60.03% -0.14%
===========================================
Files 260 260
Lines 12807 12782 -25
===========================================
- Hits 7706 7674 -32
- Misses 4144 4150 +6
- Partials 957 958 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `61.11% <ø> (ø)` | |
| [cluster/router/condition/listenable\_router.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY29uZGl0aW9uL2xpc3RlbmFibGVfcm91dGVyLmdv) | `54.71% <0.00%> (ø)` | |
| [cluster/router/healthcheck/health\_check\_route.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svaGVhbHRoX2NoZWNrX3JvdXRlLmdv) | `70.37% <0.00%> (ø)` | |
| [cluster/router/tag/tag\_router.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvdGFnL3RhZ19yb3V0ZXIuZ28=) | `72.59% <0.00%> (ø)` | |
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `13.55% <0.00%> (+0.22%)` | :arrow_up: |
| [config\_center/dynamic\_configuration.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9keW5hbWljX2NvbmZpZ3VyYXRpb24uZ28=) | `60.00% <ø> (ø)` | |
| [filter/filter\_impl/sentinel\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3NlbnRpbmVsX2ZpbHRlci5nbw==) | `62.22% <ø> (ø)` | |
| [...lter/filter\_impl/tps/tps\_limiter\_method\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRlcl9tZXRob2Rfc2VydmljZS5nbw==) | `78.57% <ø> (ø)` | |
| [filter/filter\_impl/tps/tps\_limiter\_mock.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRlcl9tb2NrLmdv) | `0.00% <ø> (ø)` | |
| [filter/handler/rejected\_execution\_handler\_mock.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2hhbmRsZXIvcmVqZWN0ZWRfZXhlY3V0aW9uX2hhbmRsZXJfbW9jay5nbw==) | `0.00% <ø> (ø)` | |
| ... and [82 more](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=footer). Last update [f22ffdd...600e030](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #876: Enhance: upgrade dubbogo URL
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #876:
URL: https://github.com/apache/dubbo-go/pull/876#issuecomment-727598335
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=h1) Report
> Merging [#876](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=desc) (616526d) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/f22ffdde6e2465a18b9e0b9b00dfc9154f457375?el=desc) (f22ffdd) will **decrease** coverage by `0.12%`.
> The diff coverage is `60.19%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #876 +/- ##
===========================================
- Coverage 60.17% 60.04% -0.13%
===========================================
Files 260 260
Lines 12807 12783 -24
===========================================
- Hits 7706 7676 -30
- Misses 4144 4150 +6
Partials 957 957
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `61.11% <ø> (ø)` | |
| [cluster/router/condition/listenable\_router.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY29uZGl0aW9uL2xpc3RlbmFibGVfcm91dGVyLmdv) | `54.71% <0.00%> (ø)` | |
| [cluster/router/healthcheck/health\_check\_route.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svaGVhbHRoX2NoZWNrX3JvdXRlLmdv) | `70.37% <0.00%> (ø)` | |
| [cluster/router/tag/tag\_router.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvdGFnL3RhZ19yb3V0ZXIuZ28=) | `72.59% <0.00%> (ø)` | |
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `13.33% <0.00%> (ø)` | |
| [config\_center/dynamic\_configuration.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9keW5hbWljX2NvbmZpZ3VyYXRpb24uZ28=) | `60.00% <ø> (ø)` | |
| [filter/filter\_impl/sentinel\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3NlbnRpbmVsX2ZpbHRlci5nbw==) | `62.22% <ø> (ø)` | |
| [...lter/filter\_impl/tps/tps\_limiter\_method\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRlcl9tZXRob2Rfc2VydmljZS5nbw==) | `78.57% <ø> (ø)` | |
| [filter/filter\_impl/tps/tps\_limiter\_mock.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRlcl9tb2NrLmdv) | `0.00% <ø> (ø)` | |
| [filter/handler/rejected\_execution\_handler\_mock.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2hhbmRsZXIvcmVqZWN0ZWRfZXhlY3V0aW9uX2hhbmRsZXJfbW9jay5nbw==) | `0.00% <ø> (ø)` | |
| ... and [83 more](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=footer). Last update [f22ffdd...10f85c0](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #876: Enhance: upgrade dubbogo URL
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #876:
URL: https://github.com/apache/dubbo-go/pull/876#issuecomment-727598335
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=h1) Report
> Merging [#876](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=desc) (600e030) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/f22ffdde6e2465a18b9e0b9b00dfc9154f457375?el=desc) (f22ffdd) will **decrease** coverage by `0.27%`.
> The diff coverage is `62.37%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #876 +/- ##
===========================================
- Coverage 60.17% 59.89% -0.28%
===========================================
Files 260 260
Lines 12807 12782 -25
===========================================
- Hits 7706 7656 -50
- Misses 4144 4168 +24
- Partials 957 958 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `52.77% <ø> (-8.34%)` | :arrow_down: |
| [cluster/router/condition/listenable\_router.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY29uZGl0aW9uL2xpc3RlbmFibGVfcm91dGVyLmdv) | `54.71% <0.00%> (ø)` | |
| [cluster/router/healthcheck/health\_check\_route.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svaGVhbHRoX2NoZWNrX3JvdXRlLmdv) | `70.37% <0.00%> (ø)` | |
| [cluster/router/tag/tag\_router.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvdGFnL3RhZ19yb3V0ZXIuZ28=) | `72.59% <0.00%> (ø)` | |
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `13.55% <0.00%> (+0.22%)` | :arrow_up: |
| [config\_center/dynamic\_configuration.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9keW5hbWljX2NvbmZpZ3VyYXRpb24uZ28=) | `60.00% <ø> (ø)` | |
| [filter/filter\_impl/sentinel\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3NlbnRpbmVsX2ZpbHRlci5nbw==) | `62.22% <ø> (ø)` | |
| [...lter/filter\_impl/tps/tps\_limiter\_method\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRlcl9tZXRob2Rfc2VydmljZS5nbw==) | `78.57% <ø> (ø)` | |
| [filter/filter\_impl/tps/tps\_limiter\_mock.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRlcl9tb2NrLmdv) | `0.00% <ø> (ø)` | |
| [filter/handler/rejected\_execution\_handler\_mock.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2hhbmRsZXIvcmVqZWN0ZWRfZXhlY3V0aW9uX2hhbmRsZXJfbW9jay5nbw==) | `0.00% <ø> (ø)` | |
| ... and [84 more](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=footer). Last update [f22ffdd...600e030](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] cvictory commented on a change in pull request #876: Enhance: upgrade dubbogo URL
Posted by GitBox <gi...@apache.org>.
cvictory commented on a change in pull request #876:
URL: https://github.com/apache/dubbo-go/pull/876#discussion_r526020632
##########
File path: common/proxy/proxy_factory/default.go
##########
@@ -90,7 +90,7 @@ func (pi *ProxyInvoker) Invoke(ctx context.Context, invocation protocol.Invocati
url := pi.GetUrl()
//get providerUrl. The origin url may be is registry URL.
- url = *getProviderURL(&url)
+ url = getProviderURL(url)
Review comment:
两行可以合并吧
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #876: Enhance: upgrade dubbogo URL
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #876:
URL: https://github.com/apache/dubbo-go/pull/876
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #876: Enhance: upgrade dubbogo URL
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #876:
URL: https://github.com/apache/dubbo-go/pull/876#issuecomment-727598335
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=h1) Report
> Merging [#876](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=desc) (e9160e3) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/f22ffdde6e2465a18b9e0b9b00dfc9154f457375?el=desc) (f22ffdd) will **decrease** coverage by `0.34%`.
> The diff coverage is `60.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #876 +/- ##
===========================================
- Coverage 60.17% 59.82% -0.35%
===========================================
Files 260 260
Lines 12807 12783 -24
===========================================
- Hits 7706 7647 -59
- Misses 4144 4175 +31
- Partials 957 961 +4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `61.11% <ø> (ø)` | |
| [cluster/router/condition/listenable\_router.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY29uZGl0aW9uL2xpc3RlbmFibGVfcm91dGVyLmdv) | `54.71% <0.00%> (ø)` | |
| [cluster/router/healthcheck/health\_check\_route.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svaGVhbHRoX2NoZWNrX3JvdXRlLmdv) | `70.37% <0.00%> (ø)` | |
| [cluster/router/tag/tag\_router.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvdGFnL3RhZ19yb3V0ZXIuZ28=) | `72.59% <0.00%> (ø)` | |
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `13.33% <0.00%> (ø)` | |
| [config\_center/dynamic\_configuration.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9keW5hbWljX2NvbmZpZ3VyYXRpb24uZ28=) | `60.00% <ø> (ø)` | |
| [filter/filter\_impl/sentinel\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3NlbnRpbmVsX2ZpbHRlci5nbw==) | `62.22% <ø> (ø)` | |
| [...lter/filter\_impl/tps/tps\_limiter\_method\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRlcl9tZXRob2Rfc2VydmljZS5nbw==) | `78.57% <ø> (ø)` | |
| [filter/filter\_impl/tps/tps\_limiter\_mock.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRlcl9tb2NrLmdv) | `0.00% <ø> (ø)` | |
| [filter/handler/rejected\_execution\_handler\_mock.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2hhbmRsZXIvcmVqZWN0ZWRfZXhlY3V0aW9uX2hhbmRsZXJfbW9jay5nbw==) | `0.00% <ø> (ø)` | |
| ... and [84 more](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=footer). Last update [f22ffdd...10f85c0](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] cvictory commented on a change in pull request #876: Enhance: upgrade dubbogo URL
Posted by GitBox <gi...@apache.org>.
cvictory commented on a change in pull request #876:
URL: https://github.com/apache/dubbo-go/pull/876#discussion_r526037736
##########
File path: go.mod
##########
@@ -51,6 +51,7 @@ require (
replace (
github.com/envoyproxy/go-control-plane => github.com/envoyproxy/go-control-plane v0.8.0
+ github.com/shirou/gopsutil => github.com/shirou/gopsutil v0.0.0-20181107111621-48177ef5f880
Review comment:
为什么指定版本？ 而且是通过replace方式？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] cvictory commented on a change in pull request #876: Enhance: upgrade dubbogo URL
Posted by GitBox <gi...@apache.org>.
cvictory commented on a change in pull request #876:
URL: https://github.com/apache/dubbo-go/pull/876#discussion_r526044723
##########
File path: config/config_loader_test.go
##########
@@ -418,23 +417,23 @@ func (mts *mockMetadataService) addURL(targetMap *sync.Map, url *common.URL) boo
}
mts.lock.Lock()
// double chk
- wantedUrl := urlSet.(*skip.SkipList).Get(Comparator(*url))
+ wantedUrl := urlSet.(*skip.SkipList).Get(url)
if len(wantedUrl) > 0 && wantedUrl[0] != nil {
mts.lock.Unlock()
return false
}
- urlSet.(*skip.SkipList).Insert(Comparator(*url))
+ urlSet.(*skip.SkipList).Insert(url)
mts.lock.Unlock()
return true
}
-func (m *mockMetadataService) getAllService(services *sync.Map) []common.URL {
+func (m *mockMetadataService) getAllService(services *sync.Map) []*common.URL {
// using skip list to dedup and sorting
- res := make([]common.URL, 0)
+ var res []*common.URL
services.Range(func(key, value interface{}) bool {
urls := value.(*skip.SkipList)
for i := uint64(0); i < urls.Len(); i++ {
- url := common.URL(urls.ByPosition(i).(Comparator))
+ url := urls.ByPosition(i).(*common.URL)
Review comment:
转换确认下，没有问题。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #876: Enhance: upgrade dubbogo URL
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #876:
URL: https://github.com/apache/dubbo-go/pull/876#issuecomment-727598335
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=h1) Report
> Merging [#876](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=desc) (cfc6ef7) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/f22ffdde6e2465a18b9e0b9b00dfc9154f457375?el=desc) (f22ffdd) will **decrease** coverage by `0.12%`.
> The diff coverage is `61.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #876 +/- ##
===========================================
- Coverage 60.17% 60.04% -0.13%
===========================================
Files 260 260
Lines 12807 12783 -24
===========================================
- Hits 7706 7676 -30
- Misses 4144 4150 +6
Partials 957 957
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `61.11% <ø> (ø)` | |
| [cluster/router/condition/listenable\_router.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY29uZGl0aW9uL2xpc3RlbmFibGVfcm91dGVyLmdv) | `54.71% <0.00%> (ø)` | |
| [cluster/router/healthcheck/health\_check\_route.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svaGVhbHRoX2NoZWNrX3JvdXRlLmdv) | `70.37% <0.00%> (ø)` | |
| [cluster/router/tag/tag\_router.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvdGFnL3RhZ19yb3V0ZXIuZ28=) | `72.59% <0.00%> (ø)` | |
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `13.33% <0.00%> (ø)` | |
| [config\_center/dynamic\_configuration.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9keW5hbWljX2NvbmZpZ3VyYXRpb24uZ28=) | `60.00% <ø> (ø)` | |
| [filter/filter\_impl/sentinel\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3NlbnRpbmVsX2ZpbHRlci5nbw==) | `62.22% <ø> (ø)` | |
| [...lter/filter\_impl/tps/tps\_limiter\_method\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRlcl9tZXRob2Rfc2VydmljZS5nbw==) | `78.57% <ø> (ø)` | |
| [filter/filter\_impl/tps/tps\_limiter\_mock.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRlcl9tb2NrLmdv) | `0.00% <ø> (ø)` | |
| [filter/handler/rejected\_execution\_handler\_mock.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2hhbmRsZXIvcmVqZWN0ZWRfZXhlY3V0aW9uX2hhbmRsZXJfbW9jay5nbw==) | `0.00% <ø> (ø)` | |
| ... and [83 more](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=footer). Last update [f22ffdd...10f85c0](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] georgehao commented on a change in pull request #876: Enhance: upgrade dubbogo URL
Posted by GitBox <gi...@apache.org>.
georgehao commented on a change in pull request #876:
URL: https://github.com/apache/dubbo-go/pull/876#discussion_r527400420
##########
File path: config/config_loader_test.go
##########
@@ -418,23 +417,23 @@ func (mts *mockMetadataService) addURL(targetMap *sync.Map, url *common.URL) boo
}
mts.lock.Lock()
// double chk
- wantedUrl := urlSet.(*skip.SkipList).Get(Comparator(*url))
+ wantedUrl := urlSet.(*skip.SkipList).Get(url)
if len(wantedUrl) > 0 && wantedUrl[0] != nil {
mts.lock.Unlock()
return false
}
- urlSet.(*skip.SkipList).Insert(Comparator(*url))
+ urlSet.(*skip.SkipList).Insert(url)
mts.lock.Unlock()
return true
}
-func (m *mockMetadataService) getAllService(services *sync.Map) []common.URL {
+func (m *mockMetadataService) getAllService(services *sync.Map) []*common.URL {
// using skip list to dedup and sorting
- res := make([]common.URL, 0)
+ var res []*common.URL
services.Range(func(key, value interface{}) bool {
urls := value.(*skip.SkipList)
for i := uint64(0); i < urls.Len(); i++ {
- url := common.URL(urls.ByPosition(i).(Comparator))
+ url := urls.ByPosition(i).(*common.URL)
Review comment:
嗯, 我用URL实现了Comparator, 把config_loader里面实现的Comparator给去掉了
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] fangyincheng commented on pull request #876: Enhance: upgrade dubbogo URL
Posted by GitBox <gi...@apache.org>.
fangyincheng commented on pull request #876:
URL: https://github.com/apache/dubbo-go/pull/876#issuecomment-731510856
> > Thanks @georgehao , make `Checks`normal pls.
> > BTW can i close #773 ?
>
> yes, you can close 773.
what about 823?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] georgehao commented on pull request #876: Enhance: upgrade dubbogo URL
Posted by GitBox <gi...@apache.org>.
georgehao commented on pull request #876:
URL: https://github.com/apache/dubbo-go/pull/876#issuecomment-727557476
> Thanks @georgehao , make `Checks`normal pls.
> BTW can i close #773 ?
yes, you can close 773.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #876: Enhance: upgrade dubbogo URL
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #876:
URL: https://github.com/apache/dubbo-go/pull/876#issuecomment-727598335
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=h1) Report
> Merging [#876](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=desc) (603d829) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/f22ffdde6e2465a18b9e0b9b00dfc9154f457375?el=desc) (f22ffdd) will **decrease** coverage by `0.24%`.
> The diff coverage is `60.19%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #876 +/- ##
===========================================
- Coverage 60.17% 59.92% -0.25%
===========================================
Files 260 260
Lines 12807 12783 -24
===========================================
- Hits 7706 7660 -46
- Misses 4144 4160 +16
- Partials 957 963 +6
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `61.11% <ø> (ø)` | |
| [cluster/router/condition/listenable\_router.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY29uZGl0aW9uL2xpc3RlbmFibGVfcm91dGVyLmdv) | `54.71% <0.00%> (ø)` | |
| [cluster/router/healthcheck/health\_check\_route.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svaGVhbHRoX2NoZWNrX3JvdXRlLmdv) | `70.37% <0.00%> (ø)` | |
| [cluster/router/tag/tag\_router.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvdGFnL3RhZ19yb3V0ZXIuZ28=) | `72.59% <0.00%> (ø)` | |
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `13.33% <0.00%> (ø)` | |
| [config\_center/dynamic\_configuration.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9keW5hbWljX2NvbmZpZ3VyYXRpb24uZ28=) | `60.00% <ø> (ø)` | |
| [filter/filter\_impl/sentinel\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3NlbnRpbmVsX2ZpbHRlci5nbw==) | `62.22% <ø> (ø)` | |
| [...lter/filter\_impl/tps/tps\_limiter\_method\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRlcl9tZXRob2Rfc2VydmljZS5nbw==) | `78.57% <ø> (ø)` | |
| [filter/filter\_impl/tps/tps\_limiter\_mock.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRlcl9tb2NrLmdv) | `0.00% <ø> (ø)` | |
| [filter/handler/rejected\_execution\_handler\_mock.go](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree#diff-ZmlsdGVyL2hhbmRsZXIvcmVqZWN0ZWRfZXhlY3V0aW9uX2hhbmRsZXJfbW9jay5nbw==) | `0.00% <ø> (ø)` | |
| ... and [89 more](https://codecov.io/gh/apache/dubbo-go/pull/876/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=footer). Last update [f22ffdd...10f85c0](https://codecov.io/gh/apache/dubbo-go/pull/876?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org