You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/03/31 19:19:01 UTC
[jira] [Commented] (ATLAS-4128) [Atlas: Glossary Term Bulk
Import]Bulk import glossary terms should not allow creation of blank/empty
glossaries
[ https://issues.apache.org/jira/browse/ATLAS-4128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312645#comment-17312645 ]
ASF subversion and git services commented on ATLAS-4128:
--------------------------------------------------------
Commit 842890d27bf739a0949e82b58d9db1f1dd6111ea in atlas's branch refs/heads/master from mayanknj
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=842890d ]
ATLAS-4129: Glossary Bulk Import Bugs consolidated fix (ATLAS-4128, ATLAS-4131, ATLAS-4160, ATLAS-4130, ATLAS-4129)
Signed-off-by: Sarath Subramanian <sa...@apache.org>
> [Atlas: Glossary Term Bulk Import]Bulk import glossary terms should not allow creation of blank/empty glossaries
> ----------------------------------------------------------------------------------------------------------------
>
> Key: ATLAS-4128
> URL: https://issues.apache.org/jira/browse/ATLAS-4128
> Project: Atlas
> Issue Type: Bug
> Components: atlas-core
> Reporter: Dharshana M Krishnamoorthy
> Assignee: Mayank Jain
> Priority: Major
> Attachments: Screenshot 2021-01-25 at 6.13.59 PM.png, Screenshot 2021-01-28 at 11.25.14 AM.png
>
>
> Currently via bulk import glossary term, we allow creation of blank/empty glossaries.
> We should not allow these
> Response of : "api/atlas/v2/glossary" api
> {code:java}
> [
> {
> "guid": "34bf4540-5909-4a8e-84f0-1ff310870730",
> "qualifiedName": "glossary_1",
> "name": "glossary_1",
> "terms": [
> {
> "termGuid": "1ccaa2a2-f663-43ee-8cbc-f20c0ac95af0",
> "relationGuid": "b255b30e-be93-44e4-93bf-3d2d11a512d4",
> "displayText": "term_1"
> }
> ]
> },
> {
> "guid": "8834a901-0fde-4123-8d82-06e655ccf231",
> "qualifiedName": " ",
> "name": " ",
> "terms": [
> {
> "termGuid": "ac3f05d9-16d4-4ac5-be9c-bc5034af02d8",
> "relationGuid": "9c2ef8dd-522c-4d07-a338-093f39bceb93",
> "displayText": "no name term"
> }
> ]
> },
> {
> "guid": "29950f59-e863-42e2-a3f8-a070e706a934",
> "terms": [
> {
> "termGuid": "9e504d8d-8be2-4518-821a-cad3d86dfa6d",
> "relationGuid": "75f8f3d0-258a-4428-bb6c-08e59da90ee3",
> "displayText": "empty_term"
> }
> ]
> }
> ]
> {code}
> As seen above there exists a glossary with name " " and with no name.
> Not sure of the implication of such a glossary
> Though the request fails with right exception it ends up creating blank glossary
> Payload used:
> {code:java}
> GlossaryName, TermName, ShortDescription, LongDescription, Examples, Abbreviation, Usage, AdditionalAttributes, TranslationTerms, ValidValuesFor, Synonyms, ReplacedBy, ValidValues, ReplacementTerms, SeeAlso, TranslatedTerms, IsA, Antonyms, Classifies, PreferredToTerms, PreferredTerms
> " ", " ",{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)