You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by "aditya87 (GitHub)" <gi...@apache.org> on 2018/12/14 21:54:47 UTC

[GitHub] [geode] aditya87 commented on pull request #2991: GEODE-5971: refactor expiration config objects

Maybe this is more stylistic, but you've probably noticed that coming from the Go-style I prefer ifs to be flat and not hierarchical, as much as possible. I'm ok with either way, but I've noticed that in this class we now have a dichotomy, i.e. we're doing both flat ifs and hierarchical ifs when it comes to `if (regionAttributes != null)`. Can we be consistent across this class? I.e. either flatten them all out or group them all into a global `if (regionAttributes != null)`?

[ Full content available at: https://github.com/apache/geode/pull/2991 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org