You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Kevin Urciolo (JIRA)" <ji...@apache.org> on 2011/08/03 22:17:26 UTC

[jira] [Created] (AMQ-3436) Support Prioritization Of Messages Pending Dispatch

Support Prioritization Of Messages Pending Dispatch
---------------------------------------------------

                 Key: AMQ-3436
                 URL: https://issues.apache.org/jira/browse/AMQ-3436
             Project: ActiveMQ
          Issue Type: Improvement
          Components: Broker
    Affects Versions: 5.5.0
            Reporter: Kevin Urciolo
            Priority: Minor


ActiveMQ does not deliver messages in priority order when the following conditions are true:

1.  A consumer has prefetch set to one (or zero).
2.  The consumer is created (consumerSession.createConsumer) prior to message delivery
3.  Large maxPageSize is configured

The fix is to modify org.apache.activemq.broker.region.Queue to use a PrioritizationPendingList for the message in "pagedInPendingDispatch" so they are dispatched in priority order.

A test case reproducing the issue is included.
The patched file deltas are included.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (AMQ-3436) Support Prioritization Of Messages Pending Dispatch

Posted by "Kevin Urciolo (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AMQ-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Urciolo updated AMQ-3436:
-------------------------------

    Attachment: PendingList.java-patch.txt
                OrderedPendingList.java-patch.txt
                PrioritizedPendingList.java-patch.txt
                Queue.java-patch.txt

These are the changes required to have the pending message list for the dispatcher in Queue.java use the PendingList class.

> Support Prioritization Of Messages Pending Dispatch
> ---------------------------------------------------
>
>                 Key: AMQ-3436
>                 URL: https://issues.apache.org/jira/browse/AMQ-3436
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 5.5.0
>            Reporter: Kevin Urciolo
>            Priority: Minor
>         Attachments: AMQPriorityTest.java, OrderedPendingList.java-patch.txt, PendingList.java-patch.txt, PrioritizedPendingList.java-patch.txt, Queue.java-patch.txt
>
>
> ActiveMQ does not deliver messages in priority order when the following conditions are true:
> 1.  A consumer has prefetch set to one (or zero).
> 2.  The consumer is created (consumerSession.createConsumer) prior to message delivery
> 3.  Large maxPageSize is configured
> The fix is to modify org.apache.activemq.broker.region.Queue to use a PrioritizationPendingList for the message in "pagedInPendingDispatch" so they are dispatched in priority order.
> A test case reproducing the issue is included.
> The patched file deltas are included.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (AMQ-3436) Support Prioritization Of Messages Pending Dispatch

Posted by "Timothy Bish (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AMQ-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timothy Bish resolved AMQ-3436.
-------------------------------

    Resolution: Fixed

Patch applied with thanks. Required some modifications.  Patch broke some Temp Destination functionality as the TempQueue class has its own init method.  Test also needed a few tweaks as well.
                
> Support Prioritization Of Messages Pending Dispatch
> ---------------------------------------------------
>
>                 Key: AMQ-3436
>                 URL: https://issues.apache.org/jira/browse/AMQ-3436
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 5.5.0
>            Reporter: Kevin Urciolo
>            Assignee: Timothy Bish
>            Priority: Minor
>             Fix For: 5.6.0
>
>         Attachments: AMQPriorityTest.java, OrderedPendingList.java-patch.txt, PendingList.java-patch.txt, PrioritizedPendingList.java-patch.txt, Queue.java-patch.txt
>
>
> ActiveMQ does not deliver messages in priority order when the following conditions are true:
> 1.  A consumer has prefetch set to one (or zero).
> 2.  The consumer is created (consumerSession.createConsumer) prior to message delivery
> 3.  Large maxPageSize is configured
> The fix is to modify org.apache.activemq.broker.region.Queue to use a PrioritizationPendingList for the message in "pagedInPendingDispatch" so they are dispatched in priority order.
> A test case reproducing the issue is included.
> The patched file deltas are included.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (AMQ-3436) Support Prioritization Of Messages Pending Dispatch

Posted by "Kevin Urciolo (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AMQ-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Urciolo updated AMQ-3436:
-------------------------------

    Attachment: AMQPriorityTest.java

This is the junit test that reproduces the issue.

> Support Prioritization Of Messages Pending Dispatch
> ---------------------------------------------------
>
>                 Key: AMQ-3436
>                 URL: https://issues.apache.org/jira/browse/AMQ-3436
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 5.5.0
>            Reporter: Kevin Urciolo
>            Priority: Minor
>         Attachments: AMQPriorityTest.java
>
>
> ActiveMQ does not deliver messages in priority order when the following conditions are true:
> 1.  A consumer has prefetch set to one (or zero).
> 2.  The consumer is created (consumerSession.createConsumer) prior to message delivery
> 3.  Large maxPageSize is configured
> The fix is to modify org.apache.activemq.broker.region.Queue to use a PrioritizationPendingList for the message in "pagedInPendingDispatch" so they are dispatched in priority order.
> A test case reproducing the issue is included.
> The patched file deltas are included.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (AMQ-3436) Support Prioritization Of Messages Pending Dispatch

Posted by "Gary Tully (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AMQ-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Tully updated AMQ-3436:
----------------------------

    Fix Version/s: 5.6.0

patch and test, should put in 5.6
                
> Support Prioritization Of Messages Pending Dispatch
> ---------------------------------------------------
>
>                 Key: AMQ-3436
>                 URL: https://issues.apache.org/jira/browse/AMQ-3436
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 5.5.0
>            Reporter: Kevin Urciolo
>            Priority: Minor
>             Fix For: 5.6.0
>
>         Attachments: AMQPriorityTest.java, OrderedPendingList.java-patch.txt, PendingList.java-patch.txt, PrioritizedPendingList.java-patch.txt, Queue.java-patch.txt
>
>
> ActiveMQ does not deliver messages in priority order when the following conditions are true:
> 1.  A consumer has prefetch set to one (or zero).
> 2.  The consumer is created (consumerSession.createConsumer) prior to message delivery
> 3.  Large maxPageSize is configured
> The fix is to modify org.apache.activemq.broker.region.Queue to use a PrioritizationPendingList for the message in "pagedInPendingDispatch" so they are dispatched in priority order.
> A test case reproducing the issue is included.
> The patched file deltas are included.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (AMQ-3436) Support Prioritization Of Messages Pending Dispatch

Posted by "Timothy Bish (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AMQ-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timothy Bish reassigned AMQ-3436:
---------------------------------

    Assignee: Timothy Bish
    
> Support Prioritization Of Messages Pending Dispatch
> ---------------------------------------------------
>
>                 Key: AMQ-3436
>                 URL: https://issues.apache.org/jira/browse/AMQ-3436
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 5.5.0
>            Reporter: Kevin Urciolo
>            Assignee: Timothy Bish
>            Priority: Minor
>             Fix For: 5.6.0
>
>         Attachments: AMQPriorityTest.java, OrderedPendingList.java-patch.txt, PendingList.java-patch.txt, PrioritizedPendingList.java-patch.txt, Queue.java-patch.txt
>
>
> ActiveMQ does not deliver messages in priority order when the following conditions are true:
> 1.  A consumer has prefetch set to one (or zero).
> 2.  The consumer is created (consumerSession.createConsumer) prior to message delivery
> 3.  Large maxPageSize is configured
> The fix is to modify org.apache.activemq.broker.region.Queue to use a PrioritizationPendingList for the message in "pagedInPendingDispatch" so they are dispatched in priority order.
> A test case reproducing the issue is included.
> The patched file deltas are included.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira