You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by "Panagiotis Garefalakis (Jira)" <ji...@apache.org> on 2020/11/05 14:39:00 UTC

[jira] [Created] (ORC-683) PPD: Make Floating point NaN check more strict

Panagiotis Garefalakis created ORC-683:
------------------------------------------

             Summary: PPD: Make Floating point NaN check more strict
                 Key: ORC-683
                 URL: https://issues.apache.org/jira/browse/ORC-683
             Project: ORC
          Issue Type: Improvement
            Reporter: Panagiotis Garefalakis
            Assignee: Panagiotis Garefalakis


#ORC-629 added an extra check (part of  RecordReaderImp) disabling PPD when DoubleColumnStats min, max or sum is a non-Finite number.

However, the check is unnecessarily broad – the way stats are updated, using just sum for the check would suffice.
https://github.com/apache/orc/blob/master/java/core/src/java/org/apache/orc/impl/ColumnStatisticsImpl.java#L568



--
This message was sent by Atlassian Jira
(v8.3.4#803005)