[jira] [Closed] (OPENNLP-495) DictionaryNameFinder only outputs Spans of type "default"

["Joern Kottmann (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OPENNLP-495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joern Kottmann closed OPENNLP-495.
----------------------------------

    
> DictionaryNameFinder only outputs Spans of type "default"
> ---------------------------------------------------------
>
>                 Key: OPENNLP-495
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-495
>             Project: OpenNLP
>          Issue Type: Improvement
>          Components: Name Finder
>    Affects Versions: tools-1.5.3
>         Environment: Ubuntu x64 Java 7 update 3
>            Reporter: Jim Piliouras
>            Assignee: Joern Kottmann
>              Labels: patch
>             Fix For: tools-1.5.3
>
>         Attachments: OPENNLP-495-2.patch, OPENNLP-495-3.patch, OPENNLP-495-4.patch, OPENNLP-495-5.patch, OPENNLP-495-6.patch, OPENNLP-495.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The DictionaryNameFinder always creates prediction Spans of type: default. Since we want to start merging results from several name-finders it makes sense to have them all output the same tag, otherwise it is impossible to properly merge the results. I mean they will be merged but half will be with default tag and some with the other user-specified tag. They can't be evaluated like that...they have to be consistent. That is very easy to fix...All i did was to create a global, mutable, String field and I am checking whether it is null before creating the Span. If it is then the usual happens (you get the default tag), if it isn't however the Span is created with whatever tag the user has supplied. In other words, a simple setter method can be used to set what tag to use in the DictionaryNameFinder Object. Of course this only works for single-type entities but then again dictionaries tend to be single-type "repositories". I am confident that you can commit this soon...all i did was add a field, a setter method for that field and an 'if statement' before creating the Span. What can possibly go wrong?
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira