[GitHub] [ranger] kumaab commented on a diff in pull request #277: RANGER-4342: Fix new log file creation every time there is an error/exception writing audits to HDFS as Json

["kumaab (via GitHub)" <gi...@apache.org>]

kumaab commented on code in PR #277:
URL: https://github.com/apache/ranger/pull/277#discussion_r1287651487


##########
agents-audit/src/main/java/org/apache/ranger/audit/utils/RangerJSONAuditWriter.java:
##########
@@ -108,16 +108,16 @@ public PrintWriter run()  throws Exception {
             // flush and check the stream for errors
             if (out.checkError()) {
                 // In theory, this count may NOT be accurate as part of the messages may have been successfully written.
-                // However, in practice, since client does buffering, either all of none would succeed.
+                // However, in practice, since client does buffer-ing, either all or none would succeed.
                 out.close();
-                closeWriter();

Review Comment:
   Makes sense, updated the review, thank you for pointing it out!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org