You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/02 06:59:44 UTC
[GitHub] [pulsar] shibd opened a new pull request #14532: Fix MLTransactionMetadataStore.update async fail
shibd opened a new pull request #14532:
URL: https://github.com/apache/pulsar/pull/14532
### Motivation
#14525
When update states is `TxnStatus.COMMITTED`, Not correctly `completableFuture.complete`.
### Modifications
- When update states is `TxnStatus.COMMITTED`, Add return to ending. Avoid direct calls `completableFuture.complete` from other logic.
### Documentation
- [x ] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shibd commented on pull request #14532: Fix MLTransactionMetadataStore.update async fail
Posted by GitBox <gi...@apache.org>.
shibd commented on pull request #14532:
URL: https://github.com/apache/pulsar/pull/14532#issuecomment-1057727179
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shibd commented on pull request #14532: Fix MLTransactionMetadataStore.update async fail
Posted by GitBox <gi...@apache.org>.
shibd commented on pull request #14532:
URL: https://github.com/apache/pulsar/pull/14532#issuecomment-1057571793
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #14532: Fix MLTransactionMetadataStore.update async fail
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #14532:
URL: https://github.com/apache/pulsar/pull/14532#issuecomment-1057815903
> I see that CI has passed.
great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shibd edited a comment on pull request #14532: Fix MLTransactionMetadataStore.update async fail
Posted by GitBox <gi...@apache.org>.
shibd edited a comment on pull request #14532:
URL: https://github.com/apache/pulsar/pull/14532#issuecomment-1057802668
> @shibd Instead of re-running checks, you will need to close and reopen this PR so that the build picks up the fix https://github.com/apache/pulsar/pull/14524 . There was a thread leak which also caused a memory leak and made the tests run extremely slow because of reduced working memory (which leads to very frequent GCs and a lot of pauses).
@lhotari Thank your reply, I see that CI has passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shibd commented on pull request #14532: Fix MLTransactionMetadataStore.update async fail
Posted by GitBox <gi...@apache.org>.
shibd commented on pull request #14532:
URL: https://github.com/apache/pulsar/pull/14532#issuecomment-1057802668
> @shibd Instead of re-running checks, you will need to close and reopen this PR so that the build picks up the fix https://github.com/apache/pulsar/pull/14524 . There was a thread leak which also caused a memory leak and made the tests run extremely slow because of reduced working memory (which leads to very frequent GCs and a lot of pauses).
Thank your reply, I see that CI has passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shibd commented on pull request #14532: Fix MLTransactionMetadataStore.update async fail
Posted by GitBox <gi...@apache.org>.
shibd commented on pull request #14532:
URL: https://github.com/apache/pulsar/pull/14532#issuecomment-1056566721
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj merged pull request #14532: Fix MLTransactionMetadataStore.update async fail
Posted by GitBox <gi...@apache.org>.
Shoothzj merged pull request #14532:
URL: https://github.com/apache/pulsar/pull/14532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #14532: Fix MLTransactionMetadataStore.update async fail
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #14532:
URL: https://github.com/apache/pulsar/pull/14532#issuecomment-1057733854
@shibd Instead of re-running checks, you will need to close and reopen this PR so that the build picks up the fix #14524 . There was a thread leak which also caused a memory leak and made the tests run extremely slow because of reduced working memory (which leads to very frequent GCs and a lot of pauses).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org