You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2014/08/26 00:57:16 UTC
Review Request 25042: Remove duplicate headers imports
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25042/
-----------------------------------------------------------
Review request for mesos, Adam B and Niklas Nielsen.
Repository: mesos-git
Description
-------
Remove duplicate headers imports
Diffs
-----
src/java/jni/org_apache_mesos_Log.cpp 05489135fbd890073c58acf55312d621c7a790e7
src/sched/sched.cpp 447b96fd88111536fdd7704abd078cc16b5c7943
src/scheduler/scheduler.cpp b7ce4de4b01a898bb6763dde070fe521e142ee6c
src/tests/zookeeper.cpp 29656eb423eaf2e72e5323eca66fd757dc7d2a37
Diff: https://reviews.apache.org/r/25042/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 25042: Remove duplicate headers imports
Posted by Niklas Nielsen <ni...@qni.dk>.
> On Sept. 12, 2014, 3:07 p.m., Niklas Nielsen wrote:
> > Cool! Going to commit this in a bit
Well, never mind - Adam already got this through. Remember to mark as submitted :)
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25042/#review53231
-----------------------------------------------------------
On Aug. 25, 2014, 3:57 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25042/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2014, 3:57 p.m.)
>
>
> Review request for mesos, Adam B and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Remove duplicate headers imports
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_Log.cpp 05489135fbd890073c58acf55312d621c7a790e7
> src/sched/sched.cpp 447b96fd88111536fdd7704abd078cc16b5c7943
> src/scheduler/scheduler.cpp b7ce4de4b01a898bb6763dde070fe521e142ee6c
> src/tests/zookeeper.cpp 29656eb423eaf2e72e5323eca66fd757dc7d2a37
>
> Diff: https://reviews.apache.org/r/25042/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 25042: Remove duplicate headers imports
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25042/#review53231
-----------------------------------------------------------
Ship it!
Cool! Going to commit this in a bit
- Niklas Nielsen
On Aug. 25, 2014, 3:57 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25042/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2014, 3:57 p.m.)
>
>
> Review request for mesos, Adam B and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Remove duplicate headers imports
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_Log.cpp 05489135fbd890073c58acf55312d621c7a790e7
> src/sched/sched.cpp 447b96fd88111536fdd7704abd078cc16b5c7943
> src/scheduler/scheduler.cpp b7ce4de4b01a898bb6763dde070fe521e142ee6c
> src/tests/zookeeper.cpp 29656eb423eaf2e72e5323eca66fd757dc7d2a37
>
> Diff: https://reviews.apache.org/r/25042/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 25042: Remove duplicate headers imports
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25042/#review51462
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On Aug. 25, 2014, 3:57 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25042/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2014, 3:57 p.m.)
>
>
> Review request for mesos, Adam B and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Remove duplicate headers imports
>
>
> Diffs
> -----
>
> src/java/jni/org_apache_mesos_Log.cpp 05489135fbd890073c58acf55312d621c7a790e7
> src/sched/sched.cpp 447b96fd88111536fdd7704abd078cc16b5c7943
> src/scheduler/scheduler.cpp b7ce4de4b01a898bb6763dde070fe521e142ee6c
> src/tests/zookeeper.cpp 29656eb423eaf2e72e5323eca66fd757dc7d2a37
>
> Diff: https://reviews.apache.org/r/25042/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>