You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "waynexia (via GitHub)" <gi...@apache.org> on 2023/03/08 08:01:22 UTC

[GitHub] [arrow-datafusion] waynexia opened a new pull request, #5514: fix: return schema of ExtensionPlan instead of its children's

waynexia opened a new pull request, #5514:
URL: https://github.com/apache/arrow-datafusion/pull/5514

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Related to #5513, but not close it as there is another unfinished discussion.
   
   # Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   #5236 returns chindren's schema rather than `ExtensionPlan`'s in `all_schema`, which will break other places that make use of `ExtensionPlan`.
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   Correct `all_schema`'s behavior
   
   # Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   # Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] jackwener commented on pull request #5514: fix: return schema of ExtensionPlan instead of its children's

Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #5514:
URL: https://github.com/apache/arrow-datafusion/pull/5514#issuecomment-1462199484

   > > Make great sense to me, thanks @waynexia .
   > > Can you add a test to cover this case? thanks again.
   > 
   > Appreciate your suggestion! I add a UT for this change, but only covers the `ExtensionPlan` branch 🥲
   
   I think we can add an extra integration-test to cover this case, look like unit test isn't enough.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] alamb commented on pull request #5514: fix: return schema of ExtensionPlan instead of its children's

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5514:
URL: https://github.com/apache/arrow-datafusion/pull/5514#issuecomment-1462433037

   Thanks @waynexia 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] waynexia commented on pull request #5514: fix: return schema of ExtensionPlan instead of its children's

Posted by "waynexia (via GitHub)" <gi...@apache.org>.
waynexia commented on PR #5514:
URL: https://github.com/apache/arrow-datafusion/pull/5514#issuecomment-1461224367

   > Make great sense to me, thanks @waynexia .
   > 
   > Can you add a test to cover this case? thanks again.
   
   Appreciate your suggestion! I add a UT for this change, but only covers the `ExtensionPlan` branch 🥲


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] jackwener commented on pull request #5514: fix: return schema of ExtensionPlan instead of its children's

Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #5514:
URL: https://github.com/apache/arrow-datafusion/pull/5514#issuecomment-1459752650

   Make great sense to me, thanks @waynexia .
   
   Can you add a test to cover this case? thanks again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] ursabot commented on pull request #5514: fix: return schema of ExtensionPlan instead of its children's

Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5514:
URL: https://github.com/apache/arrow-datafusion/pull/5514#issuecomment-1462565714

   Benchmark runs are scheduled for baseline = 55c7c4d8e9d6f64314460ba7580e36dbce140594 and contender = 6a8c4a60114c7132de6d2fcd6d44111cf40b3df9. 6a8c4a60114c7132de6d2fcd6d44111cf40b3df9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/4e1b451ab366428cb982e977577a7335...3b3e1f34476b464ab8063596c8ddba04/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/c053f212835c44a5aec8d8cee67cd2d5...71bae56e7d2b4bbd86d23726862cade9/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/8b1df4c910174688b66f955067cd878f...af391a3b271b4824bb3d806dd8cdb929/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/896c0f76b2e14b55919ad34bb59ba40d...9753355704764657b8601c9645ae3a38/)
   Buildkite builds:
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] alamb merged pull request #5514: fix: return schema of ExtensionPlan instead of its children's

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5514:
URL: https://github.com/apache/arrow-datafusion/pull/5514


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org