[GitHub] spark pull request #22897: [SPARK-25875][k8s] Merge code to set up driver co...

[mccheah <gi...@git.apache.org>]

Github user mccheah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22897#discussion_r230119272
  
    --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverCommandFeatureStep.scala ---
    @@ -0,0 +1,137 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.deploy.k8s.features
    +
    +import scala.collection.JavaConverters._
    +
    +import io.fabric8.kubernetes.api.model.{ContainerBuilder, EnvVarBuilder}
    +
    +import org.apache.spark.deploy.k8s._
    +import org.apache.spark.deploy.k8s.Config._
    +import org.apache.spark.deploy.k8s.Constants._
    +import org.apache.spark.deploy.k8s.submit._
    +import org.apache.spark.internal.config._
    +import org.apache.spark.launcher.SparkLauncher
    +import org.apache.spark.util.Utils
    +
    +/**
    + * Creates the driver command for running the user app, and propagates needed configuration so
    + * executors can also find the app code.
    + */
    +private[spark] class DriverCommandFeatureStep(conf: KubernetesConf[KubernetesDriverSpecificConf])
    +  extends KubernetesFeatureConfigStep {
    +
    +  private val driverConf = conf.roleSpecificConf
    +
    +  override def configurePod(pod: SparkPod): SparkPod = {
    +    driverConf.mainAppResource match {
    +      case Some(JavaMainAppResource(_)) | None =>
    --- End diff --
    
    Again - don't match on options, use the option functional primitives.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org