You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rayees Namathponnan <ra...@citrix.com> on 2013/06/18 01:43:22 UTC
Review Request: Update test case and framework to add test name in account
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11921/
-----------------------------------------------------------
Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.
Description
-------
During test cases analysis, its hard to find account name created for which test case, so we need to add test case as part of account
Diffs
-----
Diff: https://reviews.apache.org/r/11921/diff/
Testing
-------
Tested
Thanks,
Rayees Namathponnan
Re: Review Request: Update test case and framework to add test name in
account
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11921/#review22045
-----------------------------------------------------------
Also - can you upload your diff as opposed to attach a file in reviewboard? It makes it easier to review the diff line by line. Thanks
- Prasanna Santhanam
On June 18, 2013, 4:28 a.m., Rayees Namathponnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11921/
> -----------------------------------------------------------
>
> (Updated June 18, 2013, 4:28 a.m.)
>
>
> Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.
>
>
> Description
> -------
>
> During test cases analysis, its hard to find account name created for which test case, so we need to add test case as part of account
>
>
> Diffs
> -----
>
>
> Diff: https://reviews.apache.org/r/11921/diff/
>
>
> Testing
> -------
>
> Tested
>
>
> Thanks,
>
> Rayees Namathponnan
>
>
Re: Review Request: Update test case and framework to add test name in
account
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11921/#review22044
-----------------------------------------------------------
We shouldn't depend on the test case author to include the 'testname' key in the data dict . The change should happen within the logger of cloudstack and in marvin's integration.lib.utils:random_gen(). It's the random_gen method that adds prefixes to accountnames, networknames etc.
- Prasanna Santhanam
On June 18, 2013, 4:28 a.m., Rayees Namathponnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11921/
> -----------------------------------------------------------
>
> (Updated June 18, 2013, 4:28 a.m.)
>
>
> Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.
>
>
> Description
> -------
>
> During test cases analysis, its hard to find account name created for which test case, so we need to add test case as part of account
>
>
> Diffs
> -----
>
>
> Diff: https://reviews.apache.org/r/11921/diff/
>
>
> Testing
> -------
>
> Tested
>
>
> Thanks,
>
> Rayees Namathponnan
>
>
Re: Review Request: Update test case and framework to add test name in
account
Posted by Rayees Namathponnan <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11921/
-----------------------------------------------------------
(Updated June 18, 2013, 4:28 a.m.)
Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.
Description
-------
During test cases analysis, its hard to find account name created for which test case, so we need to add test case as part of account
Diffs
-----
Diff: https://reviews.apache.org/r/11921/diff/
Testing
-------
Tested
Thanks,
Rayees Namathponnan
Re: Review Request: Update test case and framework to add test name in
account
Posted by Rayees Namathponnan <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11921/
-----------------------------------------------------------
(Updated June 18, 2013, 12:04 a.m.)
Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.
Description
-------
During test cases analysis, its hard to find account name created for which test case, so we need to add test case as part of account
Diffs
-----
Diff: https://reviews.apache.org/r/11921/diff/
Testing
-------
Tested
Thanks,
Rayees Namathponnan
Re: Review Request: Update test case and framework to add test name in
account
Posted by Rayees Namathponnan <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11921/
-----------------------------------------------------------
(Updated June 17, 2013, 11:43 p.m.)
Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.
Description
-------
During test cases analysis, its hard to find account name created for which test case, so we need to add test case as part of account
Diffs
-----
Diff: https://reviews.apache.org/r/11921/diff/
Testing
-------
Tested
Thanks,
Rayees Namathponnan