Re: api cleanup for UIXCollection

[Arjuna Wijeyekoon <ar...@gmail.com>]

Matthias,

I forgot to deprecate the
UIXCollection.clearCurrencyStringCache()
method.

I also forgot to add javadoc to the
UIXCollection.getClientRowKeyManager()
method.

I have uploaded an additional patch to address these issues.
Can you please commit it?
thanks!
Arjuna
http://issues.apache.org/jira/browse/ADFFACES-270



On 10/30/06, Matthias Wessendorf <ma...@apache.org> wrote:
> just saw that.
>
> thx!
>
> On 10/29/06, Arjuna Wijeyekoon <ar...@gmail.com> wrote:
> > uploaded a patch
> > http://issues.apache.org/jira/browse/ADFFACES-270
> >
> > On 10/25/06, Simon Lessard <si...@gmail.com> wrote:
> > >
> > > +1 as well, when I first saw that method I thought about money.
> > >
> > > On 10/25/06, Adam Winer <aw...@gmail.com> wrote:
> > > >
> > > > +1 for me - I've always found the word "currency" to be
> > > > incredibly confusing.
> > > >
> > > > -- Adam
> > > >
> > > >
> > > > On 10/24/06, Arjuna Wijeyekoon <ar...@gmail.com> wrote:
> > > > > Hi,
> > > > > Currently UIXCollection has the following methods:
> > > > >   public String getCurrencyString()
> > > > >   public void setCurrencyString(String currency)
> > > > >   protected void clearCurrencyStringCache()
> > > > >
> > > > >
> > > > > Now that issue 210 (http://issues.apache.org/jira/browse/ADFFACES-210)
> > > > has
> > > > > been implemented
> > > > > and we have a ClientRowKeyManager class that handles the
> > > > > object-rowkey->string-key mapping, I'd like to propose the following
> > > > > changes:
> > > > > 1. rename get/setCurrentString to get/setClientRowKey
> > > > > 2. remove the clearCurrencyStringCache method (ie: make it
> > > > package-private).
> > > > >
> > > > > what do you think?
> > > > >
> > > > > If we do decide to implement these changes, I'd like to do them in two
> > > > > parts:
> > > > > 1. first add the new methods and deprecate the old ones.
> > > > > 2. give a few days for dependent projects to upgrade and then remove
> > > the
> > > > old
> > > > > deprecated methods.
> > > > >
> > > > > is that ok?
> > > > >
> > > > > thanks
> > > > > Arjuna
> > > > >
> > > > >
> > > >
> > >
> > >
> >
> >
>
>
> --
> Matthias Wessendorf
> http://tinyurl.com/fmywh
>
> further stuff:
> blog: http://jroller.com/page/mwessendorf
> mail: mwessendorf-at-gmail-dot-com
>