You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "hehuiyuan (via GitHub)" <gi...@apache.org> on 2023/08/30 02:16:02 UTC
[GitHub] [incubator-paimon] hehuiyuan opened a new pull request, #1839: [HIVE]Support read hadoop/hive conf from system environment
hehuiyuan opened a new pull request, #1839:
URL: https://github.com/apache/incubator-paimon/pull/1839
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
Support read hadoop/hive conf from system environment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] hehuiyuan commented on pull request #1839: [HIVE]Support read hadoop/hive conf from system environment
Posted by "hehuiyuan (via GitHub)" <gi...@apache.org>.
hehuiyuan commented on PR #1839:
URL: https://github.com/apache/incubator-paimon/pull/1839#issuecomment-1687979139
Hi @JingsongLi , take a look when you have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] hehuiyuan commented on pull request #1839: [HIVE]Support read hadoop/hive conf from system environment
Posted by "hehuiyuan (via GitHub)" <gi...@apache.org>.
hehuiyuan commented on PR #1839:
URL: https://github.com/apache/incubator-paimon/pull/1839#issuecomment-1696830754
There are some paimon-spark-common error. Try to merge master to current branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] Alibaba-HZY commented on pull request #1839: [HIVE]Support read hadoop/hive conf from system environment
Posted by "Alibaba-HZY (via GitHub)" <gi...@apache.org>.
Alibaba-HZY commented on PR #1839:
URL: https://github.com/apache/incubator-paimon/pull/1839#issuecomment-1691027329
> Hi @JingsongLi , take a look when you have time.
i think you need to add doc describing the conf loading order,and test for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] hehuiyuan commented on pull request #1839: [HIVE]Support read hadoop/hive conf from system environment
Posted by "hehuiyuan (via GitHub)" <gi...@apache.org>.
hehuiyuan commented on PR #1839:
URL: https://github.com/apache/incubator-paimon/pull/1839#issuecomment-1702261318
Testing triggered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] hehuiyuan commented on pull request #1839: [HIVE]Support read hadoop/hive conf from system environment
Posted by "hehuiyuan (via GitHub)" <gi...@apache.org>.
hehuiyuan commented on PR #1839:
URL: https://github.com/apache/incubator-paimon/pull/1839#issuecomment-1704807764
Hi @JingsongLi ,would you trigger test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi closed pull request #1839: [HIVE]Support read hadoop/hive conf from system environment
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi closed pull request #1839: [HIVE]Support read hadoop/hive conf from system environment
URL: https://github.com/apache/incubator-paimon/pull/1839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] hehuiyuan commented on pull request #1839: [HIVE]Support read hadoop/hive conf from system environment
Posted by "hehuiyuan (via GitHub)" <gi...@apache.org>.
hehuiyuan commented on PR #1839:
URL: https://github.com/apache/incubator-paimon/pull/1839#issuecomment-1702197419
Error: Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.319 s <<< FAILURE! - in org.apache.paimon.docs.configuration.ConfigOptionsDocsCompletenessITCase
Error: org.apache.paimon.docs.configuration.ConfigOptionsDocsCompletenessITCase.testCompleteness Time elapsed: 0.298 s <<< FAILURE!
java.lang.AssertionError:
Documentation is outdated, please regenerate it according to the instructions in paimon-docs/README.md.
Problems:
Documentation of hadoop-conf-dir in HiveCatalogOptions is outdated. Expected: default=((none)) description=(File directory of the core-site.xml、hdfs-site.xml、yarn-site.xml、mapred-site.xml. Currently, only local file system paths are supported.
If not configured, try to load from 'HADOOP_CONF_DIR' or 'HADOOP_HOME' system environment.
Configure Priority: 1.from 'hadoop-conf-dir' 2.from HADOOP_CONF_DIR 3.from HADOOP_HOME/conf 4.HADOOP_HOME/etc/hadoop.).
Documentation of hive-conf-dir in HiveCatalogOptions is outdated. Expected: default=((none)) description=(File directory of the hive-site.xml , used to create HiveMetastoreClient and security authentication, such as Kerberos, LDAP, Ranger and so on.
If not configured, try to load from 'HIVE_CONF_DIR' env.).
Documented option hadoop-conf-dir does not exist.
Documented option hive-conf-dir does not exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi merged pull request #1839: [HIVE]Support read hadoop/hive conf from system environment
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #1839:
URL: https://github.com/apache/incubator-paimon/pull/1839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi commented on pull request #1839: [HIVE]Support read hadoop/hive conf from system environment
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #1839:
URL: https://github.com/apache/incubator-paimon/pull/1839#issuecomment-1694938064
Testing triggered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] hehuiyuan commented on pull request #1839: [HIVE]Support read hadoop/hive conf from system environment
Posted by "hehuiyuan (via GitHub)" <gi...@apache.org>.
hehuiyuan commented on PR #1839:
URL: https://github.com/apache/incubator-paimon/pull/1839#issuecomment-1697145377
Testing triggered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] hehuiyuan commented on pull request #1839: [HIVE]Support read hadoop/hive conf from system environment
Posted by "hehuiyuan (via GitHub)" <gi...@apache.org>.
hehuiyuan commented on PR #1839:
URL: https://github.com/apache/incubator-paimon/pull/1839#issuecomment-1698887086
doc error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] hehuiyuan commented on pull request #1839: [HIVE]Support read hadoop/hive conf from system environment
Posted by "hehuiyuan (via GitHub)" <gi...@apache.org>.
hehuiyuan commented on PR #1839:
URL: https://github.com/apache/incubator-paimon/pull/1839#issuecomment-1698973139
Testing triggered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] hehuiyuan commented on pull request #1839: [HIVE]Support read hadoop/hive conf from system environment
Posted by "hehuiyuan (via GitHub)" <gi...@apache.org>.
hehuiyuan commented on PR #1839:
URL: https://github.com/apache/incubator-paimon/pull/1839#issuecomment-1707834178
Hi @JingsongLi , the test class
> Hi @JingsongLi ,
>
> ```java
> Error: Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.319 s <<< FAILURE! - in org.apache.paimon.docs.configuration.ConfigOptionsDocsCompletenessITCase
> Error: org.apache.paimon.docs.configuration.ConfigOptionsDocsCompletenessITCase.testCompleteness Time elapsed: 0.298 s <<< FAILURE!
> java.lang.AssertionError:
> Documentation is outdated, please regenerate it according to the instructions in paimon-docs/README.md.
> Problems:
> Documentation of hadoop-conf-dir in HiveCatalogOptions is outdated. Expected: default=((none)) description=(File directory of the core-site.xml、hdfs-site.xml、yarn-site.xml、mapred-site.xml. Currently, only local file system paths are supported.
> If not configured, try to load from 'HADOOP_CONF_DIR' or 'HADOOP_HOME' system environment.
> Configure Priority: 1.from 'hadoop-conf-dir' 2.from HADOOP_CONF_DIR 3.from HADOOP_HOME/conf 4.HADOOP_HOME/etc/hadoop.).
> Documentation of hive-conf-dir in HiveCatalogOptions is outdated. Expected: default=((none)) description=(File directory of the hive-site.xml , used to create HiveMetastoreClient and security authentication, such as Kerberos, LDAP, Ranger and so on.
> If not configured, try to load from 'HIVE_CONF_DIR' env.).
> Documented option hadoop-conf-dir does not exist.
> Documented option hive-conf-dir does not exist.
> ```
>
> The error has ambiguity, when both document and ConfigOption exist, but the description or default value are not same.
>
> ```
> Documented option hadoop-conf-dir does not exist.
> Documented option hive-conf-dir does not exist.
> ```
>
> Is it feasible to add the following code?
>
> ConfigOptionsDocsCompletenessITCase.compareDocumentedAndExistingOptions 
>
> Test result: 
Hi @JingsongLi , does this need further improment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] hehuiyuan commented on pull request #1839: [HIVE]Support read hadoop/hive conf from system environment
Posted by "hehuiyuan (via GitHub)" <gi...@apache.org>.
hehuiyuan commented on PR #1839:
URL: https://github.com/apache/incubator-paimon/pull/1839#issuecomment-1695407500
> Testing triggered.
Add some test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] hehuiyuan commented on pull request #1839: [HIVE]Support read hadoop/hive conf from system environment
Posted by "hehuiyuan (via GitHub)" <gi...@apache.org>.
hehuiyuan commented on PR #1839:
URL: https://github.com/apache/incubator-paimon/pull/1839#issuecomment-1695406600
Testing triggered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] hehuiyuan commented on pull request #1839: [HIVE]Support read hadoop/hive conf from system environment
Posted by "hehuiyuan (via GitHub)" <gi...@apache.org>.
hehuiyuan commented on PR #1839:
URL: https://github.com/apache/incubator-paimon/pull/1839#issuecomment-1695007762
> Testing triggered.
Add some test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org