You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org> on 2009/08/11 16:34:14 UTC

[jira] Created: (QPID-2041) failed update to the Base64MD5PasswordFilePrincipalDatabase on disk may go unnoticed, preventing broker restart

failed update to the Base64MD5PasswordFilePrincipalDatabase on disk may go unnoticed, preventing broker restart
---------------------------------------------------------------------------------------------------------------

                 Key: QPID-2041
                 URL: https://issues.apache.org/jira/browse/QPID-2041
             Project: Qpid
          Issue Type: Bug
    Affects Versions: M4, M3, 0.5
            Reporter: Robbie Gemmell
            Assignee: Robbie Gemmell
            Priority: Critical
             Fix For: 0.6


failed update to the MD5PasswordFilePrincipalDatabase on disk may go unnoticed, preventing broker restart

Certain use of the File.renameTo() function is not accompanied by a check of the boolean result, meaning a failed rename can leave the file in the wrong location, but the cached nature of the Base64MD5PasswordFilePrincipalDatabase masks the failure until another operation is attempted upon it that needs the output of the previously failed update.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Resolved: (QPID-2041) failed update to the Base64MD5PasswordFilePrincipalDatabase on disk may go unnoticed, preventing broker restart

Posted by "Marnie McCormack (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marnie McCormack resolved QPID-2041.
------------------------------------

    Resolution: Fixed

Reviewed changes, as per similar changes to use of random rather than tmp location for file writes during update. Looks fine to me. 

> failed update to the Base64MD5PasswordFilePrincipalDatabase on disk may go unnoticed, preventing broker restart
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-2041
>                 URL: https://issues.apache.org/jira/browse/QPID-2041
>             Project: Qpid
>          Issue Type: Bug
>    Affects Versions: M3, M4, 0.5
>            Reporter: Robbie Gemmell
>            Assignee: Martin Ritchie
>            Priority: Critical
>             Fix For: 0.6
>
>
> failed update to the MD5PasswordFilePrincipalDatabase on disk may go unnoticed, preventing broker restart
> Certain use of the File.renameTo() function is not accompanied by a check of the boolean result, meaning a failed rename can leave the file in the wrong location, but the cached nature of the Base64MD5PasswordFilePrincipalDatabase masks the failure until another operation is attempted upon it that needs the output of the previously failed update. This has been observed in a situation where the OS Temp dir is on one (local) file system, and the broker configuration is on another (remote NFS) filesystem, which caused the rename to fail unnoticed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2041) failed update to the Base64MD5PasswordFilePrincipalDatabase on disk may go unnoticed, preventing broker restart

Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell updated QPID-2041:
---------------------------------

    Description: 
failed update to the MD5PasswordFilePrincipalDatabase on disk may go unnoticed, preventing broker restart

Certain use of the File.renameTo() function is not accompanied by a check of the boolean result, meaning a failed rename can leave the file in the wrong location, but the cached nature of the Base64MD5PasswordFilePrincipalDatabase masks the failure until another operation is attempted upon it that needs the output of the previously failed update. This has been observed in a situation where the OS Temp dir is on one file system, and the broker configuration is on another, which caused the rename to fail unnoticed.

  was:
failed update to the MD5PasswordFilePrincipalDatabase on disk may go unnoticed, preventing broker restart

Certain use of the File.renameTo() function is not accompanied by a check of the boolean result, meaning a failed rename can leave the file in the wrong location, but the cached nature of the Base64MD5PasswordFilePrincipalDatabase masks the failure until another operation is attempted upon it that needs the output of the previously failed update.


> failed update to the Base64MD5PasswordFilePrincipalDatabase on disk may go unnoticed, preventing broker restart
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-2041
>                 URL: https://issues.apache.org/jira/browse/QPID-2041
>             Project: Qpid
>          Issue Type: Bug
>    Affects Versions: M3, M4, 0.5
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>            Priority: Critical
>             Fix For: 0.6
>
>
> failed update to the MD5PasswordFilePrincipalDatabase on disk may go unnoticed, preventing broker restart
> Certain use of the File.renameTo() function is not accompanied by a check of the boolean result, meaning a failed rename can leave the file in the wrong location, but the cached nature of the Base64MD5PasswordFilePrincipalDatabase masks the failure until another operation is attempted upon it that needs the output of the previously failed update. This has been observed in a situation where the OS Temp dir is on one file system, and the broker configuration is on another, which caused the rename to fail unnoticed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2041) failed update to the Base64MD5PasswordFilePrincipalDatabase on disk may go unnoticed, preventing broker restart

Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell updated QPID-2041:
---------------------------------

    Status: Ready To Review  (was: In Progress)

> failed update to the Base64MD5PasswordFilePrincipalDatabase on disk may go unnoticed, preventing broker restart
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-2041
>                 URL: https://issues.apache.org/jira/browse/QPID-2041
>             Project: Qpid
>          Issue Type: Bug
>    Affects Versions: M3, M4, 0.5
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>            Priority: Critical
>             Fix For: 0.6
>
>
> failed update to the MD5PasswordFilePrincipalDatabase on disk may go unnoticed, preventing broker restart
> Certain use of the File.renameTo() function is not accompanied by a check of the boolean result, meaning a failed rename can leave the file in the wrong location, but the cached nature of the Base64MD5PasswordFilePrincipalDatabase masks the failure until another operation is attempted upon it that needs the output of the previously failed update. This has been observed in a situation where the OS Temp dir is on one (local) file system, and the broker configuration is on another (remote NFS) filesystem, which caused the rename to fail unnoticed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Assigned: (QPID-2041) failed update to the Base64MD5PasswordFilePrincipalDatabase on disk may go unnoticed, preventing broker restart

Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell reassigned QPID-2041:
------------------------------------

    Assignee: Robbie Gemmell  (was: Aidan Skinner)

> failed update to the Base64MD5PasswordFilePrincipalDatabase on disk may go unnoticed, preventing broker restart
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-2041
>                 URL: https://issues.apache.org/jira/browse/QPID-2041
>             Project: Qpid
>          Issue Type: Bug
>    Affects Versions: M3, M4, 0.5
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>            Priority: Critical
>             Fix For: 0.6
>
>
> failed update to the MD5PasswordFilePrincipalDatabase on disk may go unnoticed, preventing broker restart
> Certain use of the File.renameTo() function is not accompanied by a check of the boolean result, meaning a failed rename can leave the file in the wrong location, but the cached nature of the Base64MD5PasswordFilePrincipalDatabase masks the failure until another operation is attempted upon it that needs the output of the previously failed update. This has been observed in a situation where the OS Temp dir is on one (local) file system, and the broker configuration is on another (remote NFS) filesystem, which caused the rename to fail unnoticed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Assigned: (QPID-2041) failed update to the Base64MD5PasswordFilePrincipalDatabase on disk may go unnoticed, preventing broker restart

Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell reassigned QPID-2041:
------------------------------------

    Assignee: Aidan Skinner  (was: Robbie Gemmell)

Hi Aidan, can you review this change please, thanks.

> failed update to the Base64MD5PasswordFilePrincipalDatabase on disk may go unnoticed, preventing broker restart
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-2041
>                 URL: https://issues.apache.org/jira/browse/QPID-2041
>             Project: Qpid
>          Issue Type: Bug
>    Affects Versions: M3, M4, 0.5
>            Reporter: Robbie Gemmell
>            Assignee: Aidan Skinner
>            Priority: Critical
>             Fix For: 0.6
>
>
> failed update to the MD5PasswordFilePrincipalDatabase on disk may go unnoticed, preventing broker restart
> Certain use of the File.renameTo() function is not accompanied by a check of the boolean result, meaning a failed rename can leave the file in the wrong location, but the cached nature of the Base64MD5PasswordFilePrincipalDatabase masks the failure until another operation is attempted upon it that needs the output of the previously failed update. This has been observed in a situation where the OS Temp dir is on one (local) file system, and the broker configuration is on another (remote NFS) filesystem, which caused the rename to fail unnoticed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2041) failed update to the Base64MD5PasswordFilePrincipalDatabase on disk may go unnoticed, preventing broker restart

Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell updated QPID-2041:
---------------------------------

    Description: 
failed update to the MD5PasswordFilePrincipalDatabase on disk may go unnoticed, preventing broker restart

Certain use of the File.renameTo() function is not accompanied by a check of the boolean result, meaning a failed rename can leave the file in the wrong location, but the cached nature of the Base64MD5PasswordFilePrincipalDatabase masks the failure until another operation is attempted upon it that needs the output of the previously failed update. This has been observed in a situation where the OS Temp dir is on one (local) file system, and the broker configuration is on another (remote NFS) filesystem, which caused the rename to fail unnoticed.

  was:
failed update to the MD5PasswordFilePrincipalDatabase on disk may go unnoticed, preventing broker restart

Certain use of the File.renameTo() function is not accompanied by a check of the boolean result, meaning a failed rename can leave the file in the wrong location, but the cached nature of the Base64MD5PasswordFilePrincipalDatabase masks the failure until another operation is attempted upon it that needs the output of the previously failed update. This has been observed in a situation where the OS Temp dir is on one file system, and the broker configuration is on another, which caused the rename to fail unnoticed.


> failed update to the Base64MD5PasswordFilePrincipalDatabase on disk may go unnoticed, preventing broker restart
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-2041
>                 URL: https://issues.apache.org/jira/browse/QPID-2041
>             Project: Qpid
>          Issue Type: Bug
>    Affects Versions: M3, M4, 0.5
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>            Priority: Critical
>             Fix For: 0.6
>
>
> failed update to the MD5PasswordFilePrincipalDatabase on disk may go unnoticed, preventing broker restart
> Certain use of the File.renameTo() function is not accompanied by a check of the boolean result, meaning a failed rename can leave the file in the wrong location, but the cached nature of the Base64MD5PasswordFilePrincipalDatabase masks the failure until another operation is attempted upon it that needs the output of the previously failed update. This has been observed in a situation where the OS Temp dir is on one (local) file system, and the broker configuration is on another (remote NFS) filesystem, which caused the rename to fail unnoticed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org