You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by "anmolnar (via GitHub)" <gi...@apache.org> on 2026/04/27 16:17:32 UTC
[PR] ZOOKEEPER-5042: Enhance documentation of X-Forwarded-For setting in IPAuthenticationProvider [zookeeper]
anmolnar opened a new pull request, #2378:
URL: https://github.com/apache/zookeeper/pull/2378
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-5042: Enhance X-Forwarded-For setting in IPAuthenticationProvider [zookeeper]
Posted by "phunt (via GitHub)" <gi...@apache.org>.
phunt commented on code in PR #2378:
URL: https://github.com/apache/zookeeper/pull/2378#discussion_r3269757798
##########
zookeeper-server/src/test/java/org/apache/zookeeper/server/auth/IPAuthenticationProviderTest.java:
##########
@@ -91,7 +91,7 @@ public void testGetClientIPAddressWithXForwardedFor() {
String clientIp = IPAuthenticationProvider.getClientIPAddress(request);
// Assert
- assertEquals("192.168.1.2", clientIp);
+ assertEquals("192.168.1.4", clientIp);
Review Comment:
why did this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-5042: Enhance X-Forwarded-For setting in IPAuthenticationProvider [zookeeper]
Posted by "anmolnar (via GitHub)" <gi...@apache.org>.
anmolnar merged PR #2378:
URL: https://github.com/apache/zookeeper/pull/2378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-5042: Enhance X-Forwarded-For setting in IPAuthenticationProvider [zookeeper]
Posted by "anmolnar (via GitHub)" <gi...@apache.org>.
anmolnar commented on PR #2378:
URL: https://github.com/apache/zookeeper/pull/2378#issuecomment-4423147759
@eolivelli @phunt @ztzg PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-5042: Enhance X-Forwarded-For setting in IPAuthenticationProvider [zookeeper]
Posted by "phunt (via GitHub)" <gi...@apache.org>.
phunt commented on PR #2378:
URL: https://github.com/apache/zookeeper/pull/2378#issuecomment-4492205360
+1 sgtm - minor nit comment on the test but otw a good improvement. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-5042: Enhance X-Forwarded-For setting in IPAuthenticationProvider [zookeeper]
Posted by "anmolnar (via GitHub)" <gi...@apache.org>.
anmolnar commented on code in PR #2378:
URL: https://github.com/apache/zookeeper/pull/2378#discussion_r3270553830
##########
zookeeper-server/src/test/java/org/apache/zookeeper/server/auth/IPAuthenticationProviderTest.java:
##########
@@ -91,7 +91,7 @@ public void testGetClientIPAddressWithXForwardedFor() {
String clientIp = IPAuthenticationProvider.getClientIPAddress(request);
// Assert
- assertEquals("192.168.1.2", clientIp);
+ assertEquals("192.168.1.4", clientIp);
Review Comment:
Because of the code change. Now we pick the rightmost IP address from the given list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org