You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2020/06/23 16:16:57 UTC
[GitHub] [incubator-livy] coheigea opened a new pull request #299: LIVY-776 - Update Maven Shade Plugin to 3.2.1
coheigea opened a new pull request #299:
URL: https://github.com/apache/incubator-livy/pull/299
In order to apply the PR to update Jackson to 2.10.1 (https://github.com/apache/incubator-livy/pull/258/files), it is also necessary to update the Maven Shade Plugin to avoid an ASM IllegalArgumentException error in the client-http module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-livy] coheigea commented on pull request #299: LIVY-776 - Update Maven Shade Plugin to 3.2.1
Posted by GitBox <gi...@apache.org>.
coheigea commented on pull request #299:
URL: https://github.com/apache/incubator-livy/pull/299#issuecomment-648887533
@tprelle It's up to the maintainers of the project, either it could all be done in one go (as in your PR), or maybe they might prefer to just update Jackson separately. If your PR is merged first, then I'll just close this PR. Either way it would be good from my POV to get us updated to Jackson 2.10.x ;-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-livy] jerryshao commented on pull request #299: LIVY-776 - Update Maven Shade Plugin to 3.2.1
Posted by GitBox <gi...@apache.org>.
jerryshao commented on pull request #299:
URL: https://github.com/apache/incubator-livy/pull/299#issuecomment-652848737
Fixed in #300
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-livy] tprelle commented on pull request #299: LIVY-776 - Update Maven Shade Plugin to 3.2.1
Posted by GitBox <gi...@apache.org>.
tprelle commented on pull request #299:
URL: https://github.com/apache/incubator-livy/pull/299#issuecomment-648874686
Hi @coheigea I faced the same issue (shaded plugin and jackson version) on https://github.com/apache/incubator-livy/pull/289 for scala 2.12 and spark 3 support. I need also to change this. I do not know how deal with multiple PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-livy] jerryshao closed pull request #299: LIVY-776 - Update Maven Shade Plugin to 3.2.1
Posted by GitBox <gi...@apache.org>.
jerryshao closed pull request #299:
URL: https://github.com/apache/incubator-livy/pull/299
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-livy] jerryshao edited a comment on pull request #299: LIVY-776 - Update Maven Shade Plugin to 3.2.1
Posted by GitBox <gi...@apache.org>.
jerryshao edited a comment on pull request #299:
URL: https://github.com/apache/incubator-livy/pull/299#issuecomment-652848737
Fixed in #300 , thanks a lot for the contribution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org