You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/12 19:28:51 UTC

[GitHub] [incubator-nuttx] leomar95 opened a new pull request #1574: New features for samd5e5 and metro-m4

leomar95 opened a new pull request #1574:
URL: https://github.com/apache/incubator-nuttx/pull/1574


   ## Summary
   arch: samd5e5
   - Add USB host support.
   - Fixes in USB device and i2c.
   
   boards: metro-m4  Add support for:
   
   - vfat auto-mounted on a flash drive;
   - i2c inicialization;
   - usb-dev cdc;
   - sam_usbhost_vbusdrive needs your VBUS implementation.
   
   ## Impact
   New features available for samd5e5.
   
   ## Testing
   - Build check only.
   
   Signed-off-by: Leomar Mateus Radke  <le...@falker.com.br>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] johannes-nivus commented on pull request #1574: New features for samd5e5 and metro-m4

Posted by GitBox <gi...@apache.org>.
johannes-nivus commented on pull request #1574:
URL: https://github.com/apache/incubator-nuttx/pull/1574#issuecomment-673073430


   Just a hint:
   Some days ago I introduced USB mass storage class state change notifier. PR #1531
   I also implemented an automounter based on this for Kinetis Freedom K28.
   I have this running with Hub support and can e.g. mount and unmount 3 USB sticks and enumerate another FTDI cable without affecting the automounter.
   Perhaps you'd like to have a look. 
   Johannes 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] acassis commented on pull request #1574: New features for samd5e5 and metro-m4

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #1574:
URL: https://github.com/apache/incubator-nuttx/pull/1574#issuecomment-673093899


   It appears your branch is not up-to-dated:
   "Rebasing the commits of this branch on top of the base branch cannot be performed automatically due to conflicts encountered while reapplying the individual commits from the head branch."


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] johannes-nivus edited a comment on pull request #1574: New features for samd5e5 and metro-m4

Posted by GitBox <gi...@apache.org>.
johannes-nivus edited a comment on pull request #1574:
URL: https://github.com/apache/incubator-nuttx/pull/1574#issuecomment-673073430


   Just a hint:
   Some days ago I introduced USB mass storage class state change notifier. PR #1531
   I also implemented an automounter based on this for Kinetis Freedom K28, which is also part of the PR.
   I have this running with Hub support and can e.g. mount and unmount 3 USB sticks and enumerate another FTDI cable without affecting the automounter.
   Perhaps you'd like to have a look. 
   Johannes 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] acassis commented on pull request #1574: New features for samd5e5 and metro-m4

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #1574:
URL: https://github.com/apache/incubator-nuttx/pull/1574#issuecomment-673093311


   Hi Leomar, I will merge these patches, but please consider the idea of assigning the Apache's ICLA and submitting code under Apache license.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] acassis merged pull request #1574: New features for samd5e5 and metro-m4

Posted by GitBox <gi...@apache.org>.
acassis merged pull request #1574:
URL: https://github.com/apache/incubator-nuttx/pull/1574


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] leomar95 commented on pull request #1574: New features for samd5e5 and metro-m4

Posted by GitBox <gi...@apache.org>.
leomar95 commented on pull request #1574:
URL: https://github.com/apache/incubator-nuttx/pull/1574#issuecomment-673125348


   Hi @acassis, i did the merge, but there are still conflicts. I don't understand the error. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] leomar95 commented on pull request #1574: New features for samd5e5 and metro-m4

Posted by GitBox <gi...@apache.org>.
leomar95 commented on pull request #1574:
URL: https://github.com/apache/incubator-nuttx/pull/1574#issuecomment-673085577


   @johannes-nivus thanks for your hint, i hadn't seen your PR #1531 before the pull-request. #1574 worked for me, but I'll consider your ideas in Freedom K28 the for next commits.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org