You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/11/20 21:00:58 UTC
Review Request 15724: Exposed FrameworkInfo in state.json.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15724/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-824
https://issues.apache.org/jira/browse/MESOS-824
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/master/http.cpp 218906a0c1f056faa30213e10f2f7762b518ecc8
src/slave/http.cpp 2f0bd8d63cdd3fce4e0fb401e818f828baf1447e
Diff: https://reviews.apache.org/r/15724/diff/
Testing
-------
Tested locally by hitting the endpoints.
Thanks,
Vinod Kone
Re: Review Request 15724: Exposed FrameworkInfo in state.json.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15724/#review29931
-----------------------------------------------------------
Did you want this to display on the Framework page? You can assign me a task after this is merged to add the info.
- Ross Allen
On Nov. 20, 2013, 8:01 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15724/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2013, 8:01 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Ross Allen.
>
>
> Bugs: MESOS-824
> https://issues.apache.org/jira/browse/MESOS-824
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/http.cpp 218906a0c1f056faa30213e10f2f7762b518ecc8
> src/slave/http.cpp 2f0bd8d63cdd3fce4e0fb401e818f828baf1447e
>
> Diff: https://reviews.apache.org/r/15724/diff/
>
>
> Testing
> -------
>
> Tested locally by hitting the endpoints.
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 15724: Exposed FrameworkInfo in state.json.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15724/#review31207
-----------------------------------------------------------
Ship it!
Ship It!
- Niklas Nielsen
On Jan. 2, 2014, 9:39 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15724/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2014, 9:39 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Ross Allen.
>
>
> Bugs: MESOS-824
> https://issues.apache.org/jira/browse/MESOS-824
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/http.cpp d7cd89f0a3446f4c2e65ecd259544149bf92faf8
> src/slave/http.cpp 1358810cde91fc64d190196e0a7675fa30d8f106
>
> Diff: https://reviews.apache.org/r/15724/diff/
>
>
> Testing
> -------
>
> Tested locally by hitting the endpoints.
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 15724: Exposed FrameworkInfo in state.json.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15724/
-----------------------------------------------------------
(Updated Jan. 2, 2014, 9:39 p.m.)
Review request for mesos, Ben Mahler, Niklas Nielsen, and Ross Allen.
Changes
-------
rebased.
also added new keys instead of changing the schema for backwards compatibility.
PTAL.
Bugs: MESOS-824
https://issues.apache.org/jira/browse/MESOS-824
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/master/http.cpp d7cd89f0a3446f4c2e65ecd259544149bf92faf8
src/slave/http.cpp 1358810cde91fc64d190196e0a7675fa30d8f106
Diff: https://reviews.apache.org/r/15724/diff/
Testing
-------
Tested locally by hitting the endpoints.
Thanks,
Vinod Kone
Re: Review Request 15724: Exposed FrameworkInfo in state.json.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15724/#review29189
-----------------------------------------------------------
src/master/http.cpp
<https://reviews.apache.org/r/15724/#comment56336>
Any reason to avoid JSON::Protobuf? It was created to eliminate this boilerplate:
return JSON::Protobuf(frameworkInfo);
at which point this model function seems unnecessary
- Ben Mahler
On Nov. 20, 2013, 8:01 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15724/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2013, 8:01 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Ross Allen.
>
>
> Bugs: MESOS-824
> https://issues.apache.org/jira/browse/MESOS-824
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/http.cpp 218906a0c1f056faa30213e10f2f7762b518ecc8
> src/slave/http.cpp 2f0bd8d63cdd3fce4e0fb401e818f828baf1447e
>
> Diff: https://reviews.apache.org/r/15724/diff/
>
>
> Testing
> -------
>
> Tested locally by hitting the endpoints.
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 15724: Exposed FrameworkInfo in state.json.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15724/
-----------------------------------------------------------
(Updated Nov. 20, 2013, 8:01 p.m.)
Review request for mesos, Ben Mahler, Niklas Nielsen, and Ross Allen.
Changes
-------
added niklas and ross.
Bugs: MESOS-824
https://issues.apache.org/jira/browse/MESOS-824
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/master/http.cpp 218906a0c1f056faa30213e10f2f7762b518ecc8
src/slave/http.cpp 2f0bd8d63cdd3fce4e0fb401e818f828baf1447e
Diff: https://reviews.apache.org/r/15724/diff/
Testing
-------
Tested locally by hitting the endpoints.
Thanks,
Vinod Kone