You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by soralee <gi...@git.apache.org> on 2017/02/07 07:35:10 UTC
[GitHub] zeppelin pull request #1984: [HOTFIX] Change the screenshot path in custome ...
GitHub user soralee opened a pull request:
https://github.com/apache/zeppelin/pull/1984
[HOTFIX] Change the screenshot path in custome page document
### What is this PR for?
After merging [PR1804](https://github.com/apache/zeppelin/pull/1804), the following screenshot path is fault.
I fixed to change from absolute path to relative path.
### What type of PR is it?
[Bug Fix | Hot Fix]
### What is the Jira issue?
* None
### How should this be tested?
1. Run website locally
2. Please check [Show note list in your custom homepage](http://localhost:4000/manual/notebookashomepage.html#show-note-list-in-your-custom-homepage)
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/soralee/zeppelin notelist_png_path
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1984.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1984
----
commit ea6f51fb0ee224c74dab5562a3c35c938ed9fc2b
Author: soralee <so...@zepl.com>
Date: 2017-02-07T07:20:59Z
change png path
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1984: [HOTFIX] Change the screenshot path in custome page do...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1984
LGTM. Will merge as a hotfix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1984: [HOTFIX] Change the screenshot path in custom page doc...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/1984
@AhyoungRyu Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1984: [HOTFIX] Change the screenshot path in custom page doc...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/1984
Thanks @AhyoungRyu for quick review! :smiley_cat:
(and Sorry for that I missed your comment before)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1984: [HOTFIX] Change the screenshot path in custom p...
Posted by soralee <gi...@git.apache.org>.
GitHub user soralee reopened a pull request:
https://github.com/apache/zeppelin/pull/1984
[HOTFIX] Change the screenshot path in custom page document
### What is this PR for?
After merging [PR1804](https://github.com/apache/zeppelin/pull/1804), the following screenshot path is fault.
I fixed to change from absolute path to relative path.
### What type of PR is it?
[Bug Fix | Hot Fix]
### What is the Jira issue?
* None
### How should this be tested?
1. Run website locally
2. Please check [Show note list in your custom homepage](http://localhost:4000/manual/notebookashomepage.html#show-note-list-in-your-custom-homepage)
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/soralee/zeppelin notelist_png_path
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1984.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1984
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1984: [HOTFIX] Change the screenshot path in custom p...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1984
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1984: [HOTFIX] Change the screenshot path in custom p...
Posted by soralee <gi...@git.apache.org>.
Github user soralee closed the pull request at:
https://github.com/apache/zeppelin/pull/1984
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1984: [HOTFIX] Change the screenshot path in custom page doc...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1984
@soralee No worries! Just merged and deployed to both 0.7.0 & 0.8.0-SNAPSHOT docs page :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---