You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "zpinto (via GitHub)" <gi...@apache.org> on 2023/08/31 19:00:53 UTC

[GitHub] [helix] zpinto commented on a diff in pull request #2610: Change TopStateHandoffReportStage to be an Async Stage

zpinto commented on code in PR #2610:
URL: https://github.com/apache/helix/pull/2610#discussion_r1312082626


##########
helix-core/src/test/java/org/apache/helix/controller/stages/BaseStageTest.java:
##########
@@ -209,7 +210,11 @@ protected void runStage(ClusterEvent event, Stage stage) {
     stage.init(context);
     stage.preProcess();
     try {
-      stage.process(event);
+      if (stage instanceof AbstractAsyncBaseStage) {
+        ((AbstractAsyncBaseStage) stage).execute(event);

Review Comment:
   This is necessary to execute the business logic of any async stage because that logic is in execute method instead of process method since AbstractAsyncStage overrides the process method to run execute on async worker. TestAsyncBaseStage tests AbstractAsyncStage's process method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org