You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tuscany.apache.org by sl...@apache.org on 2010/03/11 17:27:18 UTC
svn commit: r921921 -
/tuscany/sca-java-2.x/trunk/modules/builder/src/main/java/org/apache/tuscany/sca/builder/impl/ComponentPolicyBuilderImpl.java
Author: slaws
Date: Thu Mar 11 16:27:18 2010
New Revision: 921921
URL: http://svn.apache.org/viewvc?rev=921921&view=rev
Log:
TUSCANY-3483 Add missed comments and remove commented out code
Modified:
tuscany/sca-java-2.x/trunk/modules/builder/src/main/java/org/apache/tuscany/sca/builder/impl/ComponentPolicyBuilderImpl.java
Modified: tuscany/sca-java-2.x/trunk/modules/builder/src/main/java/org/apache/tuscany/sca/builder/impl/ComponentPolicyBuilderImpl.java
URL: http://svn.apache.org/viewvc/tuscany/sca-java-2.x/trunk/modules/builder/src/main/java/org/apache/tuscany/sca/builder/impl/ComponentPolicyBuilderImpl.java?rev=921921&r1=921920&r2=921921&view=diff
==============================================================================
--- tuscany/sca-java-2.x/trunk/modules/builder/src/main/java/org/apache/tuscany/sca/builder/impl/ComponentPolicyBuilderImpl.java (original)
+++ tuscany/sca-java-2.x/trunk/modules/builder/src/main/java/org/apache/tuscany/sca/builder/impl/ComponentPolicyBuilderImpl.java Thu Mar 11 16:27:18 2010
@@ -220,6 +220,24 @@ public class ComponentPolicyBuilderImpl
}
}
+ /**
+ * Checks if any qualifiable intents of intents in an excluded intent list match
+ * with a second intent. looking for the case where
+ *
+ * <intent name="intentA" excludes="intentB"/>
+ * <intent name="intentB" >
+ * <sca:qualifier name="q1" default="true"/>
+ * <sca:qualifier name="q2" default="true"/>
+ * </intent>
+ *
+ * And were
+ *
+ * requires="intentA intentB.q1" appears on an element
+ *
+ * @param excludedIntentList
+ * @param intent
+ * @return
+ */
protected boolean checkQualifiedMutualExclusion(List<Intent> excludedIntentList, Intent intent){
for (Intent excludedIntent : excludedIntentList){
if (intent.getQualifiableIntent() != null &&
@@ -231,6 +249,14 @@ public class ComponentPolicyBuilderImpl
return false;
}
+ /**
+ * Check if two intents are mutually exclusive
+ *
+ * @param i1
+ * @param i2
+ * @param context
+ * @return
+ */
protected boolean checkMutualExclusion(Intent i1, Intent i2, BuilderContext context){
if ((i1 != i2) &&
(i1.getExcludedIntents().contains(i2) ||
@@ -258,17 +284,7 @@ public class ComponentPolicyBuilderImpl
for (Intent i2 : subject1.getRequiredIntents()) {
if (checkMutualExclusion(i1, i2, context)){
return true;
- }
-/*
- if ((i1 != i2) &&
- (i1.getExcludedIntents().contains(i2) ||
- i2.getExcludedIntents().contains(i1) ||
- matchQualifiedMutualExclusion(i1.getExcludedIntents(), i2) ||
- matchQualifiedMutualExclusion(i2.getExcludedIntents(), i1))) {
- error(context.getMonitor(), "MutuallyExclusiveIntents", new Object[] {subject1}, i1, i2);
- return true;
- }
-*/
+ }
}
}
return false;
@@ -289,16 +305,7 @@ public class ComponentPolicyBuilderImpl
for (Intent i2 : subject2.getRequiredIntents()) {
if (checkMutualExclusion(i1, i2, context)){
return true;
- }
-/*
- if (i1.getExcludedIntents().contains(i2) ||
- i2.getExcludedIntents().contains(i1) ||
- matchQualifiedMutualExclusion(i1.getExcludedIntents(), i2) ||
- matchQualifiedMutualExclusion(i2.getExcludedIntents(), i1)) {
- error(context.getMonitor(), "MutuallyExclusiveIntents", new Object[] {subject1, subject2}, i1, i2);
- return true;
- }
-*/
+ }
}
}
return false;
@@ -318,13 +325,7 @@ public class ComponentPolicyBuilderImpl
Intent i2 = intents.get(j);
if (checkMutualExclusion(i1, i2, context)){
return true;
- }
-/*
- if (i1 != i2 && i1.getExcludedIntents().contains(i2) || i2.getExcludedIntents().contains(i1)) {
- error(context.getMonitor(), "MutuallyExclusiveIntents", subject, i1, i2);
- return true;
- }
-*/
+ }
}
}
return false;