You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Ashutosh Chauhan <ha...@apache.org> on 2014/01/09 17:52:19 UTC

Review Request 16755: Next in series of fixing Path usage in Hive.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16755/
-----------------------------------------------------------

Review request for hive.


Bugs: HIVE-6171
    https://issues.apache.org/jira/browse/HIVE-6171


Repository: hive


Description
-------

Next in series of fixing Path usage in Hive.


Diffs
-----

  trunk/ql/src/java/org/apache/hadoop/hive/ql/Context.java 1556862 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1556862 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 1556862 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1556862 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 1556862 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 1556862 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/SimpleFetchAggregation.java 1556862 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/BucketingSortingOpProcFactory.java 1556862 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinTaskDispatcher.java 1556862 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/unionproc/UnionProcFactory.java 1556862 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1556862 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java 1556862 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 1556862 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1556862 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DynamicPartitionCtx.java 1556862 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/FileSinkDesc.java 1556862 
  trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java 1556862 
  trunk/ql/src/test/results/compiler/plan/case_sensitivity.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/cast1.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/groupby1.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/groupby2.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/groupby3.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/groupby4.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/groupby5.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/groupby6.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/input1.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/input2.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/input20.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/input3.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/input4.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/input5.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/input6.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/input7.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/input8.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/input9.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/input_part1.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/input_testsequencefile.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/input_testxpath.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/input_testxpath2.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/join1.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/join2.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/join3.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/join4.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/join5.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/join6.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/join7.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/join8.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/sample1.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/sample2.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/sample3.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/sample4.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/sample5.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/sample6.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/sample7.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/subq.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/udf1.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/udf4.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/udf6.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/udf_case.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/udf_when.q.xml 1556862 
  trunk/ql/src/test/results/compiler/plan/union.q.xml 1556862 

Diff: https://reviews.apache.org/r/16755/diff/


Testing
-------

Only refactoring change. No new functionality. Existing regression suite suffices.


Thanks,

Ashutosh Chauhan

Re: Review Request 16755: Next in series of fixing Path usage in Hive.

Posted by Thejas Nair <th...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16755/#review31502
-----------------------------------------------------------

Ship it!


Ship It!

- Thejas Nair


On Jan. 9, 2014, 4:52 p.m., Ashutosh Chauhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16755/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2014, 4:52 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-6171
>     https://issues.apache.org/jira/browse/HIVE-6171
> 
> 
> Repository: hive
> 
> 
> Description
> -------
> 
> Next in series of fixing Path usage in Hive.
> 
> 
> Diffs
> -----
> 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/Context.java 1556862 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1556862 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 1556862 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1556862 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 1556862 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 1556862 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/SimpleFetchAggregation.java 1556862 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/BucketingSortingOpProcFactory.java 1556862 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinTaskDispatcher.java 1556862 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/unionproc/UnionProcFactory.java 1556862 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1556862 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java 1556862 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 1556862 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1556862 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DynamicPartitionCtx.java 1556862 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/FileSinkDesc.java 1556862 
>   trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java 1556862 
>   trunk/ql/src/test/results/compiler/plan/case_sensitivity.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/cast1.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/groupby1.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/groupby2.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/groupby3.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/groupby4.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/groupby5.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/groupby6.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/input1.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/input2.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/input20.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/input3.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/input4.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/input5.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/input6.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/input7.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/input8.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/input9.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/input_part1.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/input_testsequencefile.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/input_testxpath.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/input_testxpath2.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/join1.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/join2.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/join3.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/join4.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/join5.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/join6.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/join7.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/join8.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/sample1.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/sample2.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/sample3.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/sample4.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/sample5.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/sample6.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/sample7.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/subq.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/udf1.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/udf4.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/udf6.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/udf_case.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/udf_when.q.xml 1556862 
>   trunk/ql/src/test/results/compiler/plan/union.q.xml 1556862 
> 
> Diff: https://reviews.apache.org/r/16755/diff/
> 
> 
> Testing
> -------
> 
> Only refactoring change. No new functionality. Existing regression suite suffices.
> 
> 
> Thanks,
> 
> Ashutosh Chauhan
> 
>