[GitHub] [incubator-nuttx-apps] slorquet commented on pull request #791: Revert "Follow up task_spawn change from kernel side"

[GitBox <gi...@apache.org>]

slorquet commented on pull request #791:
URL: https://github.com/apache/incubator-nuttx-apps/pull/791#issuecomment-872334098


   @davids5 yep no issue with this technical change, it saves a bit of stack and is more posix compliant
   
   posix_spawn has the *pid parameter, but the function here is task_spawn, which is not in posix (seems so)
   
   Having task_spawn returns the PID and have one less parameter is at least consistent with VXWorks: http://beru.univ-brest.fr/~singhoff/ENS/UE_temps_reel/TP-VXWORKS/CORRECTION/Man-VxWorks-1.pdf
   
   yes it's in master, so there are no release notes yet. This might just need to be a reminder to document this in the next release notes :)
   
   Moreover, you have no ability to test this, because all is going to be well if the apps master matches the nuttx master
   
   The issue happens only with "old" apps.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org