You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/09 03:30:04 UTC
[GitHub] [apisix] dickens7 opened a new pull request #2193: fixed #2191
dickens7 opened a new pull request #2193:
URL: https://github.com/apache/apisix/pull/2193
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [x] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] dickens7 commented on pull request #2193: fixed #2191
Posted by GitBox <gi...@apache.org>.
dickens7 commented on pull request #2193:
URL: https://github.com/apache/apisix/pull/2193#issuecomment-689441251
I think it’s not a good idea to remove the sample variable, I moved the sample decision logic to create_tracer function. Keep upstream decided to sample the request, we do too.
发送自 Windows 10 版邮件
发件人: Wen Ming
发送时间: 2020年9月9日 16:20
收件人: apache/apisix
抄送: seven dickens; Author
主题: Re: [apache/apisix] fixed #2191 (#2193)
apisix/plugins/zipkin/codec.lua:41:13: value assigned to variable sample is unused
please remove sample variable, thx
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on pull request #2193: fixed #2191
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #2193:
URL: https://github.com/apache/apisix/pull/2193#issuecomment-691795888
> thx, it will be better if you can add test cases.
ping @dickens7
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] dickens7 commented on pull request #2193: fixed #2191
Posted by GitBox <gi...@apache.org>.
dickens7 commented on pull request #2193:
URL: https://github.com/apache/apisix/pull/2193#issuecomment-691832972
> thx, it will be better if you can add test cases.
I'm sorry to be a little busy these few days, maybe a few days later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on pull request #2193: fixed #2191
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #2193:
URL: https://github.com/apache/apisix/pull/2193#issuecomment-690119857
thx, it will be better if you can add test cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on pull request #2193: fixed #2191
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #2193:
URL: https://github.com/apache/apisix/pull/2193#issuecomment-689408350
```
apisix/plugins/zipkin/codec.lua:41:13: value assigned to variable sample is unused
```
please remove `sample` variable, thx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming removed a comment on pull request #2193: fixed #2191
Posted by GitBox <gi...@apache.org>.
moonming removed a comment on pull request #2193:
URL: https://github.com/apache/apisix/pull/2193#issuecomment-689408350
```
apisix/plugins/zipkin/codec.lua:41:13: value assigned to variable sample is unused
```
please remove `sample` variable, thx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis merged pull request #2193: fixed #2191
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #2193:
URL: https://github.com/apache/apisix/pull/2193
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org