[GitHub] [spark] kyoty commented on a change in pull request #31882: [WIP][SPARK-34787] Option variable in Spark historyServer log should be displayed as actual value instead of Some(XX)

[GitBox <gi...@apache.org>]

kyoty commented on a change in pull request #31882:
URL: https://github.com/apache/spark/pull/31882#discussion_r597375793



##########
File path: core/src/main/scala/org/apache/spark/deploy/history/ApplicationCache.scala
##########
@@ -156,18 +156,19 @@ private[history] class ApplicationCache(
    */
   @throws[NoSuchElementException]
   private def loadApplicationEntry(appId: String, attemptId: Option[String]): CacheEntry = {
-    logDebug(s"Loading application Entry $appId/$attemptId")
+    logDebug(s"Loading application Entry $appId" + attemptId.map { id => s"/$id" }.getOrElse(""))

Review comment:
       Thank you for your suggestion. I'm not sure if the attemptId doesn't exist, would it be more friendly to display as **appId** instead of **appId/**? Looking forward to your suggestion. 🙂 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org