You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/06/04 02:16:00 UTC
[jira] [Commented] (AIRFLOW-5873) KubernetesPodOperator fixes and
test
[ https://issues.apache.org/jira/browse/AIRFLOW-5873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125475#comment-17125475 ]
ASF subversion and git services commented on AIRFLOW-5873:
----------------------------------------------------------
Commit 368bc95fa87f7f47c4f53f2355ffcb95c5f8abb0 in airflow's branch refs/heads/v1-10-test from david
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=368bc95 ]
[AIRFLOW-5873] KubernetesPodOperator fixes and test (#6524)
- `security_context` was missing from docs of `KubernetesPodOperator`
- `KubernetesPodOperator` kwarg `in_cluster` erroneously defaults to
False in comparison to `default_args.py`, also default `do_xcom_push`
was overwritten to False in contradiction to `BaseOperator`
- `KubernetesPodOperator` kwarg `resources` is erroneously passed to
`base_operator`, instead should only go to `PodGenerator`. The two
have different syntax. (both on `master` and `v1-10-test` branches)
- `kubernetes/pod.py`: classes do not have `__slots__`
so they would accept arbitrary values in `setattr`
- Reduce amount of times the pod object is copied before execution
(cherry picked from commit cf38ddc0571634588883699f481c219a0bb2fbcd)
> KubernetesPodOperator fixes and test
> ------------------------------------
>
> Key: AIRFLOW-5873
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5873
> Project: Apache Airflow
> Issue Type: Bug
> Components: operators
> Affects Versions: 1.10.6
> Reporter: David de L.
> Assignee: David de L.
> Priority: Major
> Fix For: 1.10.7
>
>
> There are two PR's for this task, one targeted at v1-10-test branch, and one adapted to master branch.
> * `KubernetesPodOperator` kwarg `resources` is erroneously passed to `base_operator`, instead should only go to `PodGenerator`. The two have different syntax. (both on `master` and `v1-10-test` branches)
> * `resources` passed to PodGenerator [should be `k8s.V1ResourceRequirements`]([https://github.com/kubernetes-client/python/blob/3739db034d34b035bc8141740e9073c84ab192c0/kubernetes/client/models/v1_container.py#L45]), which is now handled in `KubernetesPodOperator`
> * `kubernetes/pod.py`: `Resources` does not have `__slots__` so accepts arbitrary values in `setattr` (not present on either branch https://github.com/apache/airflow/blame/50343040ff4679e32e01f138ead80bc4bcef4b47/airflow/contrib/operators/kubernetes_pod_operator.py#L166-L171)
> * `v1-10-test` is behind `master` with KubernetesPodOperator fixes and refactors
> ** e.g. move kubernetes folder one level up from `/contrib` [https://github.com/apache/airflow/blame/4dd24a2c595d4042ffe745aed947eaaea6abb652/airflow/contrib/operators/kubernetes_pod_operator.py#L21]
> ** fix `xcom_push` to `do_xcom_push` [https://github.com/apache/airflow/blame/4dd24a2c595d4042ffe745aed947eaaea6abb652/airflow/contrib/operators/kubernetes_pod_operator.py#L90]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)