You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Shivaram Venkataraman (JIRA)" <ji...@apache.org> on 2015/08/19 07:39:47 UTC

[jira] [Resolved] (SPARK-6813) SparkR style guide

     [ https://issues.apache.org/jira/browse/SPARK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shivaram Venkataraman resolved SPARK-6813.
------------------------------------------
       Resolution: Fixed
         Assignee: Yu Ishikawa
    Fix Version/s: 1.5.0

I'm marking this as resolved as we've basically made the 1.5 code compliant with the style guide. The lint-r on Jenkins will run on master branch which is also compliant.

> SparkR style guide
> ------------------
>
>                 Key: SPARK-6813
>                 URL: https://issues.apache.org/jira/browse/SPARK-6813
>             Project: Spark
>          Issue Type: New Feature
>          Components: SparkR
>            Reporter: Shivaram Venkataraman
>            Assignee: Yu Ishikawa
>             Fix For: 1.5.0
>
>
> We should develop a SparkR style guide document based on the some of the guidelines we use and some of the best practices in R.
> Some examples of R style guide are:
> http://r-pkgs.had.co.nz/r.html#style 
> http://google-styleguide.googlecode.com/svn/trunk/google-r-style.html
> A related issue is to work on a automatic style checking tool. https://github.com/jimhester/lintr seems promising
> We could have a R style guide based on the one from google [1], and adjust some of them with the conversation in Spark:
> 1. Line Length: maximum 100 characters
> 2. no limit on function name (API should be similar as in other languages)
> 3. Allow S4 objects/methods



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org